Merge branch 'dev' of git.science.uu.nl:ics/sp/2025/n25b/pepperplus-cb into feat/program-reset-llm

test/unit/agents/bdi/test_bdi_core_agent.py

@@ -1,4 +1,6 @@
+import asyncio
 import json
+import time
 from unittest.mock import AsyncMock, MagicMock, mock_open, patch
 
 import agentspeak
@@ -77,11 +79,6 @@ async def test_incorrect_belief_collector_message(agent, mock_settings):
     agent.bdi_agent.call.assert_not_called()  # did not set belief
 
 
-@pytest.mark.asyncio
-async def test():
-    pass
-
-
 @pytest.mark.asyncio
 async def test_handle_llm_response(agent):
     """Test that LLM responses are forwarded to the Robot Speech Agent"""
@@ -124,3 +121,148 @@ async def test_custom_actions(agent):
     next(gen)  # Execute
 
     agent._send_to_llm.assert_called_with("Hello", "Norm", "Goal")
+
+
+def test_add_belief_sets_event(agent):
+    """Test that a belief triggers wake event and call()"""
+    agent._wake_bdi_loop = MagicMock()
+
+    belief = Belief(name="test_belief", arguments=["a", "b"])
+    agent._apply_beliefs([belief])
+
+    assert agent.bdi_agent.call.called
+    agent._wake_bdi_loop.set.assert_called()
+
+
+def test_apply_beliefs_empty_returns(agent):
+    """Line: if not beliefs: return"""
+    agent._wake_bdi_loop = MagicMock()
+    agent._apply_beliefs([])
+    agent.bdi_agent.call.assert_not_called()
+    agent._wake_bdi_loop.set.assert_not_called()
+
+
+def test_remove_belief_success_wakes_loop(agent):
+    """Line: if result: wake set"""
+    agent._wake_bdi_loop = MagicMock()
+    agent.bdi_agent.call.return_value = True
+
+    agent._remove_belief("remove_me", ["x"])
+
+    assert agent.bdi_agent.call.called
+    trigger, goaltype, literal, *_ = agent.bdi_agent.call.call_args.args
+
+    assert trigger == agentspeak.Trigger.removal
+    assert goaltype == agentspeak.GoalType.belief
+    assert literal.functor == "remove_me"
+    assert literal.args[0].functor == "x"
+
+    agent._wake_bdi_loop.set.assert_called()
+
+
+def test_remove_belief_failure_does_not_wake(agent):
+    """Line: else result is False"""
+    agent._wake_bdi_loop = MagicMock()
+    agent.bdi_agent.call.return_value = False
+
+    agent._remove_belief("not_there", ["y"])
+
+    assert agent.bdi_agent.call.called  # removal was attempted
+    agent._wake_bdi_loop.set.assert_not_called()
+
+
+def test_remove_all_with_name_wakes_loop(agent):
+    """Cover _remove_all_with_name() removed counter + wake"""
+    agent._wake_bdi_loop = MagicMock()
+
+    fake_literal = agentspeak.Literal("delete_me", (agentspeak.Literal("arg1"),))
+    fake_key = ("delete_me", 1)
+    agent.bdi_agent.beliefs = {fake_key: {fake_literal}}
+
+    agent._remove_all_with_name("delete_me")
+
+    assert agent.bdi_agent.call.called
+    agent._wake_bdi_loop.set.assert_called()
+
+
+@pytest.mark.asyncio
+async def test_bdi_step_true_branch_hits_line_67(agent):
+    """Force step() to return True once so line 67 is actually executed"""
+    # counter that isn't tied to MagicMock.call_count ordering
+    counter = {"i": 0}
+
+    def fake_step():
+        counter["i"] += 1
+        return counter["i"] == 1  # True only first time
+
+    # Important: wrap fake_step into another mock so `.called` still exists
+    agent.bdi_agent.step = MagicMock(side_effect=fake_step)
+    agent.bdi_agent.shortest_deadline = MagicMock(return_value=None)
+
+    agent._running = True
+    agent._wake_bdi_loop = asyncio.Event()
+    agent._wake_bdi_loop.set()
+
+    task = asyncio.create_task(agent._bdi_loop())
+    await asyncio.sleep(0.01)
+    task.cancel()
+    try:
+        await task
+    except asyncio.CancelledError:
+        pass
+
+    assert agent.bdi_agent.step.called
+    assert counter["i"] >= 1  # proves True branch ran
+
+
+def test_replace_belief_calls_remove_all(agent):
+    """Cover: if belief.replace: self._remove_all_with_name()"""
+    agent._remove_all_with_name = MagicMock()
+    agent._wake_bdi_loop = MagicMock()
+
+    belief = Belief(name="user_said", arguments=["Hello"], replace=True)
+    agent._apply_beliefs([belief])
+
+    agent._remove_all_with_name.assert_called_with("user_said")
+
+
+@pytest.mark.asyncio
+async def test_send_to_llm_creates_prompt_and_sends(agent):
+    """Cover entire _send_to_llm() including message send and logger.info"""
+    agent.bdi_agent = MagicMock()  # ensure mocked BDI does not interfere
+    agent._wake_bdi_loop = MagicMock()
+
+    await agent._send_to_llm("hello world", "n1\nn2", "g1")
+
+    # send() was called
+    assert agent.send.called
+    sent_msg: InternalMessage = agent.send.call_args.args[0]
+
+    # Message routing values correct
+    assert sent_msg.to == settings.agent_settings.llm_name
+    assert "hello world" in sent_msg.body
+
+    # JSON contains split norms/goals
+    body = json.loads(sent_msg.body)
+    assert body["norms"] == ["n1", "n2"]
+    assert body["goals"] == ["g1"]
+
+
+@pytest.mark.asyncio
+async def test_deadline_sleep_branch(agent):
+    """Specifically assert the if deadline: sleep → maybe_more_work=True branch"""
+    future_deadline = time.time() + 0.005
+    agent.bdi_agent.step.return_value = False
+    agent.bdi_agent.shortest_deadline.return_value = future_deadline
+
+    start_time = time.time()
+    agent._running = True
+    agent._wake_bdi_loop = asyncio.Event()
+    agent._wake_bdi_loop.set()
+
+    task = asyncio.create_task(agent._bdi_loop())
+    await asyncio.sleep(0.01)
+    task.cancel()
+
+    duration = time.time() - start_time
+    assert duration >= 0.004  # loop slept until deadline

test/unit/agents/bdi/test_belief_collector.py

@@ -87,3 +87,49 @@ async def test_send_beliefs_to_bdi(agent):
     assert sent.to == settings.agent_settings.bdi_core_name
     assert sent.thread == "beliefs"
     assert json.loads(sent.body)["beliefs"] == [belief.model_dump() for belief in beliefs]
+
+
+@pytest.mark.asyncio
+async def test_setup_executes(agent):
+    """Covers setup and asserts the agent has a name."""
+    await agent.setup()
+    assert agent.name == "belief_collector_agent"  # simple property assertion
+
+
+@pytest.mark.asyncio
+async def test_handle_message_unrecognized_type_executes(agent):
+    """Covers the else branch for unrecognized message type."""
+    payload = {"type": "unknown_type"}
+    msg = make_msg(payload, sender="tester")
+    # Wrap send to ensure nothing is sent
+    agent.send = AsyncMock()
+    await agent.handle_message(msg)
+    # Assert no messages were sent
+    agent.send.assert_not_awaited()
+
+
+@pytest.mark.asyncio
+async def test_handle_emo_text_executes(agent):
+    """Covers the _handle_emo_text method."""
+    # The method does nothing, but we can assert it returns None
+    result = await agent._handle_emo_text({}, "origin")
+    assert result is None
+
+
+@pytest.mark.asyncio
+async def test_send_beliefs_to_bdi_empty_executes(agent):
+    """Covers early return when beliefs are empty."""
+    agent.send = AsyncMock()
+    await agent._send_beliefs_to_bdi({})
+    # Assert that nothing was sent
+    agent.send.assert_not_awaited()
+
+
+@pytest.mark.asyncio
+async def test_handle_belief_text_invalid_returns_none(agent, mocker):
+    payload = {"type": "belief_extraction_text", "beliefs": {"user_said": "invalid-argument"}}
+
+    result = await agent._handle_belief_text(payload, "origin")
+
+    # The method itself returns None
+    assert result is None

test/unit/agents/bdi/test_text_extractor.py

@@ -56,3 +56,10 @@ async def test_process_transcription_demo(agent, mock_settings):
     assert sent.thread == "beliefs"
     parsed = json.loads(sent.body)
     assert parsed["beliefs"]["user_said"] == [transcription]
+
+
+@pytest.mark.asyncio
+async def test_setup_initializes_beliefs(agent):
+    """Covers the setup method and ensures beliefs are initialized."""
+    await agent.setup()
+    assert agent.beliefs == {"mood": ["X"], "car": ["Y"]}

test/unit/agents/communication/test_ri_communication_agent.py

@@ -334,3 +334,13 @@ async def test_listen_loop_ping_sends_internal(zmq_context):
     await agent._listen_loop()
 
     pub_socket.send_multipart.assert_awaited()
+
+
+@pytest.mark.asyncio
+async def test_negotiate_req_socket_none_causes_retry(zmq_context):
+    agent = RICommunicationAgent("ri_comm")
+    agent._req_socket = None
+
+    result = await agent._negotiate_connection(max_retries=1)
+
+    assert result is False

test/unit/agents/llm/test_llm_agent.py

@@ -136,6 +136,131 @@ def test_llm_instructions():
     assert "Goals to reach" in text_def
 
 
+@pytest.mark.asyncio
+async def test_handle_message_validation_error_branch_no_send(mock_httpx_client, mock_settings):
+    """
+    Covers the ValidationError branch:
+        except ValidationError:
+            self.logger.debug("Prompt message from BDI core is invalid.")
+    Assert: no message is sent.
+    """
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    # Invalid JSON that triggers ValidationError in LLMPromptMessage
+    invalid_json = '{"text": "Hi", "wrong_field": 123}'  # field not in schema
+
+    msg = InternalMessage(
+        to="llm_agent",
+        sender=mock_settings.agent_settings.bdi_core_name,
+        body=invalid_json,
+    )
+
+    await agent.handle_message(msg)
+
+    # Should not send any reply
+    agent.send.assert_not_called()
+
+
+@pytest.mark.asyncio
+async def test_handle_message_ignored_sender_branch_no_send(mock_httpx_client, mock_settings):
+    """
+    Covers the else branch for messages not from BDI core:
+        else:
+            self.logger.debug("Message ignored (not from BDI core.")
+    Assert: no message is sent.
+    """
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    msg = InternalMessage(
+        to="llm_agent",
+        sender="some_other_agent",  # Not BDI core
+        body='{"text": "Hi"}',
+    )
+
+    await agent.handle_message(msg)
+
+    # Should not send any reply
+    agent.send.assert_not_called()
+
+
+@pytest.mark.asyncio
+async def test_query_llm_yields_final_tail_chunk(mock_settings):
+    """
+    Covers the branch: if current_chunk: yield current_chunk
+    Ensure that the last partial chunk is emitted.
+    """
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    # Patch _stream_query_llm to yield tokens that do NOT end with punctuation
+    async def fake_stream(messages):
+        yield "Hello"
+        yield " world"  # No punctuation to trigger the normal chunking
+
+    agent._stream_query_llm = fake_stream
+
+    prompt = LLMPromptMessage(text="Hi", norms=[], goals=[])
+
+    # Collect chunks yielded
+    chunks = []
+    async for chunk in agent._query_llm(prompt.text, prompt.norms, prompt.goals):
+        chunks.append(chunk)
+
+    # The final chunk should be yielded
+    assert chunks[-1] == "Hello world"
+    assert any("Hello" in c for c in chunks)
+
+
+@pytest.mark.asyncio
+async def test_stream_query_llm_skips_non_data_lines(mock_httpx_client, mock_settings):
+    """
+    Covers: if not line or not line.startswith("data: "): continue
+    Feed lines that are empty or do not start with 'data:' and check they are skipped.
+    """
+    # Mock response
+    mock_response = MagicMock()
+    mock_response.raise_for_status = MagicMock()
+
+    lines = [
+        "",  # empty line
+        "not data",  # invalid prefix
+        'data: {"choices": [{"delta": {"content": "Hi"}}]}',
+        "data: [DONE]",
+    ]
+
+    async def aiter_lines_gen():
+        for line in lines:
+            yield line
+
+    mock_response.aiter_lines.side_effect = aiter_lines_gen
+
+    # Proper async context manager for stream
+    mock_stream_context = MagicMock()
+    mock_stream_context.__aenter__ = AsyncMock(return_value=mock_response)
+    mock_stream_context.__aexit__ = AsyncMock(return_value=None)
+
+    # Make stream return the async context manager
+    mock_httpx_client.stream = MagicMock(return_value=mock_stream_context)
+
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    # Patch settings for local LLM URL
+    with patch("control_backend.agents.llm.llm_agent.settings") as mock_sett:
+        mock_sett.llm_settings.local_llm_url = "http://localhost"
+        mock_sett.llm_settings.local_llm_model = "test-model"
+
+        # Collect tokens
+        tokens = []
+        async for token in agent._stream_query_llm([]):
+            tokens.append(token)
+
+    # Only the valid 'data:' line should yield content
+    assert tokens == ["Hi"]
+
+
 @pytest.mark.asyncio
 async def test_clear_history_command(mock_settings):
     """Test that the 'clear_history' message clears the agent's memory."""

test/unit/agents/perception/transcription_agent/test_transcription_agent.py

@@ -120,3 +120,83 @@ def test_mlx_recognizer():
                     mlx_mock.transcribe.return_value = {"text": "Hi"}
                     res = rec.recognize_speech(np.zeros(10))
                     assert res == "Hi"
+
+
+@pytest.mark.asyncio
+async def test_transcription_loop_continues_after_error(mock_zmq_context):
+    mock_sub = MagicMock()
+    mock_sub.recv = AsyncMock()
+    mock_zmq_context.instance.return_value.socket.return_value = mock_sub
+
+    fake_audio = np.zeros(16000, dtype=np.float32).tobytes()
+
+    mock_sub.recv.side_effect = [
+        fake_audio,  # first iteration → recognizer fails
+        asyncio.CancelledError(),  # second iteration → stop loop
+    ]
+
+    with patch.object(SpeechRecognizer, "best_type") as mock_best:
+        mock_recognizer = MagicMock()
+        mock_recognizer.recognize_speech.side_effect = RuntimeError("fail")
+        mock_best.return_value = mock_recognizer
+
+        agent = TranscriptionAgent("tcp://in")
+        agent._running = True  # ← REQUIRED to enter the loop
+        agent.send = AsyncMock()  # should never be called
+        agent.add_behavior = AsyncMock()  # match other tests
+
+        await agent.setup()
+
+        try:
+            await agent._transcribing_loop()
+        except asyncio.CancelledError:
+            pass
+
+        # recognizer failed, so we should never send anything
+        agent.send.assert_not_called()
+
+        # recv must have been called twice (audio then CancelledError)
+        assert mock_sub.recv.call_count == 2
+
+
+@pytest.mark.asyncio
+async def test_transcription_continue_branch_when_empty(mock_zmq_context):
+    mock_sub = MagicMock()
+    mock_sub.recv = AsyncMock()
+    mock_zmq_context.instance.return_value.socket.return_value = mock_sub
+
+    # First recv → audio chunk
+    # Second recv → Cancel loop → stop iteration
+    fake_audio = np.zeros(16000, dtype=np.float32).tobytes()
+    mock_sub.recv.side_effect = [fake_audio, asyncio.CancelledError()]
+
+    with patch.object(SpeechRecognizer, "best_type") as mock_best:
+        mock_recognizer = MagicMock()
+        mock_recognizer.recognize_speech.return_value = ""  # <— triggers the continue branch
+        mock_best.return_value = mock_recognizer
+
+        agent = TranscriptionAgent("tcp://in")
+
+        # Make loop runnable
+        agent._running = True
+        agent.send = AsyncMock()
+        agent.add_behavior = AsyncMock()
+
+        await agent.setup()
+
+        # Execute loop manually
+        try:
+            await agent._transcribing_loop()
+        except asyncio.CancelledError:
+            pass
+
+        # → Because of "continue", NO sending should occur
+        agent.send.assert_not_called()
+
+        # → Continue was hit, so we must have read exactly 2 times:
+        #    - first audio
+        #    - second CancelledError
+        assert mock_sub.recv.call_count == 2
+
+        # → recognizer was called once (first iteration)
+        assert mock_recognizer.recognize_speech.call_count == 1

test/unit/agents/perception/vad_agent/test_vad_streaming.py

@@ -1,7 +1,8 @@
-from unittest.mock import AsyncMock, MagicMock
+from unittest.mock import AsyncMock, MagicMock, patch
 
 import numpy as np
 import pytest
+import zmq
 
 from control_backend.agents.perception.vad_agent import VADAgent
 
@@ -123,3 +124,44 @@ async def test_no_data(audio_out_socket, vad_agent):
 
     audio_out_socket.send.assert_not_called()
     assert len(vad_agent.audio_buffer) == 0
+
+
+@pytest.mark.asyncio
+async def test_vad_model_load_failure_stops_agent(vad_agent):
+    """
+    Test that if loading the VAD model raises an Exception, it is caught,
+    the agent logs an exception, stops itself, and setup returns.
+    """
+    # Patch torch.hub.load to raise an exception
+    with patch(
+        "control_backend.agents.perception.vad_agent.torch.hub.load",
+        side_effect=Exception("model fail"),
+    ):
+        # Patch stop to an AsyncMock so we can check it was awaited
+        vad_agent.stop = AsyncMock()
+
+        result = await vad_agent.setup()
+
+        # Assert stop was called
+        vad_agent.stop.assert_awaited_once()
+        # Assert setup returned None
+        assert result is None
+
+
+@pytest.mark.asyncio
+async def test_audio_out_bind_failure_sets_none_and_logs(vad_agent, caplog):
+    """
+    Test that if binding the output socket raises ZMQBindError,
+    audio_out_socket is set to None, None is returned, and an error is logged.
+    """
+    mock_socket = MagicMock()
+    mock_socket.bind_to_random_port.side_effect = zmq.ZMQBindError()
+    with patch("control_backend.agents.perception.vad_agent.azmq.Context.instance") as mock_ctx:
+        mock_ctx.return_value.socket.return_value = mock_socket
+
+        with caplog.at_level("ERROR"):
+            port = vad_agent._connect_audio_out_socket()
+
+        assert port is None
+        assert vad_agent.audio_out_socket is None
+        assert caplog.text is not None