refactor: testing

Redid testing structure, added tests and changed some tests.

ref: N25B-301

test/unit/conftest.py

@@ -1,71 +1,43 @@
-import sys
-from unittest.mock import MagicMock
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from control_backend.core.agent_system import _agent_directory
 
 
-def pytest_configure(config):
+@pytest.fixture(autouse=True)
+def reset_agent_directory():
     """
-    This hook runs at the start of the pytest session, before any tests are
-    collected. It mocks heavy or unavailable modules to prevent ImportErrors.
+    Automatically clears the global agent directory before and after each test
+    to prevent state leakage between tests.
     """
-    # --- Mock spade and spade-bdi ---
-    mock_agentspeak = MagicMock()
-    mock_httpx = MagicMock()
-    mock_pydantic = MagicMock()
-    mock_spade = MagicMock()
-    mock_spade.agent = MagicMock()
-    mock_spade.behaviour = MagicMock()
-    mock_spade.message = MagicMock()
-    mock_spade_bdi = MagicMock()
-    mock_spade_bdi.bdi = MagicMock()
+    _agent_directory.clear()
+    yield
+    _agent_directory.clear()
 
-    mock_spade.agent.Message = MagicMock()
-    mock_spade.behaviour.CyclicBehaviour = type("CyclicBehaviour", (object,), {})
-    mock_spade_bdi.bdi.BDIAgent = type("BDIAgent", (object,), {})
 
-    # Ensure submodule imports like `agentspeak.runtime` succeed
-    mock_agentspeak.runtime = MagicMock()
-    mock_agentspeak.stdlib = MagicMock()
-    sys.modules["agentspeak"] = mock_agentspeak
-    sys.modules["agentspeak.runtime"] = mock_agentspeak.runtime
-    sys.modules["agentspeak.stdlib"] = mock_agentspeak.stdlib
-    sys.modules["httpx"] = mock_httpx
-    sys.modules["pydantic"] = mock_pydantic
-    sys.modules["spade"] = mock_spade
-    sys.modules["spade.agent"] = mock_spade.agent
-    sys.modules["spade.behaviour"] = mock_spade.behaviour
-    sys.modules["spade.message"] = mock_spade.message
-    sys.modules["spade_bdi"] = mock_spade_bdi
-    sys.modules["spade_bdi.bdi"] = mock_spade_bdi.bdi
+@pytest.fixture
+def mock_settings():
+    with patch("control_backend.core.config.settings") as mock:
+        # Set default values that match the pydantic model defaults
+        # to avoid AttributeErrors during tests
+        mock.zmq_settings.internal_pub_address = "tcp://localhost:5560"
+        mock.zmq_settings.internal_sub_address = "tcp://localhost:5561"
+        mock.zmq_settings.ri_command_address = "tcp://localhost:0000"
+        mock.agent_settings.bdi_core_name = "bdi_core_agent"
+        mock.agent_settings.bdi_belief_collector_name = "belief_collector_agent"
+        mock.agent_settings.llm_name = "llm_agent"
+        mock.agent_settings.robot_speech_name = "robot_speech_agent"
+        mock.agent_settings.transcription_name = "transcription_agent"
+        mock.agent_settings.text_belief_extractor_name = "text_belief_extractor_agent"
+        mock.agent_settings.vad_name = "vad_agent"
+        mock.behaviour_settings.sleep_s = 0.01  # Speed up tests
+        mock.behaviour_settings.comm_setup_max_retries = 1
+        yield mock
 
-    # --- Mock the config module to prevent Pydantic ImportError ---
-    mock_config_module = MagicMock()
 
-    # The code under test does `from ... import settings`, so our mock module
-    # must have a `settings` attribute. We'll make it a MagicMock so we can
-    # configure it later in our tests using mocker.patch.
-    mock_config_module.settings = MagicMock()
-
-    sys.modules["control_backend.core.config"] = mock_config_module
-
-    # --- Mock torch and zmq for VAD ---
-    mock_torch = MagicMock()
-    mock_zmq = MagicMock()
-    mock_zmq.asyncio = mock_zmq
-
-    # In individual tests, these can be imported and the return values changed
-    sys.modules["torch"] = mock_torch
-    sys.modules["zmq"] = mock_zmq
-    sys.modules["zmq.asyncio"] = mock_zmq.asyncio
-
-    # --- Mock whisper ---
-    mock_whisper = MagicMock()
-    mock_mlx = MagicMock()
-    mock_mlx.core = MagicMock()
-    mock_mlx_whisper = MagicMock()
-    mock_mlx_whisper.transcribe = MagicMock()
-
-    sys.modules["whisper"] = mock_whisper
-    sys.modules["mlx"] = mock_mlx
-    sys.modules["mlx.core"] = mock_mlx
-    sys.modules["mlx_whisper"] = mock_mlx_whisper
-    sys.modules["mlx_whisper.transcribe"] = mock_mlx_whisper.transcribe
+@pytest.fixture
+def mock_zmq_context():
+    with patch("zmq.asyncio.Context") as mock:
+        mock.instance.return_value = MagicMock()
+        yield mock