test: increased cb test coverage

test/unit/agents/llm/test_llm_agent.py

@@ -134,3 +134,128 @@ def test_llm_instructions():
     text_def = instr_def.build_developer_instruction()
     assert "Norms to follow" in text_def
     assert "Goals to reach" in text_def
+
+
+@pytest.mark.asyncio
+async def test_handle_message_validation_error_branch_no_send(mock_httpx_client, mock_settings):
+    """
+    Covers the ValidationError branch:
+        except ValidationError:
+            self.logger.debug("Prompt message from BDI core is invalid.")
+    Assert: no message is sent.
+    """
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    # Invalid JSON that triggers ValidationError in LLMPromptMessage
+    invalid_json = '{"text": "Hi", "wrong_field": 123}'  # field not in schema
+
+    msg = InternalMessage(
+        to="llm_agent",
+        sender=mock_settings.agent_settings.bdi_core_name,
+        body=invalid_json,
+    )
+
+    await agent.handle_message(msg)
+
+    # Should not send any reply
+    agent.send.assert_not_called()
+
+
+@pytest.mark.asyncio
+async def test_handle_message_ignored_sender_branch_no_send(mock_httpx_client, mock_settings):
+    """
+    Covers the else branch for messages not from BDI core:
+        else:
+            self.logger.debug("Message ignored (not from BDI core.")
+    Assert: no message is sent.
+    """
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    msg = InternalMessage(
+        to="llm_agent",
+        sender="some_other_agent",  # Not BDI core
+        body='{"text": "Hi"}',
+    )
+
+    await agent.handle_message(msg)
+
+    # Should not send any reply
+    agent.send.assert_not_called()
+
+
+@pytest.mark.asyncio
+async def test_query_llm_yields_final_tail_chunk(mock_settings):
+    """
+    Covers the branch: if current_chunk: yield current_chunk
+    Ensure that the last partial chunk is emitted.
+    """
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    # Patch _stream_query_llm to yield tokens that do NOT end with punctuation
+    async def fake_stream(messages):
+        yield "Hello"
+        yield " world"  # No punctuation to trigger the normal chunking
+
+    agent._stream_query_llm = fake_stream
+
+    prompt = LLMPromptMessage(text="Hi", norms=[], goals=[])
+
+    # Collect chunks yielded
+    chunks = []
+    async for chunk in agent._query_llm(prompt.text, prompt.norms, prompt.goals):
+        chunks.append(chunk)
+
+    # The final chunk should be yielded
+    assert chunks[-1] == "Hello world"
+    assert any("Hello" in c for c in chunks)
+
+
+@pytest.mark.asyncio
+async def test_stream_query_llm_skips_non_data_lines(mock_httpx_client, mock_settings):
+    """
+    Covers: if not line or not line.startswith("data: "): continue
+    Feed lines that are empty or do not start with 'data:' and check they are skipped.
+    """
+    # Mock response
+    mock_response = MagicMock()
+    mock_response.raise_for_status = MagicMock()
+
+    lines = [
+        "",  # empty line
+        "not data",  # invalid prefix
+        'data: {"choices": [{"delta": {"content": "Hi"}}]}',
+        "data: [DONE]",
+    ]
+
+    async def aiter_lines_gen():
+        for line in lines:
+            yield line
+
+    mock_response.aiter_lines.side_effect = aiter_lines_gen
+
+    # Proper async context manager for stream
+    mock_stream_context = MagicMock()
+    mock_stream_context.__aenter__ = AsyncMock(return_value=mock_response)
+    mock_stream_context.__aexit__ = AsyncMock(return_value=None)
+
+    # Make stream return the async context manager
+    mock_httpx_client.stream = MagicMock(return_value=mock_stream_context)
+
+    agent = LLMAgent("llm_agent")
+    agent.send = AsyncMock()
+
+    # Patch settings for local LLM URL
+    with patch("control_backend.agents.llm.llm_agent.settings") as mock_sett:
+        mock_sett.llm_settings.local_llm_url = "http://localhost"
+        mock_sett.llm_settings.local_llm_model = "test-model"
+
+        # Collect tokens
+        tokens = []
+        async for token in agent._stream_query_llm([]):
+            tokens.append(token)
+
+    # Only the valid 'data:' line should yield content
+    assert tokens == ["Hi"]