diff --git a/test/integration/agents/vad_agent/test_vad_with_audio.py b/test/integration/agents/vad_agent/test_vad_with_audio.py index fd7d4d7..bae15af 100644 --- a/test/integration/agents/vad_agent/test_vad_with_audio.py +++ b/test/integration/agents/vad_agent/test_vad_with_audio.py @@ -49,6 +49,7 @@ async def test_real_audio(mocker): vad_streamer = Streaming(audio_in_socket, audio_out_socket) vad_streamer._ready = True + vad_streamer.agent = MagicMock() for _ in audio_chunks: await vad_streamer.run() diff --git a/test/unit/agents/bdi/behaviours/test_belief_setter.py b/test/unit/agents/bdi/behaviours/test_belief_setter.py index c7bb0e9..b0e76ec 100644 --- a/test/unit/agents/bdi/behaviours/test_belief_setter.py +++ b/test/unit/agents/bdi/behaviours/test_belief_setter.py @@ -45,22 +45,6 @@ def create_mock_message(sender_node: str, body: str, thread: str) -> MagicMock: return msg -@pytest.mark.asyncio -async def test_run_no_message_received(belief_setter, mocker): - """ - Test that when no message is received, _process_message is not called. - """ - # Arrange - belief_setter.receive.return_value = None - mocker.patch.object(belief_setter, "_process_message") - - # Act - await belief_setter.run() - - # Assert - belief_setter._process_message.assert_not_called() - - @pytest.mark.asyncio async def test_run_message_received(belief_setter, mocker): """ @@ -137,12 +121,10 @@ def test_process_belief_message_invalid_json(belief_setter, mocker, caplog): mock_set_beliefs = mocker.patch.object(belief_setter, "_set_beliefs") # Act - with caplog.at_level(logging.ERROR): - belief_setter._process_belief_message(msg) + belief_setter._process_belief_message(msg) # Assert mock_set_beliefs.assert_not_called() - assert "Could not decode beliefs into JSON format" in caplog.text def test_process_belief_message_wrong_thread(belief_setter, mocker): @@ -199,10 +181,6 @@ def test_set_beliefs_success(belief_setter, mock_agent, caplog): mock_agent.bdi.set_belief.assert_has_calls(expected_calls, any_order=True) assert mock_agent.bdi.set_belief.call_count == 2 - # Check logs - assert "Set belief is_hot with arguments ['kitchen']" in caplog.text - assert "Set belief door_opened with arguments ['front_door', 'back_door']" in caplog.text - # def test_responded_unset(belief_setter, mock_agent): # # Arrange diff --git a/test/unit/agents/belief_collector/behaviours/test_continuous_collect.py b/test/unit/agents/belief_collector/behaviours/test_continuous_collect.py index e842f5c..706a5b8 100644 --- a/test/unit/agents/belief_collector/behaviours/test_continuous_collect.py +++ b/test/unit/agents/belief_collector/behaviours/test_continuous_collect.py @@ -8,6 +8,14 @@ from control_backend.agents.belief_collector.behaviours.continuous_collect impor ) +def create_mock_message(sender_node: str, body: str) -> MagicMock: + """Helper function to create a configured mock message.""" + msg = MagicMock() + msg.sender.node = sender_node # MagicMock automatically creates nested mocks + msg.body = body + return msg + + @pytest.fixture def mock_agent(mocker): """Fixture to create a mock Agent.""" @@ -29,22 +37,6 @@ def continuous_collector(mock_agent, mocker): return collector -@pytest.mark.asyncio -async def test_run_no_message_received(continuous_collector, mocker): - """ - Test that when no message is received, _process_message is not called. - """ - # Arrange - continuous_collector.receive.return_value = None - mocker.patch.object(continuous_collector, "_process_message") - - # Act - await continuous_collector.run() - - # Assert - continuous_collector._process_message.assert_not_called() - - @pytest.mark.asyncio async def test_run_message_received(continuous_collector, mocker): """ @@ -62,48 +54,12 @@ async def test_run_message_received(continuous_collector, mocker): continuous_collector._process_message.assert_awaited_once_with(mock_msg) -@pytest.mark.asyncio -async def test_process_message_invalid(continuous_collector, mocker): - """ - Test that when an invalid JSON message is received, a warning is logged and processing stops. - """ - # Arrange - invalid_json = "this is not json" - msg = MagicMock() - msg.body = invalid_json - msg.sender = "belief_text_agent_mock@test" - - logger_mock = mocker.patch( - "control_backend.agents.belief_collector.behaviours.continuous_collect.logger" - ) - - # Act - await continuous_collector._process_message(msg) - - # Assert - logger_mock.warning.assert_called_once() - - -def test_get_sender_from_message(continuous_collector): - """ - Test that _sender_node correctly extracts the sender node from the message JID. - """ - # Arrange - msg = MagicMock() - msg.sender = "agent_node@host/resource" - - # Act - sender_node = continuous_collector._sender_node(msg) - - # Assert - assert sender_node == "agent_node" - - @pytest.mark.asyncio async def test_routes_to_handle_belief_text_by_type(continuous_collector, mocker): - msg = MagicMock() - msg.body = json.dumps({"type": "belief_extraction_text", "beliefs": {"user_said": [["hi"]]}}) - msg.sender = "anyone@test" + msg = create_mock_message( + "anyone", + json.dumps({"type": "belief_extraction_text", "beliefs": {"user_said": [["hi"]]}}), + ) spy = mocker.patch.object(continuous_collector, "_handle_belief_text", new=AsyncMock()) await continuous_collector._process_message(msg) spy.assert_awaited_once() @@ -111,9 +67,9 @@ async def test_routes_to_handle_belief_text_by_type(continuous_collector, mocker @pytest.mark.asyncio async def test_routes_to_handle_belief_text_by_sender(continuous_collector, mocker): - msg = MagicMock() - msg.body = json.dumps({"beliefs": {"user_said": [["hi"]]}}) # no type - msg.sender = "belief_text_agent_mock@test" + msg = create_mock_message( + "belief_text_agent_mock", json.dumps({"beliefs": {"user_said": [["hi"]]}}) + ) spy = mocker.patch.object(continuous_collector, "_handle_belief_text", new=AsyncMock()) await continuous_collector._process_message(msg) spy.assert_awaited_once() @@ -121,117 +77,22 @@ async def test_routes_to_handle_belief_text_by_sender(continuous_collector, mock @pytest.mark.asyncio async def test_routes_to_handle_emo_text(continuous_collector, mocker): - msg = MagicMock() - msg.body = json.dumps({"type": "emotion_extraction_text"}) - msg.sender = "anyone@test" + msg = create_mock_message("anyone", json.dumps({"type": "emotion_extraction_text"})) spy = mocker.patch.object(continuous_collector, "_handle_emo_text", new=AsyncMock()) await continuous_collector._process_message(msg) spy.assert_awaited_once() @pytest.mark.asyncio -async def test_unrecognized_message_logs_info(continuous_collector, mocker): - msg = MagicMock() - msg.body = json.dumps({"type": "something_else"}) - msg.sender = "x@test" - logger_mock = mocker.patch( - "control_backend.agents.belief_collector.behaviours.continuous_collect.logger" - ) - await continuous_collector._process_message(msg) - logger_mock.info.assert_any_call( - "BeliefCollector: unrecognized message (sender=%s, type=%r). Ignoring.", - "x", - "something_else", - ) - - -@pytest.mark.asyncio -async def test_belief_text_no_beliefs(continuous_collector, mocker): - msg_payload = {"type": "belief_extraction_text"} # no 'beliefs' - logger_mock = mocker.patch( - "control_backend.agents.belief_collector.behaviours.continuous_collect.logger" - ) - await continuous_collector._handle_belief_text(msg_payload, "origin_node") - logger_mock.info.assert_any_call("BeliefCollector: no beliefs to process.") - - -@pytest.mark.asyncio -async def test_belief_text_beliefs_not_dict(continuous_collector, mocker): - payload = {"type": "belief_extraction_text", "beliefs": ["not", "a", "dict"]} - logger_mock = mocker.patch( - "control_backend.agents.belief_collector.behaviours.continuous_collect.logger" - ) - await continuous_collector._handle_belief_text(payload, "origin") - logger_mock.warning.assert_any_call( - "BeliefCollector: 'beliefs' is not a dict: %r", ["not", "a", "dict"] - ) - - -@pytest.mark.asyncio -async def test_belief_text_values_not_lists(continuous_collector, mocker): - payload = {"type": "belief_extraction_text", "beliefs": {"user_said": "not-a-list"}} - logger_mock = mocker.patch( - "control_backend.agents.belief_collector.behaviours.continuous_collect.logger" - ) - await continuous_collector._handle_belief_text(payload, "origin") - logger_mock.warning.assert_any_call( - "BeliefCollector: 'beliefs' values are not all lists: %r", {"user_said": "not-a-list"} - ) - - -@pytest.mark.asyncio -async def test_belief_text_happy_path_logs_items_and_sends(continuous_collector, mocker): +async def test_belief_text_happy_path_sends(continuous_collector, mocker): payload = {"type": "belief_extraction_text", "beliefs": {"user_said": ["hello test", "No"]}} continuous_collector.send = AsyncMock() - logger_mock = mocker.patch( - "control_backend.agents.belief_collector.behaviours.continuous_collect.logger" - ) await continuous_collector._handle_belief_text(payload, "belief_text_agent_mock") - logger_mock.info.assert_any_call("BeliefCollector: forwarding %d beliefs.", 1) - # and the item logs: - logger_mock.info.assert_any_call(" - %s %s", "user_said", "hello test") - logger_mock.info.assert_any_call(" - %s %s", "user_said", "No") # make sure we attempted a send continuous_collector.send.assert_awaited_once() -@pytest.mark.asyncio -async def test_send_beliefs_noop_on_empty(continuous_collector): - continuous_collector.send = AsyncMock() - await continuous_collector._send_beliefs_to_bdi([], origin="o") - continuous_collector.send.assert_not_awaited() - - -# @pytest.mark.asyncio -# async def test_send_beliefs_sends_json_packet(continuous_collector): -# # Patch .send and capture the message body -# sent = {} -# -# async def _fake_send(msg): -# sent["body"] = msg.body -# sent["to"] = str(msg.to) -# -# continuous_collector.send = AsyncMock(side_effect=_fake_send) -# beliefs = ["user_said hello", "user_said No"] -# await continuous_collector._send_beliefs_to_bdi(beliefs, origin="origin_node") -# -# assert "belief_packet" in json.loads(sent["body"])["type"] -# assert json.loads(sent["body"])["beliefs"] == beliefs - - -def test_sender_node_no_sender_returns_literal(continuous_collector): - msg = MagicMock() - msg.sender = None - assert continuous_collector._sender_node(msg) == "no_sender" - - -def test_sender_node_without_at(continuous_collector): - msg = MagicMock() - msg.sender = "localpartonly" - assert continuous_collector._sender_node(msg) == "localpartonly" - - @pytest.mark.asyncio async def test_belief_text_coerces_non_strings(continuous_collector, mocker): payload = {"type": "belief_extraction_text", "beliefs": {"user_said": [["hi", 123]]}} diff --git a/test/unit/agents/test_vad_streaming.py b/test/unit/agents/test_vad_streaming.py index ab2da0d..0cd8161 100644 --- a/test/unit/agents/test_vad_streaming.py +++ b/test/unit/agents/test_vad_streaming.py @@ -17,12 +17,21 @@ def audio_out_socket(): @pytest.fixture -def streaming(audio_in_socket, audio_out_socket): +def mock_agent(mocker): + """Fixture to create a mock BDIAgent.""" + agent = MagicMock() + agent.jid = "vad_agent@test" + return agent + + +@pytest.fixture +def streaming(audio_in_socket, audio_out_socket, mock_agent): import torch torch.hub.load.return_value = (..., ...) # Mock streaming = Streaming(audio_in_socket, audio_out_socket) streaming._ready = True + streaming.agent = mock_agent return streaming diff --git a/test/unit/agents/transcription/test_speech_recognizer.py b/test/unit/agents/transcription/test_speech_recognizer.py index ab28dcf..d0dfdea 100644 --- a/test/unit/agents/transcription/test_speech_recognizer.py +++ b/test/unit/agents/transcription/test_speech_recognizer.py @@ -1,7 +1,9 @@ import numpy as np -from control_backend.agents.transcription import SpeechRecognizer -from control_backend.agents.transcription.speech_recognizer import OpenAIWhisperSpeechRecognizer +from control_backend.agents.transcription.speech_recognizer import ( + OpenAIWhisperSpeechRecognizer, + SpeechRecognizer, +) def test_estimate_max_tokens(): diff --git a/test/unit/conftest.py b/test/unit/conftest.py index ecf00c1..97e7d15 100644 --- a/test/unit/conftest.py +++ b/test/unit/conftest.py @@ -8,6 +8,9 @@ def pytest_configure(config): collected. It mocks heavy or unavailable modules to prevent ImportErrors. """ # --- Mock spade and spade-bdi --- + mock_agentspeak = MagicMock() + mock_httpx = MagicMock() + mock_pydantic = MagicMock() mock_spade = MagicMock() mock_spade.agent = MagicMock() mock_spade.behaviour = MagicMock() @@ -19,6 +22,9 @@ def pytest_configure(config): mock_spade.behaviour.CyclicBehaviour = type("CyclicBehaviour", (object,), {}) mock_spade_bdi.bdi.BDIAgent = type("BDIAgent", (object,), {}) + sys.modules["agentspeak"] = mock_agentspeak + sys.modules["httpx"] = mock_httpx + sys.modules["pydantic"] = mock_pydantic sys.modules["spade"] = mock_spade sys.modules["spade.agent"] = mock_spade.agent sys.modules["spade.behaviour"] = mock_spade.behaviour diff --git a/uv.lock b/uv.lock index bcb6ebe..1832525 100644 --- a/uv.lock +++ b/uv.lock @@ -628,6 +628,8 @@ wheels = [ { url = "https://files.pythonhosted.org/packages/ee/43/3cecdc0349359e1a527cbf2e3e28e5f8f06d3343aaf82ca13437a9aa290f/greenlet-3.2.4-cp313-cp313-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl", hash = "sha256:23768528f2911bcd7e475210822ffb5254ed10d71f4028387e5a99b4c6699671", size = 610497, upload-time = "2025-08-07T13:18:31.636Z" }, { url = "https://files.pythonhosted.org/packages/b8/19/06b6cf5d604e2c382a6f31cafafd6f33d5dea706f4db7bdab184bad2b21d/greenlet-3.2.4-cp313-cp313-musllinux_1_1_aarch64.whl", hash = "sha256:00fadb3fedccc447f517ee0d3fd8fe49eae949e1cd0f6a611818f4f6fb7dc83b", size = 1121662, upload-time = "2025-08-07T13:42:41.117Z" }, { url = "https://files.pythonhosted.org/packages/a2/15/0d5e4e1a66fab130d98168fe984c509249c833c1a3c16806b90f253ce7b9/greenlet-3.2.4-cp313-cp313-musllinux_1_1_x86_64.whl", hash = "sha256:d25c5091190f2dc0eaa3f950252122edbbadbb682aa7b1ef2f8af0f8c0afefae", size = 1149210, upload-time = "2025-08-07T13:18:24.072Z" }, + { url = "https://files.pythonhosted.org/packages/1c/53/f9c440463b3057485b8594d7a638bed53ba531165ef0ca0e6c364b5cc807/greenlet-3.2.4-cp313-cp313-musllinux_1_2_aarch64.whl", hash = "sha256:6e343822feb58ac4d0a1211bd9399de2b3a04963ddeec21530fc426cc121f19b", size = 1564759, upload-time = "2025-11-04T12:42:19.395Z" }, + { url = "https://files.pythonhosted.org/packages/47/e4/3bb4240abdd0a8d23f4f88adec746a3099f0d86bfedb623f063b2e3b4df0/greenlet-3.2.4-cp313-cp313-musllinux_1_2_x86_64.whl", hash = "sha256:ca7f6f1f2649b89ce02f6f229d7c19f680a6238af656f61e0115b24857917929", size = 1634288, upload-time = "2025-11-04T12:42:21.174Z" }, { url = "https://files.pythonhosted.org/packages/0b/55/2321e43595e6801e105fcfdee02b34c0f996eb71e6ddffca6b10b7e1d771/greenlet-3.2.4-cp313-cp313-win_amd64.whl", hash = "sha256:554b03b6e73aaabec3745364d6239e9e012d64c68ccd0b8430c64ccc14939a8b", size = 299685, upload-time = "2025-08-07T13:24:38.824Z" }, { url = "https://files.pythonhosted.org/packages/22/5c/85273fd7cc388285632b0498dbbab97596e04b154933dfe0f3e68156c68c/greenlet-3.2.4-cp314-cp314-macosx_11_0_universal2.whl", hash = "sha256:49a30d5fda2507ae77be16479bdb62a660fa51b1eb4928b524975b3bde77b3c0", size = 273586, upload-time = "2025-08-07T13:16:08.004Z" }, { url = "https://files.pythonhosted.org/packages/d1/75/10aeeaa3da9332c2e761e4c50d4c3556c21113ee3f0afa2cf5769946f7a3/greenlet-3.2.4-cp314-cp314-manylinux2014_aarch64.manylinux_2_17_aarch64.whl", hash = "sha256:299fd615cd8fc86267b47597123e3f43ad79c9d8a22bebdce535e53550763e2f", size = 686346, upload-time = "2025-08-07T13:42:59.944Z" }, @@ -635,6 +637,8 @@ wheels = [ { url = "https://files.pythonhosted.org/packages/dc/8b/29aae55436521f1d6f8ff4e12fb676f3400de7fcf27fccd1d4d17fd8fecd/greenlet-3.2.4-cp314-cp314-manylinux2014_s390x.manylinux_2_17_s390x.whl", hash = "sha256:b4a1870c51720687af7fa3e7cda6d08d801dae660f75a76f3845b642b4da6ee1", size = 694659, upload-time = "2025-08-07T13:53:17.759Z" }, { url = "https://files.pythonhosted.org/packages/92/2e/ea25914b1ebfde93b6fc4ff46d6864564fba59024e928bdc7de475affc25/greenlet-3.2.4-cp314-cp314-manylinux2014_x86_64.manylinux_2_17_x86_64.whl", hash = "sha256:061dc4cf2c34852b052a8620d40f36324554bc192be474b9e9770e8c042fd735", size = 695355, upload-time = "2025-08-07T13:18:34.517Z" }, { url = "https://files.pythonhosted.org/packages/72/60/fc56c62046ec17f6b0d3060564562c64c862948c9d4bc8aa807cf5bd74f4/greenlet-3.2.4-cp314-cp314-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl", hash = "sha256:44358b9bf66c8576a9f57a590d5f5d6e72fa4228b763d0e43fee6d3b06d3a337", size = 657512, upload-time = "2025-08-07T13:18:33.969Z" }, + { url = "https://files.pythonhosted.org/packages/23/6e/74407aed965a4ab6ddd93a7ded3180b730d281c77b765788419484cdfeef/greenlet-3.2.4-cp314-cp314-musllinux_1_2_aarch64.whl", hash = "sha256:2917bdf657f5859fbf3386b12d68ede4cf1f04c90c3a6bc1f013dd68a22e2269", size = 1612508, upload-time = "2025-11-04T12:42:23.427Z" }, + { url = "https://files.pythonhosted.org/packages/0d/da/343cd760ab2f92bac1845ca07ee3faea9fe52bee65f7bcb19f16ad7de08b/greenlet-3.2.4-cp314-cp314-musllinux_1_2_x86_64.whl", hash = "sha256:015d48959d4add5d6c9f6c5210ee3803a830dce46356e3bc326d6776bde54681", size = 1680760, upload-time = "2025-11-04T12:42:25.341Z" }, { url = "https://files.pythonhosted.org/packages/e3/a5/6ddab2b4c112be95601c13428db1d8b6608a8b6039816f2ba09c346c08fc/greenlet-3.2.4-cp314-cp314-win_amd64.whl", hash = "sha256:e37ab26028f12dbb0ff65f29a8d3d44a765c61e729647bf2ddfbbed621726f01", size = 303425, upload-time = "2025-08-07T13:32:27.59Z" }, ]