refactor: agents inherit logger from BaseAgent

Created a class `BaseAgent`, from which all agents inherit. They get
assigned a logger with a nice name (something like
`control_backend.agents.AgentName`).

The BDI core takes care of its own logger, as bdi is still a module.

ref: N25B-241

src/control_backend/agents/ri_communication_agent.py

@@ -1,17 +1,16 @@
 import asyncio
-import logging
-from spade.agent import Agent
-from spade.behaviour import CyclicBehaviour
-import zmq
 
+import zmq
+from spade.behaviour import CyclicBehaviour
+
+from control_backend.agents import BaseAgent
 from control_backend.core.config import settings
 from control_backend.core.zmq_context import context
+
 from .ri_command_agent import RICommandAgent
 
-logger = logging.getLogger(__name__)
 
-
-class RICommunicationAgent(Agent):
+class RICommunicationAgent(BaseAgent):
     req_socket: zmq.Socket
     _address = ""
     _bind = True
@@ -45,13 +44,13 @@ class RICommunicationAgent(Agent):
                 message = await asyncio.wait_for(self.agent.req_socket.recv_json(), timeout=3.0)
 
             # We didnt get a reply :(
-            except asyncio.TimeoutError as e:
-                logger.info("No ping retrieved in 3 seconds, killing myself.")
+            except TimeoutError:
+                self.agent.logger.info("No ping retrieved in 3 seconds, killing myself.")
                 self.kill()
 
-            logger.debug('Received message "%s"', message)
+            self.agent.logger.debug('Received message "%s"', message)
             if "endpoint" not in message:
-                logger.error("No received endpoint in message, excepted ping endpoint.")
+                self.agent.logger.error("No received endpoint in message, excepted ping endpoint.")
                 return
 
             # See what endpoint we received
@@ -59,7 +58,7 @@ class RICommunicationAgent(Agent):
                 case "ping":
                     await asyncio.sleep(1)
                 case _:
-                    logger.info(
+                    self.agent.logger.info(
                         "Received message with topic different than ping, while ping expected."
                     )
 
@@ -67,7 +66,7 @@ class RICommunicationAgent(Agent):
         """
         Try to setup the communication agent, we have 5 retries in case we dont have a response yet.
         """
-        logger.info("Setting up %s", self.jid)
+        self.logger.info("Setting up %s", self.jid)
         retries = 0
 
         # Let's try a certain amount of times before failing connection
@@ -86,8 +85,8 @@ class RICommunicationAgent(Agent):
             try:
                 received_message = await asyncio.wait_for(self.req_socket.recv_json(), timeout=20.0)
 
-            except asyncio.TimeoutError:
-                logger.warning(
+            except TimeoutError:
+                self.logger.warning(
                     "No connection established in 20 seconds (attempt %d/%d)",
                     retries + 1,
                     max_retries,
@@ -96,7 +95,7 @@ class RICommunicationAgent(Agent):
                 continue
 
             except Exception as e:
-                logger.error("Unexpected error during negotiation: %s", e)
+                self.logger.error("Unexpected error during negotiation: %s", e)
                 retries += 1
                 continue
 
@@ -104,7 +103,7 @@ class RICommunicationAgent(Agent):
             endpoint = received_message.get("endpoint")
             if endpoint != "negotiate/ports":
                 # TODO: Should this send a message back?
-                logger.error(
+                self.logger.error(
                     "Invalid endpoint '%s' received (attempt %d/%d)",
                     endpoint,
                     retries + 1,
@@ -143,10 +142,10 @@ class RICommunicationAgent(Agent):
                             )
                             await ri_commands_agent.start()
                         case _:
-                            logger.warning("Unhandled negotiation id: %s", id)
+                            self.logger.warning("Unhandled negotiation id: %s", id)
 
             except Exception as e:
-                logger.error("Error unpacking negotiation data: %s", e)
+                self.logger.error("Error unpacking negotiation data: %s", e)
                 retries += 1
                 continue
 
@@ -154,10 +153,10 @@ class RICommunicationAgent(Agent):
             break
 
         else:
-            logger.error("Failed to set up RICommunicationAgent after %d retries", max_retries)
+            self.logger.error("Failed to set up RICommunicationAgent after %d retries", max_retries)
             return
 
         # Set up ping behaviour
         listen_behaviour = self.ListenBehaviour()
         self.add_behaviour(listen_behaviour)
-        logger.info("Finished setting up %s", self.jid)
+        self.logger.info("Finished setting up %s", self.jid)