From f73f5106086e39a5ae686340c9f1e52d21e7da4c Mon Sep 17 00:00:00 2001
From: Twirre Meulenbelt <43213592+TwirreM@users.noreply.github.com>
Date: Tue, 28 Oct 2025 18:13:00 +0100
Subject: [PATCH] fix: make VAD unit tests work with minimal dependencies

By mocking PyTorch and ZMQ and adding the Numpy dependency.

ref: N25B-213
---
 pyproject.toml                         |  2 ++
 test/unit/agents/test_vad_streaming.py |  3 +++
 test/unit/conftest.py                  | 10 ++++++++++
 uv.lock                                |  4 ++++
 4 files changed, 19 insertions(+)

diff --git a/pyproject.toml b/pyproject.toml
index 8299d0f..ee3ca08 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -7,6 +7,7 @@ requires-python = ">=3.13"
 dependencies = [
     "fastapi[all]>=0.115.6",
     "mlx-whisper>=0.4.3 ; sys_platform == 'darwin'",
+    "numpy>=2.3.3",
     "openai-whisper>=20250625",
     "pyaudio>=0.2.14",
     "pydantic>=2.12.0",
@@ -33,6 +34,7 @@ integration-test = [
     "soundfile>=0.13.1",
 ]
 test = [
+    "numpy>=2.3.3",
     "pytest>=8.4.2",
     "pytest-asyncio>=1.2.0",
     "pytest-cov>=7.0.0",
diff --git a/test/unit/agents/test_vad_streaming.py b/test/unit/agents/test_vad_streaming.py
index 20f20a1..9b38cd0 100644
--- a/test/unit/agents/test_vad_streaming.py
+++ b/test/unit/agents/test_vad_streaming.py
@@ -18,6 +18,9 @@ def audio_out_socket():
 
 @pytest.fixture
 def streaming(audio_in_socket, audio_out_socket):
+    import torch
+
+    torch.hub.load.return_value = (..., ...)  # Mock
     return Streaming(audio_in_socket, audio_out_socket)
 
 
diff --git a/test/unit/conftest.py b/test/unit/conftest.py
index d7c10f2..76ef272 100644
--- a/test/unit/conftest.py
+++ b/test/unit/conftest.py
@@ -33,3 +33,13 @@ def pytest_configure(config):
     mock_config_module.settings = MagicMock()
 
     sys.modules["control_backend.core.config"] = mock_config_module
+
+    # --- Mock torch and zmq for VAD ---
+    mock_torch = MagicMock()
+    mock_zmq = MagicMock()
+    mock_zmq.asyncio = mock_zmq
+
+    # In individual tests, these can be imported and the return values changed
+    sys.modules["torch"] = mock_torch
+    sys.modules["zmq"] = mock_zmq
+    sys.modules["zmq.asyncio"] = mock_zmq.asyncio
diff --git a/uv.lock b/uv.lock
index 07ec3c1..c2bb61a 100644
--- a/uv.lock
+++ b/uv.lock
@@ -1332,6 +1332,7 @@ source = { virtual = "." }
 dependencies = [
     { name = "fastapi", extra = ["all"] },
     { name = "mlx-whisper", marker = "sys_platform == 'darwin'" },
+    { name = "numpy" },
     { name = "openai-whisper" },
     { name = "pyaudio" },
     { name = "pydantic" },
@@ -1358,6 +1359,7 @@ integration-test = [
     { name = "soundfile" },
 ]
 test = [
+    { name = "numpy" },
     { name = "pytest" },
     { name = "pytest-asyncio" },
     { name = "pytest-cov" },
@@ -1368,6 +1370,7 @@ test = [
 requires-dist = [
     { name = "fastapi", extras = ["all"], specifier = ">=0.115.6" },
     { name = "mlx-whisper", marker = "sys_platform == 'darwin'", specifier = ">=0.4.3" },
+    { name = "numpy", specifier = ">=2.3.3" },
     { name = "openai-whisper", specifier = ">=20250625" },
     { name = "pyaudio", specifier = ">=0.2.14" },
     { name = "pydantic", specifier = ">=2.12.0" },
@@ -1392,6 +1395,7 @@ dev = [
 ]
 integration-test = [{ name = "soundfile", specifier = ">=0.13.1" }]
 test = [
+    { name = "numpy", specifier = ">=2.3.3" },
     { name = "pytest", specifier = ">=8.4.2" },
     { name = "pytest-asyncio", specifier = ">=1.2.0" },
     { name = "pytest-cov", specifier = ">=7.0.0" },