feat: added rule to prevent one belief being connected to both inferredBelief inputs

ref: N25B-433
This commit is contained in:
JGerla
2026-01-13 11:32:23 +01:00
parent f8f0f12128
commit 3d6e065dd5
7 changed files with 51 additions and 27 deletions

View File

@@ -7,7 +7,7 @@ import {
import {useState} from "react";
import { Toolbar } from '../components/NodeComponents.tsx';
import {type HandleRule, type RuleResult, ruleResult} from "../HandleRuleLogic.ts";
import {BeliefReduce} from "./BeliefReduce.ts";
import {BeliefGlobals, noMatchingLeftRightBelief} from "./BeliefGlobals.ts";
import {MultiConnectionHandle, SingleConnectionHandle} from "../components/RuleBasedHandle.tsx";
import {allowOnlyConnectionsFromType} from "../HandleRules.ts";
import useFlowStore from "../VisProgStores.tsx";
@@ -30,7 +30,7 @@ export type InferredBeliefNodeData = {
* and a left and right BeliefNode (can be both an inferred and a basic belief)
* in the form of their corresponding id's
*/
type InferredBelief = {
export type InferredBelief = {
left: string | undefined,
operator: boolean,
right: string | undefined,
@@ -106,12 +106,16 @@ const noBeliefCycles : HandleRule = (connection, _): RuleResult => {
* @returns {RuleResult}
*/
function checkForCycle(targetNodeId: string, currentNodeId: string) : RuleResult {
const outgoingBeliefs = getOutgoers({id: currentNodeId}, nodes, edges).filter(node => node.type === 'inferred_belief');
const outgoingBeliefs = getOutgoers({id: currentNodeId}, nodes, edges)
.filter(node => node.type === 'inferred_belief');
if (outgoingBeliefs.length === 0) return ruleResult.satisfied;
if (outgoingBeliefs.some(node => node.id === targetNodeId)) return ruleResult
.notSatisfied(defaultErrorMessage);
const next = outgoingBeliefs.map(node => checkForCycle(targetNodeId, node.id)).find(result => !result.isSatisfied);
const next = outgoingBeliefs.map(node => checkForCycle(targetNodeId, node.id))
.find(result => !result.isSatisfied);
return next
? next
: ruleResult.satisfied;
@@ -123,6 +127,7 @@ const noBeliefCycles : HandleRule = (connection, _): RuleResult => {
}
/**
* Defines how an InferredBelief node should be rendered
* @param {NodeProps<InferredBeliefNode>} props - Node properties provided by React Flow, including `id` and `data`.
@@ -169,17 +174,20 @@ export default function InferredBeliefNode(props: NodeProps<InferredBeliefNode>)
{/* outgoing connections */}
<MultiConnectionHandle type="source" position={Position.Right} id="source" rules={[
allowOnlyConnectionsFromType(["norm", "trigger"]),
noBeliefCycles
noBeliefCycles,
noMatchingLeftRightBelief
]}/>
{/* incoming connections */}
<SingleConnectionHandle type="target" position={Position.Left} style={{top: '30%'}} id="beliefLeft" rules={[
allowOnlyConnectionsFromType(["basic_belief", "inferred_belief"]),
noBeliefCycles
noBeliefCycles,
noMatchingLeftRightBelief
]}/>
<SingleConnectionHandle type="target" position={Position.Left} style={{top: '70%'}} id="beliefRight" rules={[
allowOnlyConnectionsFromType(["basic_belief", "inferred_belief"]),
noBeliefCycles
noBeliefCycles,
noMatchingLeftRightBelief
]}/>
</div>
</>
@@ -202,9 +210,9 @@ export function InferredBeliefReduce(node: Node, nodes: Node[]) {
const result: Record<string, unknown> = {
id: node.id,
left: BeliefReduce(leftBelief, nodes),
left: BeliefGlobals(leftBelief, nodes),
operator: data.inferredBelief.operator ? "AND" : "OR",
right: BeliefReduce(rightBelief, nodes),
right: BeliefGlobals(rightBelief, nodes),
};
return result