From 618bbd3356913740c2d6a01b0cd6b5809d81c387 Mon Sep 17 00:00:00 2001 From: Twirre Meulenbelt <43213592+TwirreM@users.noreply.github.com> Date: Tue, 27 Jan 2026 17:44:02 +0100 Subject: [PATCH] chore: fix tests after changing allowed emotions --- .../nodes/BeliefNode.test.tsx | 26 +++++++++---------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/test/pages/visProgPage/visualProgrammingUI/nodes/BeliefNode.test.tsx b/test/pages/visProgPage/visualProgrammingUI/nodes/BeliefNode.test.tsx index a023769..67d80c6 100644 --- a/test/pages/visProgPage/visualProgrammingUI/nodes/BeliefNode.test.tsx +++ b/test/pages/visProgPage/visualProgrammingUI/nodes/BeliefNode.test.tsx @@ -2,7 +2,7 @@ import { describe, it, beforeEach } from '@jest/globals'; import { screen, waitFor } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; -import { renderWithProviders } from '../.././/./../../test-utils/test-utils'; +import { renderWithProviders } from '../../../../test-utils/test-utils.tsx'; import BasicBeliefNode, { type BasicBeliefNodeData } from '../../../../../src/pages/VisProgPage/visualProgrammingUI/nodes/BasicBeliefNode.tsx'; import useFlowStore from '../../../../../src/pages/VisProgPage/visualProgrammingUI/VisProgStores'; import type { Node } from '@xyflow/react'; @@ -150,7 +150,7 @@ describe('BasicBeliefNode', () => { expect(screen.getByDisplayValue('Emotion recognised:')).toBeInTheDocument(); // For emotion type, we should check that the select has the correct value selected - const selectElement = screen.getByDisplayValue('Happy'); + const selectElement = screen.getByDisplayValue('happy'); expect(selectElement).toBeInTheDocument(); expect((selectElement as HTMLSelectElement).value).toBe('happy'); }); @@ -185,14 +185,14 @@ describe('BasicBeliefNode', () => { /> ); - const selectElement = screen.getByDisplayValue('Happy'); + const selectElement = screen.getByDisplayValue('happy'); expect(selectElement).toBeInTheDocument(); // Check that all emotion options are present - expect(screen.getByText('Happy')).toBeInTheDocument(); - expect(screen.getByText('Angry')).toBeInTheDocument(); - expect(screen.getByText('Sad')).toBeInTheDocument(); - expect(screen.getByText('Cheerful')).toBeInTheDocument(); + expect(screen.getByText('happy')).toBeInTheDocument(); + expect(screen.getByText('angry')).toBeInTheDocument(); + expect(screen.getByText('sad')).toBeInTheDocument(); + expect(screen.getByText('surprise')).toBeInTheDocument(); }); it('should render without wrapping quotes for object type', () => { @@ -382,7 +382,7 @@ describe('BasicBeliefNode', () => { data: { label: 'Belief', droppable: true, - belief: { type: 'emotion', id: 'em1', value: 'happy', label: 'Emotion recognised:' }, + belief: { type: 'emotion', id: 'em1', value: 'sad', label: 'Emotion recognised:' }, hasReduce: true, }, }; @@ -409,13 +409,13 @@ describe('BasicBeliefNode', () => { /> ); - const select = screen.getByDisplayValue('Happy'); - await user.selectOptions(select, 'sad'); + const select = screen.getByDisplayValue('sad'); + await user.selectOptions(select, 'happy'); await waitFor(() => { const state = useFlowStore.getState(); const updatedNode = state.nodes.find(n => n.id === 'belief-1') as Node; - expect(updatedNode?.data.belief.value).toBe('sad'); + expect(updatedNode?.data.belief.value).toBe('happy'); }); }); @@ -511,13 +511,11 @@ describe('BasicBeliefNode', () => { expect(updatedNode?.data.belief.type).toBe('emotion'); // The component doesn't reset the value when changing types // So it keeps the old value even though it doesn't make sense for emotion type - expect(updatedNode?.data.belief.value).toBe('Happy'); + expect(updatedNode?.data.belief.value).toBe('sad'); }); }); }); - // ... rest of the tests remain the same, just fixing the Integration with Store section ... - describe('Integration with Store', () => { it('should properly update the store when changing belief value', async () => { const mockNode: Node = {