From 757435e9f83e7511f17a4544a6e168d9a6029b41 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Otgaar?= <b.r.c.otgaar@students.uu.nl>
Date: Mon, 15 Dec 2025 12:09:53 +0100
Subject: [PATCH] fix: fix the tests and creation of nodes.

ref: N25B-408
---
 .../visualProgrammingUI/VisProgStores.tsx     | 22 ++++++++++---------
 .../nodes/UniversalNodes.test.tsx             | 16 ++++++++------
 2 files changed, 21 insertions(+), 17 deletions(-)

diff --git a/src/pages/VisProgPage/visualProgrammingUI/VisProgStores.tsx b/src/pages/VisProgPage/visualProgrammingUI/VisProgStores.tsx
index 5154a8e..3952e72 100644
--- a/src/pages/VisProgPage/visualProgrammingUI/VisProgStores.tsx
+++ b/src/pages/VisProgPage/visualProgrammingUI/VisProgStores.tsx
@@ -23,17 +23,19 @@ import { UndoRedo } from "./EditorUndoRedo.ts";
  * @param deletable - Optional flag to indicate if the node can be deleted (can be deleted by default).
  * @returns A fully initialized Node object ready to be added to the flow.
  */
-function createNode(id: string, type: string, position: XYPosition, data: Record<string, unknown>, deletable? : boolean) {
-  const defaultData = NodeDefaults[type as keyof typeof NodeDefaults]
-  const newData = {
-      id: id,
-      type: type,
-      position: position,
-      data: data,
-      deletable: deletable,
+function createNode(id: string, type: string, position: XYPosition, data: Record<string, unknown>, deletable?: boolean) {
+    const defaultData = NodeDefaults[type as keyof typeof NodeDefaults]
+    return {
+      id,
+      type,
+      position,
+      deletable,
+      data: {
+        ...defaultData,
+        ...data,
+      },
+    }
   }
-  return {...defaultData, ...newData}
-}
 
 //* Initial nodes, created by using createNode. */
 const initialNodes : Node[] = [
diff --git a/test/pages/visProgPage/visualProgrammingUI/nodes/UniversalNodes.test.tsx b/test/pages/visProgPage/visualProgrammingUI/nodes/UniversalNodes.test.tsx
index 7fb0709..ba19230 100644
--- a/test/pages/visProgPage/visualProgrammingUI/nodes/UniversalNodes.test.tsx
+++ b/test/pages/visProgPage/visualProgrammingUI/nodes/UniversalNodes.test.tsx
@@ -15,14 +15,16 @@ describe('NormNode', () => {
 
   function createNode(id: string, type: string, position: XYPosition, data: Record<string, unknown>, deletable?: boolean) {
     const defaultData = NodeDefaults[type as keyof typeof NodeDefaults]
-    const newData = {
-        id: id,
-        type: type,
-        position: position,
-        data: data,
-        deletable: deletable,
+    return {
+      id,
+      type,
+      position,
+      deletable,
+      data: {
+        ...defaultData,
+        ...data,
+      },
     }
-    return {...defaultData, ...newData}
   }