fix: added a missing test, corrected the imports, added behavior for disconnected goals as last step

ref: N25B-434

test/pages/visProgPage/visualProgrammingUI/components/PlanEditor.test.tsx

@@ -1,11 +1,15 @@
-// PlanEditorDialog.test.tsx
 import { describe, it, beforeEach, jest } from '@jest/globals';
 import { screen, within } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
+import type { Node } from '@xyflow/react';
 import { renderWithProviders } from '../../../../test-utils/test-utils.tsx';
 import PlanEditorDialog from '../../../../../src/pages/VisProgPage/visualProgrammingUI/components/PlanEditor';
 import { PlanReduce, type Plan } from '../../../../../src/pages/VisProgPage/visualProgrammingUI/components/Plan';
 import '@testing-library/jest-dom';
+import { GoalReduce, type GoalNodeData } from '../../../../../src/pages/VisProgPage/visualProgrammingUI/nodes/GoalNode.tsx';
+import { GoalNodeDefaults } from '../../../../../src/pages/VisProgPage/visualProgrammingUI/nodes/GoalNode.default.ts';
+import { insertGoalInPlan } from '../../../../../src/pages/VisProgPage/visualProgrammingUI/components/PlanEditingFunctions.tsx';
+
 
 // Mock structuredClone
 (globalThis as any).structuredClone = jest.fn((val) => JSON.parse(JSON.stringify(val)));
@@ -468,38 +472,50 @@ describe('PlanEditorDialog', () => {
 
   describe('Plan reducing', () => {
     it('should correctly reduce the plan given the elements of the plan', () => {
-        const testplan = extendedPlan
-        const expectedResult = {
-          id: "extended-plan-1",
-          steps: [
-            {
-              id: "firststep",
-              gesture: {
-                type: "tag",
-                name: "hello"
-              }
-            },
-            {
-              id: "secondstep",
-              gesture: {
-                type: "single",
-                name: "somefolder/somegesture"
-              }
-            },
-            {
-              id: "thirdstep",
-              goal: "ask the user something or whatever"
-            },
-            {
-              id: "fourthstep",
-              text: "I'm a cyborg ninja :>"
+      // Create a plan for testing
+      const testplan = extendedPlan
+      const mockGoalNode: Node<GoalNodeData> = {
+            id: 'goal-1',
+            type: 'goal',
+            position: { x: 0, y: 0 },
+            data: { ...JSON.parse(JSON.stringify(GoalNodeDefaults)), name: 'mock goal', plan: defaultPlan },
+          };
+
+      // Insert the goal and retrieve its expected data
+      const newTestPlan = insertGoalInPlan(testplan, mockGoalNode)
+      const goalReduced = GoalReduce(mockGoalNode, [mockGoalNode])
+      const expectedResult = {
+        id: "extended-plan-1",
+        steps: [
+          {
+            id: "firststep",
+            gesture: {
+              type: "tag",
+              name: "hello"
             }
-          ]
-        }
-
-        const actualResult = PlanReduce([], testplan) // TODO: FIX THIS TEST :)))
-
-        expect(actualResult).toEqual(expectedResult)
+          },
+          {
+            id: "secondstep",
+            gesture: {
+              type: "single",
+              name: "somefolder/somegesture"
+            }
+          },
+          {
+            id: "thirdstep",
+            goal: "ask the user something or whatever"
+          },
+          {
+            id: "fourthstep",
+            text: "I'm a cyborg ninja :>"
+          },
+            goalReduced,
+        ]
+      }
+      
+      // Check to see it the goal got added, and its reduced data was added to the goals'
+      const actualResult = PlanReduce([mockGoalNode], newTestPlan) 
+      expect(actualResult).toEqual(expectedResult)
     });
   })
 });