pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Automated commit detection #20

Merged
k.marinus merged 6 commits from fix/skip-checking-auto-commits into dev 2025-11-03 14:35:41 +00:00
Conversation 37 Commits 6 Files Changed 2 +56 -14
k.marinus commented 2025-11-02 21:13:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link

When detecting an automated commit (merge, squash, revert, cherry-pick), we skip validation of the commit.

To test, make sure the following commit types are accepted:

  • Merge commits
  • Squash commits
  • Revert commits
  • Cherry-pick commits

Also make sure that, for normal commits, the commit message still gets checked correctly:

  • Normal commits still get failed when not following correct format
  • Normal commits still get accepted when following correct format

ref: N25B-241

When detecting an automated commit (merge, squash, revert, cherry-pick), we skip validation of the commit. To test, make sure the following commit types are accepted: * [x] Merge commits * [x] Squash commits * [x] Revert commits * [x] Cherry-pick commits Also make sure that, for normal commits, the commit message still gets checked correctly: * [x] Normal commits still get failed when not following correct format * [x] Normal commits still get accepted when following correct format ref: N25B-241
9828273 commented 2025-11-03 12:50:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @9828273

requested review from @9828273
k.marinus commented 2025-11-03 12:56:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
k.marinus commented 2025-11-03 12:57:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
k.marinus commented 2025-11-03 12:57:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
9828273 commented 2025-11-03 13:01:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Merge commits as completed

marked the checklist item **Merge commits** as completed
9828273 commented 2025-11-03 13:01:31 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get failed when not following correct format as completed

marked the checklist item **Normal commits still get failed when not following correct format** as completed
9828273 commented 2025-11-03 13:01:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get accepted when following correct format as completed

marked the checklist item **Normal commits still get accepted when following correct format** as completed
9828273 commented 2025-11-03 13:03:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 2 commits

  • 63ae5d76 - fix: test message
  • 3558a586 - chore: Correct test message!

Compare with previous version

added 2 commits <ul><li>63ae5d76 - fix: test message</li><li>3558a586 - chore: Correct test message!</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133223&start_sha=020bf55772f8b8a482c62151b39de537d908c841)
9828273 commented 2025-11-03 13:04:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Cherry-pick commits as completed

marked the checklist item **Cherry-pick commits** as completed
9828273 commented 2025-11-03 13:10:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Squash commits as completed

marked the checklist item **Squash commits** as completed
9828273 commented 2025-11-03 13:10:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Revert commits as completed

marked the checklist item **Revert commits** as completed
9828273 commented 2025-11-03 13:11:48 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • a33b67d6 - fix: test message

Compare with previous version

added 1 commit <ul><li>a33b67d6 - fix: test message</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133225&start_sha=3558a586555ac5637034eb6ed5c9db3f87a69253)
9828273 commented 2025-11-03 13:12:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get accepted when following correct format as incomplete

marked the checklist item **Normal commits still get accepted when following correct format** as incomplete
9828273 commented 2025-11-03 13:12:35 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get accepted when following correct format as completed

marked the checklist item **Normal commits still get accepted when following correct format** as completed
9828273 commented 2025-11-03 13:12:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get failed when not following correct format as incomplete

marked the checklist item **Normal commits still get failed when not following correct format** as incomplete
9828273 commented 2025-11-03 13:13:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 5fc370ba - chore: Correct test message!

Compare with previous version

added 1 commit <ul><li>5fc370ba - chore: Correct test message!</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133226&start_sha=a33b67d65984f7757f7854b85e8ac009b30d3915)
9828273 commented 2025-11-03 13:14:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 5c46b3c5 - Squashed commit of the following:

Compare with previous version

added 1 commit <ul><li>5c46b3c5 - Squashed commit of the following:</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133228&start_sha=5fc370bafda6f86932d391f034806aa15f04936e)
9828273 commented 2025-11-03 13:14:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 226abc09 - Revert "Squashed commit of the following:"

Compare with previous version

added 1 commit <ul><li>226abc09 - Revert &quot;Squashed commit of the following:&quot;</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133228&start_sha=5c46b3c5bb2f91552f1bce0bb650629002bcfd17)
9828273 commented 2025-11-03 13:30:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 7 commits

  • f7f82974 - chore: test
  • bd10520e - chore: womp womp
  • 5bfea668 - bad message!
  • 570a2207 - fix: bad message!
  • 0cbb3def - bad message!
  • d2d626ca - fix: bad message!
  • f33b4943 - Revert "chore: test"

Compare with previous version

added 7 commits <ul><li>f7f82974 - chore: test</li><li>bd10520e - chore: womp womp</li><li>5bfea668 - bad message!</li><li>570a2207 - fix: bad message!</li><li>0cbb3def - bad message!</li><li>d2d626ca - fix: bad message!</li><li>f33b4943 - Revert &quot;chore: test&quot;</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133231&start_sha=226abc092845ef3e7d74ab9a24fa0d72b0f1dcb8)
k.marinus commented 2025-11-03 13:51:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 0d5e198c - fix: pattern matching instead of file existence

Compare with previous version

added 1 commit <ul><li>0d5e198c - fix: pattern matching instead of file existence</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133232&start_sha=f33b4943c568f0aae099266cd20be12e1b3028ad)
k.marinus commented 2025-11-03 14:00:35 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 2 commits

  • 3c8cee54 - fix: pattern matching instead of file existence
  • e53792b6 - Merge branch 'fix/skip-checking-auto-commits' of...

Compare with previous version

added 2 commits <ul><li>3c8cee54 - fix: pattern matching instead of file existence</li><li>e53792b6 - Merge branch &#39;fix/skip-checking-auto-commits&#39; of...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133233&start_sha=0d5e198cad506d495093785d267599b223269a16)
9828273 commented 2025-11-03 14:09:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get accepted when following correct format as incomplete

marked the checklist item **Normal commits still get accepted when following correct format** as incomplete
9828273 commented 2025-11-03 14:09:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Cherry-pick commits as incomplete

marked the checklist item **Cherry-pick commits** as incomplete
9828273 commented 2025-11-03 14:09:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Revert commits as incomplete

marked the checklist item **Revert commits** as incomplete
9828273 commented 2025-11-03 14:09:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Squash commits as incomplete

marked the checklist item **Squash commits** as incomplete
9828273 commented 2025-11-03 14:09:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Merge commits as incomplete

marked the checklist item **Merge commits** as incomplete
9828273 commented 2025-11-03 14:13:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get failed when not following correct format as completed

marked the checklist item **Normal commits still get failed when not following correct format** as completed
9828273 commented 2025-11-03 14:13:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Normal commits still get accepted when following correct format as completed

marked the checklist item **Normal commits still get accepted when following correct format** as completed
9828273 commented 2025-11-03 14:17:58 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Merge commits as completed

marked the checklist item **Merge commits** as completed
9828273 commented 2025-11-03 14:18:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Revert commits as completed

marked the checklist item **Revert commits** as completed
k.marinus commented 2025-11-03 14:23:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>360f601d - feat: chore doesn&#39;t need ref</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133235&start_sha=e53792b67c05fabb96f2b7c521230f3affdd30e8)
9828273 commented 2025-11-03 14:27:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Cherry-pick commits as completed

marked the checklist item **Cherry-pick commits** as completed
9828273 commented 2025-11-03 14:27:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Squash commits as completed

marked the checklist item **Squash commits** as completed
9828273 commented 2025-11-03 14:27:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Squash commits as incomplete

marked the checklist item **Squash commits** as incomplete
k.marinus commented 2025-11-03 14:29:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • cb5457b6 - feat: check for squash commits

Compare with previous version

added 1 commit <ul><li>cb5457b6 - feat: check for squash commits</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/20/diffs?diff_id=133237&start_sha=360f601d007041324aa36a727da598d52b6ce68a)
9828273 commented 2025-11-03 14:34:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Squash commits as completed

marked the checklist item **Squash commits** as completed
9828273 commented 2025-11-03 14:35:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit da30c392aa

mentioned in commit da30c392aaeff31b7977beaba05ab0a5ac564d4d
9828273 (Migrated from git.science.uu.nl) merged commit da30c392aa into dev 2025-11-03 14:35:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#20
Delete Branch "fix/skip-checking-auto-commits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?