pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Refactoring agent and behaviour naming and structure. #25

Merged
9828273 merged 9 commits from refactor/agent-naming into dev 2025-11-19 15:37:14 +00:00
Conversation 33 Commits 9 Files Changed 37 +355 -376
9828273 commented 2025-11-12 12:14:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

We should refactor our current names for both agents and behaviours. Alongside this, we should use a new folder structure to accommodate this change.

In order to complete this merge, follow steps and mark the checklist:

  1. Switch to the refactor/agent-naming on CB.
  2. Switch to dev branches on RI/UI.
  3. Make sure you have the correct certificates set up. IMPORTANT, this change also had impact on the certificates. You probably have to do sudo prosodyctl adduser {name}@localhost with password {name} FOR ABOUT ALMOST ALL AGENTS IN core/config.py, yes, I'm sorry.
  4. Check the naming guidelines for the agents in KB.
  5. Follow the checklist and see if everything is working:
  • merge dev shows this branch is up to date with dev, make sure dev is fetched and pulled for newest version. (Which is currently the case, but probably needs to be updated when other requests get merged 🫡)
  • ruff check and ruff format show no errors or changes (there should be one line which is too long, but is not able to be reduced and commented to not be checked).
  • uv run --group integration-test pytest test/integration and uv run --only-group test pytest test/unit show all tests pass.
  • running ri, cb and ui shows all components work as intended.
  • ALL agents are started successfully.
  • ALL agents follow the naming guidelines and are categorized correctly.
  • ALL agents are ordered in the correct folders for both src/ and test/.
  • ALL behaviours are named correctly.
  • The __init__ files are present in all the agents/domains, and are set up correctly.

Additional comments:
In case you need a short version of how naming should be:
<Techincal Domain><Role>Agent is standard.
Behaviours should reflect the agents name ONLY when they aren't 'supposed' to have more behaviours.
Behaviours should end on behaviour.
Normal Class/File naming guidlines apply: Class: ComRIAgent <-> File: com_ri_agent.

ref: N25B-207

We should refactor our current names for both agents and behaviours. Alongside this, we should use a new folder structure to accommodate this change. In order to complete this merge, follow steps and mark the checklist: 1. Switch to the refactor/agent-naming on CB. 2. Switch to dev branches on RI/UI. 3. Make sure you have the correct certificates set up. IMPORTANT, this change also had impact on the certificates. You probably have to do `sudo prosodyctl adduser {name}@localhost` with password {name} FOR ABOUT ALMOST ALL AGENTS IN `core/config.py`, yes, I'm sorry. 4. Check the naming guidelines for the agents in KB. 5. Follow the checklist and see if everything is working: - [x] `merge dev` shows this branch is up to date with dev, make sure dev is fetched and pulled for newest version. (Which is currently the case, but probably needs to be updated when other requests get merged :saluting_face:) - [x] `ruff check` and `ruff format` show no errors or changes (there should be one line which is too long, but is not able to be reduced and commented to not be checked). - [x] `uv run --group integration-test pytest test/integration` and `uv run --only-group test pytest test/unit` show all tests pass. - [x] running ri, cb and ui shows all components work as intended. - [x] ALL agents are started successfully. - [x] ALL agents follow the naming guidelines and are categorized correctly. - [x] ALL agents are ordered in the correct folders for both src/ and test/. - [x] ALL behaviours are named correctly. - [x] The `__init__` files are present in all the agents/domains, and are set up correctly. Additional comments: In case you need a short version of how naming should be: `<Techincal Domain><Role>Agent` is standard. Behaviours should reflect the agents name ONLY when they aren't 'supposed' to have more behaviours. Behaviours should end on `behaviour`. Normal Class/File naming guidlines apply: Class: `ComRIAgent` <-> File: `com_ri_agent`. ref: N25B-207
9828273 commented 2025-11-12 12:14:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @9828273

assigned to @9828273
9828273 commented 2025-11-12 12:15:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
0950726 commented 2025-11-18 09:51:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Should be merged to dev branch instead of main

Should be merged to `dev` branch instead of `main`
0950726 commented 2025-11-18 10:03:53 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Couldn't figure out what "Per" stood for until I asked. _Per_haps just expand it fully to "Perception".

Same thing for "Com" I guess.

Autocomplete will save us from having to type it out fully.

And then I think the directory should be explanatory enough to understand "VADAgent" or "TranscriptionAgent" means so that we don't have to call them "PerceptionVADAgent" or "PerceptionTranscriptionAgent".

Couldn't figure out what "Per" stood for until I asked. _Per_haps just expand it fully to "Perception". Same thing for "Com" I guess. Autocomplete will save us from having to type it out fully. And then I think the directory should be explanatory enough to understand "VADAgent" or "TranscriptionAgent" means so that we don't have to call them "PerceptionVADAgent" or "PerceptionTranscriptionAgent".
9828273 (Migrated from git.science.uu.nl) changed target branch from main to dev 2025-11-18 10:09:03 +00:00
2584433 commented 2025-11-18 18:19:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @2584433

requested review from @2584433
9828273 commented 2025-11-18 18:32:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 21 commits

  • 9152985b...df1e891a - 20 commits from branch dev
  • f4dbca5b - Merge branch 'dev' into refactor/agent-naming

Compare with previous version

added 21 commits <ul><li>9152985b...df1e891a - 20 commits from branch <code>dev</code></li><li>f4dbca5b - Merge branch &#39;dev&#39; into refactor/agent-naming</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/25/diffs?diff_id=133757&start_sha=9152985bdb7e8742eecc91e584b7e94643e17373)
2584433 commented 2025-11-18 19:00:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item merge dev shows this branch is up to date with dev, make sure dev is fetched and pulled for newest version. (Which is currently the case, but probably needs to be updated when other requests get merged 🫡) as completed

marked the checklist item **`merge dev` shows this branch is up to date with dev, make sure dev is fetched and pulled for newest version. (Which is currently the case, but probably needs to be updated when other requests get merged :saluting_face:)** as completed
2584433 commented 2025-11-18 19:04:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ruff check and ruff format show no errors or changes (there should be one line which is too long, but is not able to be reduced and commented to not be checked). as completed

marked the checklist item **`ruff check` and `ruff format` show no errors or changes (there should be one line which is too long, but is not able to be reduced and commented to not be checked).** as completed
2584433 commented 2025-11-18 19:05:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item uv run --group integration-test pytest test/integration and uv run --only-group test pytest test/unit show all tests pass. as completed

marked the checklist item **`uv run --group integration-test pytest test/integration` and `uv run --only-group test pytest test/unit` show all tests pass.** as completed
2584433 commented 2025-11-19 11:32:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item running ri, cb and ui shows all components work as intended. as completed

marked the checklist item **running ri, cb and ui shows all components work as intended.** as completed
2584433 commented 2025-11-19 11:32:35 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL agents are started successfully. as completed

marked the checklist item **ALL agents are started successfully.** as completed
2584433 commented 2025-11-19 11:32:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL agents follow the naming guidelines and are categorized correctly. as completed

marked the checklist item **ALL agents follow the naming guidelines and are categorized correctly.** as completed
2584433 commented 2025-11-19 11:32:43 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL agents are ordered in the correct folders for both src/ and test/. as completed

marked the checklist item **ALL agents are ordered in the correct folders for both src/ and test/.** as completed
2584433 commented 2025-11-19 11:32:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL behaviours are named correctly. as completed

marked the checklist item **ALL behaviours are named correctly.** as completed
0950726 commented 2025-11-19 11:37:39 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I have changed the naming standards in the knowledge base to increase understandability and to reduce repetition.

I have changed the naming standards in the knowledge base to increase understandability and to reduce repetition.
2584433 commented 2025-11-19 11:58:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL agents follow the naming guidelines and are categorized correctly. as incomplete

marked the checklist item **ALL agents follow the naming guidelines and are categorized correctly.** as incomplete
2584433 commented 2025-11-19 11:58:57 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL behaviours are named correctly. as incomplete

marked the checklist item **ALL behaviours are named correctly.** as incomplete
2584433 commented 2025-11-19 12:11:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The __init__ files are present in all the agents/domains, and are set up correctly. as completed

marked the checklist item **The `__init__` files are present in all the agents/domains, and are set up correctly.** as completed
0950726 commented 2025-11-19 12:20:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I'll handle the new names.

I'll handle the new names.
0950726 commented 2025-11-19 12:20:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested changes

requested changes
2584433 commented 2025-11-19 12:26:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The __init__ files are present in all the agents/domains, and are set up correctly. as incomplete

marked the checklist item **The `__init__` files are present in all the agents/domains, and are set up correctly.** as incomplete
9828273 commented 2025-11-19 12:42:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Thanks!:)

Thanks!:)
0950726 commented 2025-11-19 14:56:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • efe49c21 - feat: apply new agent naming standards

Compare with previous version

added 1 commit <ul><li>efe49c21 - feat: apply new agent naming standards</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/25/diffs?diff_id=133825&start_sha=f4dbca5b94113ebca86575bc43a810284d43e060)
0950726 commented 2025-11-19 15:00:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 7 commits

  • efe49c21...4fc3c2a1 - 6 commits from branch dev
  • 6c401a18 - Merge remote-tracking branch 'origin/dev' into refactor/agent-naming

Compare with previous version

added 7 commits <ul><li>efe49c21...4fc3c2a1 - 6 commits from branch <code>dev</code></li><li>6c401a18 - Merge remote-tracking branch &#39;origin/dev&#39; into refactor/agent-naming</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/25/diffs?diff_id=133826&start_sha=efe49c219cb7ae2ba75095bc68a42b6e191dccb9)
2584433 commented 2025-11-19 15:11:02 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL agents follow the naming guidelines and are categorized correctly. as completed

marked the checklist item **ALL agents follow the naming guidelines and are categorized correctly.** as completed
2584433 commented 2025-11-19 15:11:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item ALL behaviours are named correctly. as completed

marked the checklist item **ALL behaviours are named correctly.** as completed
2584433 commented 2025-11-19 15:11:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The __init__ files are present in all the agents/domains, and are set up correctly. as completed

marked the checklist item **The `__init__` files are present in all the agents/domains, and are set up correctly.** as completed
0950726 commented 2025-11-19 15:29:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 5f3d290f - fix: use the correct name in the transcription agent

Compare with previous version

added 1 commit <ul><li>5f3d290f - fix: use the correct name in the transcription agent</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/25/diffs?diff_id=133843&start_sha=6c401a18b403a8d713bcafc81101c261c0a6bebc)
2584433 commented 2025-11-19 15:30:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
2584433 commented 2025-11-19 15:30:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @0950726 and removed review request for @2584433

requested review from @0950726 and removed review request for @2584433
0950726 commented 2025-11-19 15:35:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
0950726 commented 2025-11-19 15:37:15 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 9963134262

mentioned in commit 99631342622ba6863bbac679fa8dce3a4c66e1b4
0950726 (Migrated from git.science.uu.nl) merged commit 9963134262 into dev 2025-11-19 15:37:15 +00:00
2584433 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
2584433
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#25
Delete Branch "refactor/agent-naming"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?