pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add program manager #30

Merged
0950726 merged 8 commits from feat/norms-and-goals-program into dev 2025-11-25 11:20:51 +00:00
Conversation 17 Commits 8 Files Changed 17 +313 -131
0950726 commented 2025-11-25 10:36:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Add a program manager which handles programs received from the UI, sends norms and goals to the BDI.

To test:

  • Style checks pass
  • Unit & integration tests pass
  • Code makes sense

ref: N25B-299

Add a program manager which handles programs received from the UI, sends norms and goals to the BDI. To test: - [x] Style checks pass - [x] Unit & integration tests pass - [x] Code makes sense ref: N25B-299
k.marinus commented 2025-11-25 10:36:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @k.marinus

requested review from @k.marinus
k.marinus commented 2025-11-25 10:51:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link
                self.logger.exception("Received an invalid program.")
```suggestion:-0+0 self.logger.exception("Received an invalid program.") ```
k.marinus commented 2025-11-25 10:51:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link
    def __init__(self, norms: list[str] | None = None, goals: list[str] | None = None):
```suggestion:-0+0 def __init__(self, norms: list[str] | None = None, goals: list[str] | None = None): ```
k.marinus commented 2025-11-25 10:51:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
0950726 commented 2025-11-25 10:52:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
0950726 commented 2025-11-25 10:53:28 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/30/diffs?diff_id=134342&start_sha=11b5345ae7314bea786f4c3d1b8625835a2e6de5#091256ee799d163c7f176b295ce1c5003a85a072_55_55)
0950726 commented 2025-11-25 10:53:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/30/diffs?diff_id=134342&start_sha=11b5345ae7314bea786f4c3d1b8625835a2e6de5#218089c6f80f45b3374c0cac7fac919bda6ecde5_20_20)
0950726 commented 2025-11-25 10:53:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • ce058c38 - fix: correct typing, simplify logs

Compare with previous version

added 1 commit <ul><li>ce058c38 - fix: correct typing, simplify logs</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/30/diffs?diff_id=134342&start_sha=11b5345ae7314bea786f4c3d1b8625835a2e6de5)
2584433 commented 2025-11-25 11:04:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Style checks pass as completed

marked the checklist item **Style checks pass** as completed
2584433 commented 2025-11-25 11:06:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Unit & integration tests pass as completed

marked the checklist item **Unit & integration tests pass** as completed
0950726 commented 2025-11-25 11:14:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 6be04566 - chore: remove unused variable

Compare with previous version

added 1 commit <ul><li>6be04566 - chore: remove unused variable</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/30/diffs?diff_id=134351&start_sha=ce058c3808c10bbf61c5ed0bdbf9e37f2a242388)
2584433 commented 2025-11-25 11:20:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Code makes sense as completed

marked the checklist item **Code makes sense** as completed
2584433 commented 2025-11-25 11:20:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
2584433 commented 2025-11-25 11:20:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
2584433 commented 2025-11-25 11:20:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 6dc59d0093

mentioned in commit 6dc59d009379d01375a512ef0e0e7cdd02d25782
2584433 (Migrated from git.science.uu.nl) merged commit 6dc59d0093 into dev 2025-11-25 11:20:52 +00:00
k.marinus (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:06 +00:00
2584433 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
k.marinus
2584433
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#30
Delete Branch "feat/norms-and-goals-program"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?