pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Move VAD agent creation to RI communication agent #34

Merged
0950726 merged 2 commits from fix/correct-vad-starting into dev 2025-12-09 14:57:10 +00:00
Conversation 14 Commits 2 Files Changed 6 +125 -27
0950726 commented 2025-12-03 14:18:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Previously, the VAD was started in main, but it should use values negotiated by the RI communication agent.

To verify:

  • Style checks pass
  • Pipeline (tests) pass
  • Documentation is up to date
  • Tests are up to date (new code is covered)
  • VAD still works
  • You agree with the ProgramStatus feature I implemented
    • It is a value that's updated in the lifetime in main
    • It updates agents about the program status
    • The VAD agent needs this because otherwise it starts listening before the program finishes starting, causing unexpectedly many transcriptions if you're speaking during startup
    • It can be left out, just letting the VAD agent listen from the start, doesn't really matter

ref: N25B-356

Previously, the VAD was started in main, but it should use values negotiated by the RI communication agent. To verify: - [x] Style checks pass - [x] Pipeline (tests) pass - [x] Documentation is up to date - [x] Tests are up to date (new code is covered) - [x] VAD still works - [x] You agree with the `ProgramStatus` feature I implemented - It is a value that's updated in the `lifetime` in main - It updates agents about the program status - The VAD agent needs this because otherwise it starts listening before the program finishes starting, causing unexpectedly many transcriptions if you're speaking during startup - It can be left out, just letting the VAD agent listen from the start, doesn't really matter ref: N25B-356
0950726 commented 2025-12-03 14:18:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @0950726

assigned to @0950726
0950726 commented 2025-12-03 14:22:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
2584433 commented 2025-12-07 22:09:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • 21e9d05d...de2e56ff - 2 commits from branch dev
  • a3cf389c - Merge branch 'dev' of https://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-cb...

Compare with previous version

added 3 commits <ul><li>21e9d05d...de2e56ff - 2 commits from branch <code>dev</code></li><li>a3cf389c - Merge branch &#39;dev&#39; of https://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-cb...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/34/diffs?diff_id=135451&start_sha=21e9d05d6efa1d47ba82fe576f96a8406192c9fe)
2584433 commented 2025-12-07 22:11:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Style checks pass as completed

marked the checklist item **Style checks pass** as completed
2584433 commented 2025-12-07 22:12:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as completed

marked the checklist item **Pipeline (tests) pass** as completed
2584433 commented 2025-12-07 22:19:43 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Tests are up to date (new code is covered) as completed

marked the checklist item **Tests are up to date (new code is covered)** as completed
2584433 commented 2025-12-07 22:24:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item You agree with the ProgramStatus feature I implemented as completed

marked the checklist item **You agree with the `ProgramStatus` feature I implemented** as completed
2584433 commented 2025-12-07 22:24:48 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Documentation is up to date as completed

marked the checklist item **Documentation is up to date** as completed
2584433 commented 2025-12-08 13:44:50 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item VAD still works as completed

marked the checklist item **VAD still works** as completed
2584433 commented 2025-12-08 13:44:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
9828273 commented 2025-12-09 14:57:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
9828273 commented 2025-12-09 14:57:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 2366255b92

mentioned in commit 2366255b92218f5f12850a8d29b5a0a35433147e
9828273 (Migrated from git.science.uu.nl) merged commit 2366255b92 into dev 2025-12-09 14:57:10 +00:00
2584433 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:05 +00:00
9828273 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
2584433
9828273
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#34
Delete Branch "fix/correct-vad-starting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?