pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: added way to communicate 10 basic gestures #41

Closed
2584433 wants to merge 6 commits from feat/10-basic-gestures into dev
pull from: feat/10-basic-gestures
merge into: pepperplus:dev
Conversation 29 Commits 6 Files Changed 7 +281 -416
2584433 commented 2025-12-29 18:28:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

ref: N25B-402

To verify:

  • Style checks pass
  • Pipeline (tests) pass
  • Documentation is up to date
  • Tests are up to date (new code is covered)
    Go to ui branch gesture uicb, and 10basic on cb and ri. changing (in the ui code) setTags(jsonRes["available_gestures"]
  • Fetching gestures works
  • Changing tags with single or basic in ui code (const res = await fetch("http://localhost:8000/robot/commands/gesture/tags/"); ) works
ref: N25B-402 To verify: - [x] Style checks pass - [x] Pipeline (tests) pass - [x] Documentation is up to date - [x] Tests are up to date (new code is covered) Go to ui branch gesture uicb, and 10basic on cb and ri. changing (in the ui code) setTags(jsonRes["**available_gestures**"] - [ ] Fetching gestures works - [ ] Changing tags with single or basic in ui code (const res = await fetch("http://localhost:8000/robot/commands/gesture/tags/"); ) works
2584433 commented 2025-12-29 18:28:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @2584433

assigned to @2584433
2584433 commented 2025-12-29 18:43:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • 3571bd61...adbb7ffd - 2 commits from branch dev
  • aa6a90f4 - Merge branch 'dev' of https://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-cb...

Compare with previous version

added 3 commits <ul><li>3571bd61...adbb7ffd - 2 commits from branch <code>dev</code></li><li>aa6a90f4 - Merge branch &#39;dev&#39; of https://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-cb...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136194&start_sha=3571bd614ff9a7f9cd80a6441020815c21e7045a)
9828273 commented 2026-01-06 09:18:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @9828273

requested review from @9828273
9828273 commented 2026-01-06 09:25:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link
                    if gesture_command.data not in self.gesture_single:
```suggestion:-0+0 if gesture_command.data not in self.gesture_single: ```
9828273 commented 2026-01-06 09:25:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link
    agent.gesture_single = ["hello", "yes", "no"]  # ← REQUIRED for legacy check
```suggestion:-0+0 agent.gesture_single = ["hello", "yes", "no"] # ← REQUIRED for legacy check ```
9828273 commented 2026-01-06 09:25:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link
        allowed = {RIEndpoint.GESTURE_SINGLE, RIEndpoint.GESTURE_TAG}
# Add allowed endpoint if changed to different name
```suggestion:-0+0 allowed = {RIEndpoint.GESTURE_SINGLE, RIEndpoint.GESTURE_TAG} # Add allowed endpoint if changed to different name ```
9828273 commented 2026-01-06 09:25:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link
        RIEndpoint.GESTURE_SINGLE, RIEndpoint.GESTURE_TAG
# Add new endpoint if changed to different name
```suggestion:-0+0 RIEndpoint.GESTURE_SINGLE, RIEndpoint.GESTURE_TAG # Add new endpoint if changed to different name ```
9828273 commented 2026-01-06 09:25:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
9828273 commented 2026-01-06 09:26:15 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Should fix the pipeline and merge with dev before continuing with the rest of the threads.

Should fix the pipeline and merge with dev before continuing with the rest of the threads.
9828273 commented 2026-01-06 09:26:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Style checks pass as completed

marked the checklist item **Style checks pass** as completed
9828273 commented 2026-01-06 09:29:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Test are up to date (new code is covered) is false for the robot endpoint (endpoints.robot.py), it has a 67% coverage with only about 25% of the new lines covered.

`Test are up to date (new code is covered)` is false for the robot endpoint (endpoints.robot.py), it has a 67% coverage with only about 25% of the new lines covered.
9828273 commented 2026-01-06 09:31:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Can be done with a switch statement; not high priority though.

Can be done with a switch statement; not high priority though.
9828273 commented 2026-01-06 09:33:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Documentation is up to date as completed

marked the checklist item **Documentation is up to date** as completed
9828273 commented 2026-01-06 09:39:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Fetching gestures returns an error in the CB: raise JSONDecodeError("Expecting value", s, err.value) from None, resulting in a timeout error, so the UI doesn't get any tags.

Fetching gestures returns an error in the CB: `raise JSONDecodeError("Expecting value", s, err.value) from None`, resulting in a timeout error, so the UI doesn't get any tags.
9828273 commented 2026-01-06 09:41:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Note that a lot of these problems could come from the fact that this branch is 8 commits behind, you should probably merge and fix the global issues.

Note that a lot of these problems could come from the fact that this branch is 8 commits behind, you should probably merge and fix the global issues.
2584433 commented 2026-01-06 13:13:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136334&start_sha=aa6a90f4e124b0c8da0c3a26d43af89ffaed796c#263dfe717551994421f8b00d361780afe2d3e8a0_138_138)
2584433 commented 2026-01-06 13:13:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136334&start_sha=aa6a90f4e124b0c8da0c3a26d43af89ffaed796c#0b6e02f73604624f472021be99ebd1bdca1523f6_113_131)
2584433 commented 2026-01-06 13:13:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136334&start_sha=aa6a90f4e124b0c8da0c3a26d43af89ffaed796c#40778539245d18ad73c67ff8d636f4bd389cfcb4_61_61)
2584433 commented 2026-01-06 13:13:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136334&start_sha=aa6a90f4e124b0c8da0c3a26d43af89ffaed796c#40778539245d18ad73c67ff8d636f4bd389cfcb4_54_54)
2584433 commented 2026-01-06 13:13:21 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 9 commits

  • aa6a90f4...612a9694 - 8 commits from branch dev
  • 955b3109 - Merge branch 'dev' of https://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-cb...

Compare with previous version

added 9 commits <ul><li>aa6a90f4...612a9694 - 8 commits from branch <code>dev</code></li><li>955b3109 - Merge branch &#39;dev&#39; of https://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-cb...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136334&start_sha=aa6a90f4e124b0c8da0c3a26d43af89ffaed796c)
2584433 commented 2026-01-06 13:13:30 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a96e332d - chore: cleanup</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136335&start_sha=955b3109bcfb0f2ce9d5c06cd1e61e8c3f7ec000)
2584433 commented 2026-01-06 13:53:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 128e9b3c - chore: fixed sending stuff to ui

Compare with previous version

added 1 commit <ul><li>128e9b3c - chore: fixed sending stuff to ui</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/41/diffs?diff_id=136347&start_sha=a96e332d635bf79fa5f8322e67d9ef7270a207a0)
2584433 commented 2026-01-06 13:55:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
2584433 commented 2026-01-06 13:56:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

nah

nah
2584433 commented 2026-01-06 13:56:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2026-01-07 09:48:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as completed

marked the checklist item **Pipeline (tests) pass** as completed
9828273 commented 2026-01-07 09:48:48 +00:00 (Migrated from git.science.uu.nl)
Copy Link

image.png{width=686 height=386}

![image.png](/uploads/2520ac8384dff099d8c9b4a1f385a27c/image.png){width=686 height=386}
9828273 commented 2026-01-07 09:49:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Tests are up to date (new code is covered) as completed

marked the checklist item **Tests are up to date (new code is covered)** as completed
9828273 commented 2026-01-07 09:52:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

UI gives an Uncaught TypeError: can't access property "length", tags is undefined due to mismatching fields; change the UI branch gestures-ui-cb to account for this: setTags(jsonRes["available_gesture_tags"]); => setTags(jsonRes["available_gestures"]);, or change the CB to match the UI. :)

UI gives an `Uncaught TypeError: can't access property "length", tags is undefined` due to mismatching fields; change the UI branch `gestures-ui-cb` to account for this: `setTags(jsonRes["available_gesture_tags"]);` =\> `setTags(jsonRes["available_gestures"]);`, or change the CB to match the UI. :)
2584433 (Migrated from git.science.uu.nl) closed this pull request 2026-01-19 13:43:24 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#41
Delete Branch "feat/10-basic-gestures"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?