Experiment log stream, to console, file and UI #44
Reference in New Issue
Block a user
Delete Branch "feat/experiment-logging"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds the experiment logger / researcher friendly logger. The logger is not yet used in any agents, but I've attached a
LogTestagent to show how it can be used.Alters the
.logging_config.yamland adds a few logging utility classes to make the stream less verbose in console and file, but keep it most responsive in the UI.To verify:
LogTestagent (below) to the CB, run the CB (maybe comment out any other agents if you don't want to run the RI)/experiment_logs/experiment_<>.log)curl:curl -N http://localhost:8000/logs/streamCHATlogs appear only in full in the console and in the file, but iteratively in the HTTP streamThe LogTest agent:
ref: N25B-401
changed the description
assigned to @0950726
added 1 commit
58881b59- test: add test casesCompare with previous version
changed the description
changed the description
requested review from @8464960
marked the checklist item Shows experiment logs in the console as completed
marked the checklist item Add the LogTest agent (below) to the CB, run the CB (maybe comment out any other agents if you don't want to run the RI) as completed
marked the checklist item Saves experiment logs to a file in the CB (/experiment_logs/experiment_<>.log) as completed
marked the checklist item Style checks pass as completed
marked the checklist item Publishes an HTTP stream as completed
marked the checklist item Pipeline (tests) pass as completed
marked the checklist item CHAT logs appear only in full in the console and in the file, but iteratively in the HTTP stream as completed
marked the checklist item Tests are up to date (new code is covered) as completed
marked the checklist item Experiment log file can be downloaded at http://localhost:8000/api/logs/files/<filename> as completed
Please provide more documentation to guide any readers of the code.
marked the checklist item Documentation is up to date as completed
Only had one comment about the documentation, the rest is very well documented and well-written, good job:)
(I also tested the functionality on the UI already, with the new branch.)
approved this merge request
I tested everything and it seems to work completely as expected.
I don't have comments on the code itself apart from Björn's comment on missing documentatino.
All tests seem to pass with high coverage. (Only lines 69-75 in setup_logging ar not covered (the custom levels), but I think coverage is still high enough 88% and the rest 100%).
So, good job, looks very nice, I approve
approved this merge request
Thanks, added them now.
Yeah these lines were already not tested. There are no tests for that logging setup file at all, they're only coincidentally tested in other tests.
Think it falls out of scope for this merge request.
added 1 commit
a74ecc6c- docs: add docstrings to dated file handlerCompare with previous version
mentioned in commit
e7e305c4a3