pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

chore: add missing tests #45

Merged
8464960 merged 3 commits from chore/add-missing-tests into dev 2026-01-27 10:58:12 +00:00
Conversation 23 Commits 3 Files Changed 5 +380 -6
8464960 commented 2026-01-19 15:04:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This branch is based on !43

To verify:

  • Check if the small edits in UserInterruptAgent and Program Manager themselves make sense
  • Pipeline (tests) pass
  • See that UserInterruptAgent, Program manager and UserInteract endpoint have enough coverage now
This branch is based on !43 To verify: - [x] Check if the small edits in UserInterruptAgent and Program Manager themselves make sense - [x] Pipeline (tests) pass - [x] See that UserInterruptAgent, Program manager and UserInteract endpoint have enough coverage now
8464960 commented 2026-01-19 15:05:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed title from refactor: program restructure to chore: add missing tests

<p>changed title from <code class="idiff"><span class="idiff left deletion">refact</span>or: <span class="idiff right deletion">program restructure</span></code> to <code class="idiff"><span class="idiff left addition">ch</span>or<span class="idiff addition">e</span>: <span class="idiff right addition">add missing tests</span></code></p>
8464960 commented 2026-01-19 15:05:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
8464960 commented 2026-01-19 15:09:08 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @8464960

assigned to @8464960
8464960 commented 2026-01-19 15:29:37 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
8464960 commented 2026-01-19 16:25:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
9828273 commented 2026-01-26 12:48:48 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as completed

marked the checklist item **Pipeline \(tests\) pass** as completed
9828273 commented 2026-01-26 12:48:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @9828273

requested review from @9828273
9828273 commented 2026-01-26 12:50:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item See that UserInterruptAgent, Program manager and UserInteract endpoint have enough coverage now as completed

marked the checklist item **See that UserInterruptAgent, Program manager and UserInteract endpoint have enough coverage now** as completed
9828273 commented 2026-01-26 12:52:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This is fine for a test, (The test on line 340,) however it would probably be "more clean" to test for the scenarios on their own, so that a failing test tells more about where the functionality breaks.

This is fine for a test, (The test on line 340,) however it would probably be "more clean" to test for the scenarios on their own, so that a failing test tells more about where the functionality breaks.
9828273 commented 2026-01-26 12:54:55 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Check if the small edits in UserInterruptAgent and Program Manager themselves make sense as completed

marked the checklist item **Check if the small edits in UserInterruptAgent and Program Manager themselves make sense** as completed
9828273 commented 2026-01-26 12:54:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
9828273 commented 2026-01-26 14:39:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as incomplete

marked the checklist item **Pipeline \(tests\) pass** as incomplete
9828273 commented 2026-01-26 14:39:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

unapproved this merge request

unapproved this merge request
k.marinus commented 2026-01-26 20:21:38 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
k.marinus commented 2026-01-26 20:21:53 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Once the conflict is resolved I approve

Once the conflict is resolved I approve
8464960 commented 2026-01-27 10:49:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • a4cd0e3e - chore: applied feedback

Compare with previous version

added 1 commit <ul><li>a4cd0e3e - chore: applied feedback</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/45/diffs?diff_id=137911&start_sha=a0c839c54125809a57b3c43e2cd723d0cd940679)
8464960 commented 2026-01-27 10:54:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 18 commits

  • a4cd0e3e...da0f48e9 - 15 commits from branch dev
  • 215bafe2 - chore: added missing tests
  • 27f91150 - fix: look for goals in steps rather than plans
  • 9b040ffc - chore: applied feedback

Compare with previous version

added 18 commits <ul><li>a4cd0e3e...da0f48e9 - 15 commits from branch <code>dev</code></li><li>215bafe2 - chore: added missing tests</li><li>27f91150 - fix: look for goals in steps rather than plans</li><li>9b040ffc - chore: applied feedback</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/45/diffs?diff_id=137914&start_sha=a4cd0e3e24d5e4bc2c26f366531f6725865eaa30)
8464960 commented 2026-01-27 10:57:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I seperated the cases now!

I seperated the cases now!
9828273 commented 2026-01-27 10:58:08 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as completed

marked the checklist item **Pipeline \(tests\) pass** as completed
9828273 commented 2026-01-27 10:58:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
9828273 commented 2026-01-27 10:58:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 7c8a56dfcc

mentioned in commit 7c8a56dfcc4b83c5402739f8b10ff28ce213155d
9828273 (Migrated from git.science.uu.nl) merged commit 7c8a56dfcc into dev 2026-01-27 10:58:12 +00:00
k.marinus (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:05 +00:00
9828273 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
9828273
k.marinus
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#45
Delete Branch "chore/add-missing-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?