pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: add recursive goal mapping to UserInterruptAgent #46

Merged
8464960 merged 3 commits from feat/recursive-goals-override into dev 2026-01-27 17:04:50 +00:00
Conversation 21 Commits 3 Files Changed 2 +251 -3
8464960 commented 2026-01-27 10:32:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

ref: N25B-380

To verify:

  • Style checks pass

  • Pipeline (tests) pass

  • Documentation is up to date

  • Tests are up to date (99% coverage UserInterruptAgent)

  • !!Check if goal overrides work, by using for UI the branch feat/monitoringpage-pim and loading the attached JSON. The JSON consists of a tree of goals that can not be normally completed. You can test overriding of goals by clicking on the red cross and looking at logs in CB. If all goals are overriden, the program should end.

    recursive_goals.json

ref: N25B-380 To verify: - [x] Style checks pass - [x] Pipeline (tests) pass - [x] Documentation is up to date - [x] Tests are up to date (99% coverage UserInterruptAgent) - [x] !!Check if goal overrides work, by using for UI the branch feat/monitoringpage-pim and loading the attached JSON. The JSON consists of a tree of goals that can not be normally completed. You can test overriding of goals by clicking on the red cross and looking at logs in CB. If all goals are overriden, the program should end. [recursive_goals.json](/uploads/080a93735e7a1959f8924053e5d80301/recursive_goals.json)
8464960 commented 2026-01-27 10:32:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @8464960

assigned to @8464960
8464960 commented 2026-01-27 10:32:35 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item !!Check if goal overrides work, by using for UI the branch feat/monitoringpage-pim and loading the attached JSON. The JSON consists of a tree of goals that can not be normally completed. You can test overriding of goals by clicking on the red cross and looking at logs in CB. If all goals are overriden, the program should end. recursive_goals.json as incomplete

marked the checklist item **\!\!Check if goal overrides work, by using for UI the branch feat/monitoringpage\-pim and loading the attached JSON\. The JSON consists of a tree of goals that can not be normally completed\. You can test overriding of goals by clicking on the red cross and looking at logs in CB\. If all goals are overriden, the program should end\.
recursive\_goals\.json** as incomplete
8464960 (Migrated from git.science.uu.nl) changed target branch from main to dev 2026-01-27 10:33:28 +00:00
8464960 commented 2026-01-27 11:00:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
8464960 commented 2026-01-27 11:01:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • 53e07018 - chore: added missing tests
  • 2537dcf1 - fix: look for goals in steps rather than plans
  • bff399ba - chore: applied feedback

Compare with previous version

added 3 commits <ul><li>53e07018 - chore: added missing tests</li><li>2537dcf1 - fix: look for goals in steps rather than plans</li><li>bff399ba - chore: applied feedback</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/46/diffs?diff_id=137917&start_sha=198fbc02e61f994504165ae36082ce9779767d8a)
8464960 commented 2026-01-27 11:11:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 6 commits

  • bff399ba...7c8a56df - 4 commits from branch dev
  • 2404c847 - feat: added recursive goal mapping and tests
  • 1e7c2ba2 - chore: added missing tests

Compare with previous version

added 6 commits <ul><li>bff399ba...7c8a56df - 4 commits from branch <code>dev</code></li><li>2404c847 - feat: added recursive goal mapping and tests</li><li>1e7c2ba2 - chore: added missing tests</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/46/diffs?diff_id=137918&start_sha=bff399ba3a924d111cf3cf8da12f63947b73e611)
k.marinus commented 2026-01-27 15:40:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as completed

marked the checklist item **Pipeline \(tests\) pass** as completed
k.marinus commented 2026-01-27 15:44:30 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This check is not necessary, both cannot be None

This check is not necessary, both cannot be `None`
k.marinus commented 2026-01-27 15:58:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item !!Check if goal overrides work, by using for UI the branch feat/monitoringpage-pim and loading the attached JSON. The JSON consists of a tree of goals that can not be normally completed. You can test overriding of goals by clicking on the red cross and looking at logs in CB. If all goals are overriden, the program should end. recursive_goals.json as completed

marked the checklist item **\!\!Check if goal overrides work, by using for UI the branch feat/monitoringpage\-pim and loading the attached JSON\. The JSON consists of a tree of goals that can not be normally completed\. You can test overriding of goals by clicking on the red cross and looking at logs in CB\. If all goals are overriden, the program should end\.&#10;recursive\_goals\.json** as completed
k.marinus commented 2026-01-27 15:58:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Documentation is up to date as completed

marked the checklist item **Documentation is up to date** as completed
k.marinus commented 2026-01-27 15:58:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Style checks pass as completed

marked the checklist item **Style checks pass** as completed
k.marinus commented 2026-01-27 16:00:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Tests are up to date (99% coverage UserInterruptAgent) as completed

marked the checklist item **Tests are up to date \(99% coverage UserInterruptAgent\)** as completed
k.marinus commented 2026-01-27 16:00:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2026-01-27 16:03:43 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/46/diffs?diff_id=137969&start_sha=1e7c2ba229d008ee390d5aa6aa7688635a6658a2#a7557f4f31cc9547313b7081d41c1c25c90acdc6_256_255)
8464960 commented 2026-01-27 16:03:43 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>bc9045c9 - chore: applied feedback</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/46/diffs?diff_id=137969&start_sha=1e7c2ba229d008ee390d5aa6aa7688635a6658a2)
8464960 commented 2026-01-27 16:04:23 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Should be fixed now

Should be fixed now
8464960 commented 2026-01-27 16:04:24 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
0950726 commented 2026-01-27 17:04:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
0950726 commented 2026-01-27 17:04:43 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
0950726 commented 2026-01-27 17:04:50 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit cc09c1b289

mentioned in commit cc09c1b289488461978526394fa93f705444afd3
0950726 (Migrated from git.science.uu.nl) merged commit cc09c1b289 into dev 2026-01-27 17:04:50 +00:00
k.marinus (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:05 +00:00
0950726 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
k.marinus
0950726
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#46
Delete Branch "feat/recursive-goals-override"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?