Merge new implementation of robot ri api with unit tests into dev. #6

Merged
9828273 merged 39 commits from feat/cb2ui-robot-connections into dev 2025-10-28 13:49:41 +00:00
9828273 commented 2025-10-22 09:18:28 +00:00 (Migrated from git.science.uu.nl)

This merge adds the new agent structure into dev, focussing on the robot ri api. It includes unit tests and communication agents that check the respective sockets and can handle negotiation for the ports and binds.

In order to test this merge you should do the following:

  • Switch branch
  • UV sync
  • Create a certificate for localhost and pass it to prosody
  • Run the pytest (with coverage analysis)
  • Run the python script to assure startup

To use the certificate follow these steps (In the correct map:):

  • sudo prosodyctl cert generate localhost Generates a certificate, asking you for the parameters...
  • You need to make sure that commonName has (localHost) next to it, or enter it yourself. The rest of the parameters can
    be the default value, by pressing Enter.
  • do cp /var/lib/prosody/localhost.crt /etc/prosody/certs/localhost.crt and cp /var/lib/prosody/localhost.key /etc/prosody/certs/localhost.key to copy the certificate and key to the correct map.
  • do sudo chown prosody /etc/prosody/certs/localhost.{key,crt} to change 'ownership' to prosody and enable the certificate.

(If any of these steps need additional permissions, make sure to use sudo before the command)

In order to test this environment you can use the pytest library (make sure you are in the virtual environment):
PYTHONPATH=src pytest test/
If you want additional feedback on coverage you can use this command:
PYTHONPATH=src pytest --cov=control_backend.agents.ri_communication_agent --cov=control_backend.agents.ri_command_agent --cov-report=term-missing test/

In order to approve of this merge you can follow this checklist:

  • This code follows the style guide.
  • The unit tests cover 100% of communication/commands agent code and all pass.
  • Starting the code using uv run fastapi dev src/control_backend/main.py should result in the following log:
INFO:uvicorn.error:Waiting for application startup.
INFO:control_backend.main:PepperPlus starting up.
INFO:control_backend.main:Internal publishing socket bound to <zmq.asyncio.Socket(zmq.PUB) at 0x7d53ea34ecf0>
INFO:slixmpp.features.feature_bind.bind:JID set to: ri_communication_agent@localhost/SZOtrUloUo4F
INFO:spade.Agent:Agent ri_communication_agent@localhost connected and authenticated.
INFO:control_backend.agents.ri_communication_agent:Setting up ri_communication_agent@localhost

and after initializing with the RI, the message stream should look like this:

INFO:spade.Agent:Agent ri_communication_agent@localhost connected and authenticated.
INFO:control_backend.agents.ri_communication_agent:Setting up ri_communication_agent@localhost
INFO:slixmpp.features.feature_bind.bind:JID set to: ri_command_agent@localhost/qP7S5haFKc4g
INFO:spade.Agent:Agent ri_command_agent@localhost connected and authenticated.
INFO:control_backend.agents.ri_command_agent:Setting up ri_command_agent@localhost
INFO:control_backend.agents.ri_command_agent:Finished setting up ri_command_agent@localhost
WARNING:control_backend.agents.ri_communication_agent:Unhandled negotiation id: video
INFO:control_backend.agents.ri_communication_agent:Finished setting up ri_communication_agent@localhost
      INFO   Application startup complete.
INFO:uvicorn.error:Application startup complete.
INFO:control_backend.agents.ri_communication_agent:Received message "{'endpoint': 'ping', 'data': {'id': 'e.g. some reference id'}}"
INFO:control_backend.agents.ri_communication_agent:Received message "{'endpoint': 'ping', 'data': {'id': 'e.g. some reference id'}}"
etc..

This means that the agents are correctly setup, and that the ping system is working correctly.

ref:N25B-170
ref:N25B-205

This merge adds the new agent structure into dev, focussing on the robot ri api. It includes unit tests and communication agents that check the respective sockets and can handle negotiation for the ports and binds. In order to test this merge you should do the following: - Switch branch - UV sync - Create a certificate for localhost and pass it to prosody - Run the pytest (with coverage analysis) - Run the python script to assure startup To use the certificate follow these steps (In the correct map:): - `sudo prosodyctl cert generate localhost` Generates a certificate, asking you for the parameters... - You need to make sure that `commonName` has `(localHost)` next to it, or enter it yourself. The rest of the parameters can be the default value, by pressing `Enter`. - do `cp /var/lib/prosody/localhost.crt /etc/prosody/certs/localhost.crt` and `cp /var/lib/prosody/localhost.key /etc/prosody/certs/localhost.key` to copy the certificate and key to the correct map. - do `sudo chown prosody /etc/prosody/certs/localhost.{key,crt}` to change 'ownership' to prosody and enable the certificate. (If any of these steps need additional permissions, make sure to use `sudo` before the command) In order to test this environment you can use the pytest library (make sure you are in the virtual environment): ─ `PYTHONPATH=src pytest test/` If you want additional feedback on coverage you can use this command: ─ `PYTHONPATH=src pytest --cov=control_backend.agents.ri_communication_agent --cov=control_backend.agents.ri_command_agent --cov-report=term-missing test/` In order to approve of this merge you can follow this checklist: - [ ] This code follows the style guide. - [ ] The unit tests cover 100% of communication/commands agent code and all pass. - [ ] Starting the code using `uv run fastapi dev src/control_backend/main.py` should result in the following log: ``` INFO:uvicorn.error:Waiting for application startup. INFO:control_backend.main:PepperPlus starting up. INFO:control_backend.main:Internal publishing socket bound to <zmq.asyncio.Socket(zmq.PUB) at 0x7d53ea34ecf0> INFO:slixmpp.features.feature_bind.bind:JID set to: ri_communication_agent@localhost/SZOtrUloUo4F INFO:spade.Agent:Agent ri_communication_agent@localhost connected and authenticated. INFO:control_backend.agents.ri_communication_agent:Setting up ri_communication_agent@localhost ``` and after initializing with the RI, the message stream should look like this: ``` INFO:spade.Agent:Agent ri_communication_agent@localhost connected and authenticated. INFO:control_backend.agents.ri_communication_agent:Setting up ri_communication_agent@localhost INFO:slixmpp.features.feature_bind.bind:JID set to: ri_command_agent@localhost/qP7S5haFKc4g INFO:spade.Agent:Agent ri_command_agent@localhost connected and authenticated. INFO:control_backend.agents.ri_command_agent:Setting up ri_command_agent@localhost INFO:control_backend.agents.ri_command_agent:Finished setting up ri_command_agent@localhost WARNING:control_backend.agents.ri_communication_agent:Unhandled negotiation id: video INFO:control_backend.agents.ri_communication_agent:Finished setting up ri_communication_agent@localhost INFO Application startup complete. INFO:uvicorn.error:Application startup complete. INFO:control_backend.agents.ri_communication_agent:Received message "{'endpoint': 'ping', 'data': {'id': 'e.g. some reference id'}}" INFO:control_backend.agents.ri_communication_agent:Received message "{'endpoint': 'ping', 'data': {'id': 'e.g. some reference id'}}" etc.. ``` This means that the agents are correctly setup, and that the ping system is working correctly. ref:N25B-170 ref:N25B-205
9828273 commented 2025-10-22 09:18:28 +00:00 (Migrated from git.science.uu.nl)

assigned to @9828273

assigned to @9828273
k.marinus commented 2025-10-22 10:25:19 +00:00 (Migrated from git.science.uu.nl)

.vscode/ should be added to the .gitignore I think.

The test/ directory structure should mirror that of src/. This means that your tests should be under test/control_backend/agents/...

.vscode/ should be added to the .gitignore I think. The test/ directory structure should mirror that of src/. This means that your tests should be under test/control_backend/agents/...
9828273 commented 2025-10-22 10:41:51 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • d71cb605 - fix: gitignore + testing map structure

Compare with previous version

added 1 commit <ul><li>d71cb605 - fix: gitignore + testing map structure</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132749&start_sha=77c6704632b71fa960f02b916b49c9fda2d65aea)
9828273 commented 2025-10-22 10:51:15 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 530fc42c - fix: router changes + hopefully gitignore

Compare with previous version

added 1 commit <ul><li>530fc42c - fix: router changes + hopefully gitignore</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132751&start_sha=d71cb60523deb60601769ce9c12ab60fab616aab)
0950726 commented 2025-10-22 14:22:01 +00:00 (Migrated from git.science.uu.nl)

requested review from @0950726

requested review from @0950726
k.marinus commented 2025-10-22 15:40:49 +00:00 (Migrated from git.science.uu.nl)

Ter verduidelijking: in dev staat nu een geautomatiseerd testsysteem, en daar is de PYTHONPATH al goed geregeld. Die hoef je er dus niet meer actief bij te zetten. Daarnaast: je kunt beter de tests runnen met uv run --only-group test pytest om ervoor te zorgen dat alleen de benodigde dependencies (libraries) in de venv staan. Waarschijnlijk gaat dat niet in 1x goed, dan moet je even kijken hoe ik het heb gefixt met de conftest.py door de libraries te mocken. Voor dat command met de gescheiden dependencies moet je ook je environment updaten, maar dat kan in principe ook door degene te kopieren die nu in dev staat.

Ter verduidelijking: in dev staat nu een geautomatiseerd testsysteem, en daar is de PYTHONPATH al goed geregeld. Die hoef je er dus niet meer actief bij te zetten. Daarnaast: je kunt beter de tests runnen met `uv run --only-group test pytest` om ervoor te zorgen dat alleen de benodigde dependencies (libraries) in de venv staan. Waarschijnlijk gaat dat niet in 1x goed, dan moet je even kijken hoe ik het heb gefixt met de `conftest.py` door de libraries te mocken. Voor dat command met de gescheiden dependencies moet je ook je environment updaten, maar dat kan in principe ook door degene te kopieren die nu in dev staat.
0950726 commented 2025-10-22 17:19:30 +00:00 (Migrated from git.science.uu.nl)

I think we should not log every ping message, definitely not as logger.info, maybe with logger.debug.

I think we should not log every ping message, definitely not as `logger.info`, maybe with `logger.debug`.
0950726 commented 2025-10-22 17:30:05 +00:00 (Migrated from git.science.uu.nl)

Message is not the right model for the RI. Instead of {"message": "something"}, it should be something like {"endpoint": "actuate/...", "data": "some data"}

You could make a pydantic model like:

from typing import Literal

from pydantic import BaseModel


class SpeechCommand(BaseModel):
    endpoint: Literal["actuate/speech"]
    data: str
`Message` is not the right model for the RI. Instead of `{"message": "something"}`, it should be something like `{"endpoint": "actuate/...", "data": "some data"}` You could make a pydantic model like: ```python from typing import Literal from pydantic import BaseModel class SpeechCommand(BaseModel): endpoint: Literal["actuate/speech"] data: str ```
0950726 commented 2025-10-22 17:35:10 +00:00 (Migrated from git.science.uu.nl)

If it's in the scope of your tickets, make an endpoint in the control_backend.api.v1.endpoints, like "command.py" to replace "message.py". "message.py" is dependent on this Message model, so maybe "command.py" can use a new SpeechCommand model.

Making a web request to "/command/speak" or "/command/gesture" would be nice and more descriptive than "/message"

If it's in the scope of your tickets, make an endpoint in the `control_backend.api.v1.endpoints`, like "command.py" to replace "message.py". "message.py" is dependent on this `Message` model, so maybe "command.py" can use a new `SpeechCommand` model. Making a web request to "/command/speak" or "/command/gesture" would be nice and more descriptive than "/message"
0950726 commented 2025-10-23 08:24:09 +00:00 (Migrated from git.science.uu.nl)

For example:

from enum import Enum
from typing import Any, Literal

from pydantic import BaseModel, ValidationError


class RIEndpoint(str, Enum):
    SPEECH = "actuate/speech"
    PING = "ping"
    NEGOTIATE_PORTS = "negotiate/ports"


class RIMessage(BaseModel):
    endpoint: RIEndpoint
    data: Any


class SpeechCommand(RIMessage):
    endpoint: Literal[RIEndpoint.SPEECH] = RIEndpoint.SPEECH
    data: str


if __name__ == "__main__":
    command = SpeechCommand(data="Hallo?")

    try:
        RIMessage.model_validate(command)
        print("The given object is a valid RIMessage.")
        SpeechCommand.model_validate(command)
        print("The given object is a valid SpeechCommand.")
    except ValidationError as e:
        print("The given speech command is invalid:", e)

    print(command.model_dump_json())

Edit: SpeechCommand should inherit from RIMessage.

For example: ```python from enum import Enum from typing import Any, Literal from pydantic import BaseModel, ValidationError class RIEndpoint(str, Enum): SPEECH = "actuate/speech" PING = "ping" NEGOTIATE_PORTS = "negotiate/ports" class RIMessage(BaseModel): endpoint: RIEndpoint data: Any class SpeechCommand(RIMessage): endpoint: Literal[RIEndpoint.SPEECH] = RIEndpoint.SPEECH data: str if __name__ == "__main__": command = SpeechCommand(data="Hallo?") try: RIMessage.model_validate(command) print("The given object is a valid RIMessage.") SpeechCommand.model_validate(command) print("The given object is a valid SpeechCommand.") except ValidationError as e: print("The given speech command is invalid:", e) print(command.model_dump_json()) ``` Edit: `SpeechCommand` should inherit from `RIMessage`.
9828273 commented 2025-10-23 10:54:56 +00:00 (Migrated from git.science.uu.nl)

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132845&start_sha=530fc42c50a3cdd99d82b3ce27f4e77ac0e3439b#0df364dcb30720c83c10dad3c7bae0c633022403_48_47)
9828273 commented 2025-10-23 10:54:57 +00:00 (Migrated from git.science.uu.nl)

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132845&start_sha=530fc42c50a3cdd99d82b3ce27f4e77ac0e3439b#39c99f53c9d7cabed6b3bb5eef7c0be80596648c_36_36)
9828273 commented 2025-10-23 10:54:57 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 1f8d7697 - chore: adjust message/command structure and write unit tests

Compare with previous version

added 1 commit <ul><li>1f8d7697 - chore: adjust message/command structure and write unit tests</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132845&start_sha=530fc42c50a3cdd99d82b3ce27f4e77ac0e3439b)
9828273 commented 2025-10-23 14:45:44 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • a2a04740 - chore: add unit test for router and implement command router

Compare with previous version

added 1 commit <ul><li>a2a04740 - chore: add unit test for router and implement command router</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132857&start_sha=1f8d7697626adea4db8d9ae17ecac7bfece645eb)
9828273 commented 2025-10-23 14:48:11 +00:00 (Migrated from git.science.uu.nl)

added 14 commits

  • a2a04740...9b36982b - 13 commits from branch dev
  • d599f71c - Merge remote-tracking branch 'origin/dev' into feat/cb2ui-robot-connections

Compare with previous version

added 14 commits <ul><li>a2a04740...9b36982b - 13 commits from branch <code>dev</code></li><li>d599f71c - Merge remote-tracking branch &#39;origin/dev&#39; into feat/cb2ui-robot-connections</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132858&start_sha=a2a04740e51c978a4baf863abf05a7bfc315b056)
9828273 commented 2025-10-23 14:54:28 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 87bd12d7 - fix: restructure tests for integration

Compare with previous version

added 1 commit <ul><li>87bd12d7 - fix: restructure tests for integration</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132860&start_sha=d599f71c8ac0e61e687e63b7f33f20df66bb1922)
9828273 commented 2025-10-23 15:02:20 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • c1217a90 - fix: fixed duplicate entry in uv.lock

Compare with previous version

added 1 commit <ul><li>c1217a90 - fix: fixed duplicate entry in uv.lock</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132862&start_sha=87bd12d7a53eb2229ba7c5653c74745ab22de50d)
9828273 commented 2025-10-23 15:12:52 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 31e77de2 - chore: fix style guide max characters

Compare with previous version

added 1 commit <ul><li>31e77de2 - chore: fix style guide max characters</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132864&start_sha=c1217a90176df41eaf0c1c8cdfff4501b15fb1e4)
0950726 commented 2025-10-23 21:06:55 +00:00 (Migrated from git.science.uu.nl)

I had to make some changes to be able to send a speech message to the RI from an HTTP request. I believe all contents of a send_multipart message need to be bytes, so:

    pub_socket.send_multipart([topic, command.model_dump_json().encode()])
I had to make some changes to be able to send a speech message to the RI from an HTTP request. I believe all contents of a `send_multipart` message need to be `bytes`, so: ```suggestion:-0+0 pub_socket.send_multipart([topic, command.model_dump_json().encode()]) ```
0950726 commented 2025-10-23 21:08:29 +00:00 (Migrated from git.science.uu.nl)

recv_multipart gives only bytes, so:

                body = json.loads(body)
                message = SpeechCommand.model_validate(body)
                
                # Send to the robot.
                await self.agent.pubsocket.send_json(message.model_dump())
`recv_multipart` gives only bytes, so: ```suggestion:-4+0 body = json.loads(body) message = SpeechCommand.model_validate(body) # Send to the robot. await self.agent.pubsocket.send_json(message.model_dump()) ```
0950726 commented 2025-10-23 21:10:48 +00:00 (Migrated from git.science.uu.nl)

Perhaps make an integration test for this: mocking the pubsocket.send_json of ri_command_agent and checking whether it gets called and whether the argument is correct.

Perhaps make an integration test for this: mocking the `pubsocket.send_json` of `ri_command_agent` and checking whether it gets called and whether the argument is correct.
0950726 commented 2025-10-28 10:00:55 +00:00 (Migrated from git.science.uu.nl)

We now have a linter in the dev branch. Could you merge that and format your code with:

uv sync
ruff format

There might be things it cannot change automatically. If it doesn't tell you which things, try ruff check to find them and then change them manually.

We now have a linter in the `dev` branch. Could you merge that and format your code with: ``` uv sync ``` ``` ruff format ``` There might be things it cannot change automatically. If it doesn't tell you which things, try `ruff check` to find them and then change them manually.
9828273 commented 2025-10-28 10:05:31 +00:00 (Migrated from git.science.uu.nl)

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132993&start_sha=31e77de26b7df49853712618abdb3597be9eee66#2b32578c655a92f6296018c8deeb4f3d166aec9b_18_18)
9828273 commented 2025-10-28 10:05:31 +00:00 (Migrated from git.science.uu.nl)

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132993&start_sha=31e77de26b7df49853712618abdb3597be9eee66#39c99f53c9d7cabed6b3bb5eef7c0be80596648c_39_39)
9828273 commented 2025-10-28 10:05:32 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 149d20e7 - chore: apply recommended changes for merging

Compare with previous version

added 1 commit <ul><li>149d20e7 - chore: apply recommended changes for merging</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132993&start_sha=31e77de26b7df49853712618abdb3597be9eee66)
9828273 commented 2025-10-28 10:09:27 +00:00 (Migrated from git.science.uu.nl)

added 4 commits

  • 149d20e7...dc811fd6 - 3 commits from branch dev
  • 52faa591 - Merge remote-tracking branch 'origin/dev' into feat/cb2ui-robot-connections

Compare with previous version

added 4 commits <ul><li>149d20e7...dc811fd6 - 3 commits from branch <code>dev</code></li><li>52faa591 - Merge remote-tracking branch &#39;origin/dev&#39; into feat/cb2ui-robot-connections</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132994&start_sha=149d20e77b816aab227034952e4106f0b7a080bc)
9828273 commented 2025-10-28 10:31:10 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 47a87d0b - fix: unit tests fixes and ruff formating

Compare with previous version

added 1 commit <ul><li>47a87d0b - fix: unit tests fixes and ruff formating</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=132996&start_sha=52faa59184f9c5ec93244bc1adee47afd40efdd5)
9828273 commented 2025-10-28 11:11:34 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

Compare with previous version

added 1 commit <ul><li>473c0fdc - fix: fix gitlab ci pipeline</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133001&start_sha=47a87d0b4ade425ba0905e950e8068ea3c929404)
9828273 commented 2025-10-28 11:20:47 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • c75f5de9 - fix: fix only group integration testing to exclude missing dependencies

Compare with previous version

added 1 commit <ul><li>c75f5de9 - fix: fix only group integration testing to exclude missing dependencies</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133008&start_sha=473c0fdce13d995f72040a611423c1573ae45242)
9828273 commented 2025-10-28 12:26:37 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 423309e0 - fix: unit test refactoring with conftest and more mocks

Compare with previous version

added 1 commit <ul><li>423309e0 - fix: unit test refactoring with conftest and more mocks</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133033&start_sha=c75f5de97c31fdda8aa5b4815ec68686bcf9a65c)
9828273 commented 2025-10-28 12:28:42 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • acb6a694 - fix: quick fix for pydantic import for tests

Compare with previous version

added 1 commit <ul><li>acb6a694 - fix: quick fix for pydantic import for tests</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133035&start_sha=423309e0630ddd322f5f690ce1bac935fb236743)
9828273 commented 2025-10-28 12:31:46 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 3730943b - fix: quick fix for fastapi import for tests

Compare with previous version

added 1 commit <ul><li>3730943b - fix: quick fix for fastapi import for tests</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133037&start_sha=acb6a69467f65229ae4eb36efe090890395961d3)
9828273 commented 2025-10-28 13:22:29 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • a1b8a7a0 - Revert "fix: quick fix for fastapi import for tests"

Compare with previous version

added 1 commit <ul><li>a1b8a7a0 - Revert &quot;fix: quick fix for fastapi import for tests&quot;</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133045&start_sha=3730943b9ef28f2f32280ee008228bec5f5dff62)
9828273 commented 2025-10-28 13:22:35 +00:00 (Migrated from git.science.uu.nl)

added 3 commits

  • 437b21a6 - Revert "fix: quick fix for pydantic import for tests"
  • fd11e63b - Revert "fix: unit test refactoring with conftest and more mocks"
  • e196609e - Revert "fix: fix only group integration testing to exclude missing dependencies"

Compare with previous version

added 3 commits <ul><li>437b21a6 - Revert &quot;fix: quick fix for pydantic import for tests&quot;</li><li>fd11e63b - Revert &quot;fix: unit test refactoring with conftest and more mocks&quot;</li><li>e196609e - Revert &quot;fix: fix only group integration testing to exclude missing dependencies&quot;</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133046&start_sha=a1b8a7a05e278c7469d99f64e76c742888fe0d33)
9828273 commented 2025-10-28 13:23:04 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • bea6bf2a - fix: Reverted to different branch and updated gitlab cicd for this branch

Compare with previous version

added 1 commit <ul><li>bea6bf2a - fix: Reverted to different branch and updated gitlab cicd for this branch</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133048&start_sha=e196609e6467440be401de14f38b9853cbc5dc73)
9828273 commented 2025-10-28 13:27:49 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

  • 2b8a3967 - fix: just dont do integration tests. :(

Compare with previous version

added 1 commit <ul><li>2b8a3967 - fix: just dont do integration tests. :(</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133050&start_sha=bea6bf2a60dd49ba310ea60dca813d19dba25fb7)
9828273 commented 2025-10-28 13:38:37 +00:00 (Migrated from git.science.uu.nl)

added 1 commit

Compare with previous version

added 1 commit <ul><li>158911b1 - fix: change conftest place</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/6/diffs?diff_id=133052&start_sha=2b8a396766cdef9d3a469d481616cf8ca2fc3394)
0950726 commented 2025-10-28 13:49:35 +00:00 (Migrated from git.science.uu.nl)

Tests pass, my end to end system tests with

curl -X POST http://localhost:8000/command -H 'content-type: application/json' -d '{"endpoint": "actuate/speech", "data": "Something to speak."}'

And RI running also works. I'm gonna merge!

Tests pass, my end to end system tests with ``` curl -X POST http://localhost:8000/command -H 'content-type: application/json' -d '{"endpoint": "actuate/speech", "data": "Something to speak."}' ``` And RI running also works. I'm gonna merge!
0950726 (Migrated from git.science.uu.nl) merged commit b551e4e042 into dev 2025-10-28 13:49:41 +00:00
0950726 commented 2025-10-28 13:49:42 +00:00 (Migrated from git.science.uu.nl)

mentioned in commit b551e4e042

mentioned in commit b551e4e0422af867b8e1ee3a54fd58e66548b441
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#6