pepperplus/pepperplus-ri
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: send video #28

Merged
s.o.h.luijkx merged 6 commits from fix/send-video into main 2026-01-30 19:19:04 +00:00
Conversation 7 Commits 6 Files Changed 3 +56 -13
s.o.h.luijkx commented 2026-01-29 11:35:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Video images are now sent as [width, height, image_bytes].
I have empirically tested that this images are properly sent and received.

Verify:

  • Run tests and check for 100% coverage

ref: N25B-393

Video images are now sent as [width, height, image_bytes]. I have empirically tested that this images are properly sent and received. Verify: - [x] Run tests and check for 100% coverage ref: N25B-393
s.o.h.luijkx (Migrated from git.science.uu.nl) changed target branch from main to dev 2026-01-29 11:35:25 +00:00
s.o.h.luijkx commented 2026-01-29 12:09:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8333f2fc - chore: removed numpy import</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ri/-/merge_requests/28/diffs?diff_id=138071&start_sha=24c7fa216fb56bd4366e8b0155e7026cbef9debf)
s.o.h.luijkx commented 2026-01-30 16:28:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 6 commits

  • 8333f2fc...fb0d7850 - 2 commits from branch dev
  • ad58b165 - Merge branch 'dev' into 'main'
  • ea208175 - chore: add copyright to all source files
  • 5bb5d8a0 - Merge branch 'chore/copyright-all-files' into 'main'
  • fe8bad1f - Merge branch 'main' into fix/send-video

Compare with previous version

added 6 commits <ul><li>8333f2fc...fb0d7850 - 2 commits from branch <code>dev</code></li><li>ad58b165 - Merge branch &#39;dev&#39; into &#39;main&#39;</li><li>ea208175 - chore: add copyright to all source files</li><li>5bb5d8a0 - Merge branch &#39;chore/copyright-all-files&#39; into &#39;main&#39;</li><li>fe8bad1f - Merge branch &#39;main&#39; into fix/send-video</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ri/-/merge_requests/28/diffs?diff_id=138129&start_sha=8333f2fc2a5b8c5c4b4d9e697ed182b772c1231d)
8464960 (Migrated from git.science.uu.nl) changed target branch from dev to main 2026-01-30 16:51:18 +00:00
8464960 commented 2026-01-30 17:17:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Run tests and check for 100% coverage as completed

marked the checklist item **Run tests and check for 100% coverage** as completed
8464960 commented 2026-01-30 17:19:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I checked if all code was covered and it was. Good job!

I don't really know how to test "Video images are now sent as [width, height, image_bytes]. I have empirically tested that this images are properly sent and received."

But if it works on Pepper, I assume it is sent correctly. I approve

I checked if all code was covered and it was. Good job! I don't really know how to test "Video images are now sent as \[width, height, image_bytes\]. I have empirically tested that this images are properly sent and received." But if it works on Pepper, I assume it is sent correctly. I approve
8464960 commented 2026-01-30 17:19:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
k.marinus commented 2026-01-30 19:19:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 06e3dad25d

mentioned in commit 06e3dad25d8f5888b4e46b7ccfd24d251332fe03
k.marinus (Migrated from git.science.uu.nl) merged commit 06e3dad25d into main 2026-01-30 19:19:05 +00:00
8464960 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:26:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
8464960
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ri#28
Delete Branch "fix/send-video"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?