test: extra norm tests

ref: N25B-392

src/pages/VisProgPage/visualProgrammingUI/VisProgStores.tsx

@@ -36,7 +36,7 @@ function createNode(id: string, type: string, position: XYPosition, data: Record
       position,
       deletable,
       data: {
-        ...defaultData,
+        ...JSON.parse(JSON.stringify(defaultData)),
         ...data,
       },
     }

src/pages/VisProgPage/visualProgrammingUI/nodes/NormNode.tsx

@@ -141,7 +141,11 @@ export function NormConnectionSource(_thisNode: Node, _targetNodeId: string) {
  * @param _sourceNodeId the source of the disconnected connection
  */
 export function NormDisconnectionTarget(_thisNode: Node, _sourceNodeId: string) {
-  // no additional connection logic exists yet
+  const data = _thisNode.data as NormNodeData;
+  // If we got a belief connected, this is a condition for the norm.
+  if ((useFlowStore.getState().nodes.find((node) => node.id === _sourceNodeId && node.type === 'basic_belief' /* TODO: Add the option for an inferred belief */))) {
+    data.conditions = data.conditions.filter(id => id != _sourceNodeId);
+    }
 }
 
 /**

test/pages/visProgPage/visualProgrammingUI/nodes/NormNode.test.tsx

@@ -930,14 +930,24 @@ describe('NormNode', () => {
       });
        
       // Simulate connecting
-      NormConnectionTarget(mockNode, mockBelief1.id);
-      NormConnectionTarget(mockNode, mockBelief2.id);
-      BasicBeliefConnectionSource(mockBelief1, mockNode.id);
-      BasicBeliefConnectionSource(mockBelief2, mockNode.id);
+      useFlowStore.getState().onConnect({
+        source: 'basic_belief-1',
+        target: 'norm-1',
+        sourceHandle: null,
+        targetHandle: null,
+      });
+      useFlowStore.getState().onConnect({
+        source: 'basic_belief-2',
+        target: 'norm-1',
+        sourceHandle: null,
+        targetHandle: null,
+      });
+      
       
       const state = useFlowStore.getState();
       const updatedNorm = state.nodes.find(n => n.id === 'norm-1');
-      expect(updatedNorm?.data.conditions).toBe(["basic_belief-1", "basic_belief-2"]);
+      console.log(updatedNorm?.data.conditions);
+      expect(updatedNorm?.data.conditions).toEqual(["basic_belief-1", "basic_belief-1", "basic_belief-2"]);
     });
 
 

test/pages/visProgPage/visualProgrammingUI/nodes/UniversalNodes.test.tsx

@@ -8,7 +8,7 @@ import { createElement } from 'react';
 import useFlowStore from '../../../../../src/pages/VisProgPage/visualProgrammingUI/VisProgStores';
 
 
-describe('NormNode', () => {
+describe('Universal Nodes', () => {
   beforeEach(() => {
     jest.clearAllMocks();
   });
@@ -109,6 +109,50 @@ describe('NormNode', () => {
     }); 
   });
 
+  describe('Disconnecting', () => {
+    test.each(getAllTypes())('it should remove the correct data when something is disconnected on a %s node.', (nodeType) => {
+      // Create two nodes - one of the current type and one to connect to
+      const sourceNode = createNode('source-1', nodeType, {x: 100, y: 100}, {});
+      const targetNode = createNode('target-1', 'basic_belief', {x: 300, y: 100}, {});
+      
+      // Add nodes to store
+      useFlowStore.setState({ nodes: [sourceNode, targetNode] });
+
+      // Spy on the connect functions
+      const sourceConnectSpy = jest.spyOn(NodeConnections.Sources, nodeType as keyof typeof NodeConnections.Sources);
+      const targetConnectSpy = jest.spyOn(NodeConnections.Targets, 'basic_belief');
+
+      // Simulate connection
+      useFlowStore.getState().onConnect({
+        source: 'source-1',
+        target: 'target-1',
+        sourceHandle: null,
+        targetHandle: null,
+      });
+
+    
+      // Verify the connect functions were called
+      expect(sourceConnectSpy).toHaveBeenCalledWith(sourceNode, targetNode.id);
+      expect(targetConnectSpy).toHaveBeenCalledWith(targetNode, sourceNode.id);
+
+      // Find this connection, and delete it
+      const edge = useFlowStore.getState().edges[0];
+      useFlowStore.getState().onEdgesDelete([edge]);
+
+      // Find the nodes in the flow
+      const newSourceNode = useFlowStore.getState().nodes.find((node) => node.id == "source-1");
+      const newTargetNode = useFlowStore.getState().nodes.find((node) => node.id == "target-1");
+
+      // Expect them to be the same after deleting the edges
+      expect(newSourceNode).toBe(sourceNode);
+      expect(newTargetNode).toBe(targetNode);
+
+      // Restore our spies
+      sourceConnectSpy.mockRestore();
+      targetConnectSpy.mockRestore();
+    }); 
+  });
+
   describe('Reducing', () => {
     test.each(getAllTypes())('it should correctly call/ not call the reduce function when %s node is in a phase', (nodeType) => {
       // Create a phase node and a node of the current type