feat: show connected robots in ui when getting cb pings #15
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: pepperplus/pepperplus-ui#15
Reference in New Issue
Block a user
Delete Branch "feat/show-connected-robots"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Using a branch of CB which sends pings to the ping_stream, we want to update and show these on the UI.
For now, this is a page.
In order to complete this merge, follow steps and mark the checklist:
sudo prodactl adduser {name@localhost}with password {name}.uv syncandnpm i.npx jestshows that all test suites pass (with 93% line coverage in ConnectedRobots.tsx)Connected Robotspage shows whether the robot is currently connected (should be true)checking...npx eslintdoesn't show any formatting/ style errors or warnings.Additional comments:
We still have to work out the CB-sided merge for connected robots. This means that the page will just show
checking...on dev for now.In case there are different cases I need to clarify or work out, let me know.
changed the description
changed the description
assigned to @9828273
unassigned @9828273
Looks like this has remnants of an older version of the project. For example,
src/visualProgrammingUIshould no longer exist because its contents have been moved undersrc/pages.added 1 commit
8733bb3c- chore: remove old remnants from projectCompare with previous version
added 1 commit
df434615- chore: remove old code pt 2Compare with previous version
Without a dependency array, this runs every render, which is every time it gets a new message.
marked the checklist item This branch is up to date with dev as completed
marked the checklist item
npx jestshows that all test suites pass (with 93% line coverage in ConnectedRobots.tsx) as completedmarked the checklist item First starting the CB, then starting the RI to connect, and finally launching the UI, the
Connected Robotspage shows whether the robot is currently connected (should be true) as completedmarked the checklist item AFTER, disconnecting the RI (by Cntr+C or other ways) should result in the page showing the robot is disconnected. as completed
marked the checklist item Then, when reconnecting (using same ports) on RI, it should switch back to connected again. as completed
marked the checklist item Also make sure that when the CB is not correctly setup yet, the page shows its currently
checking...as completedmarked the checklist item
npx eslintdoesn't show any formatting/ style errors or warnings. as completedrequested review from @0950726
changed this line in version 4 of the diff
added 1 commit
87cf723c- chore: fixed merge request suggestion for adding depency arrayCompare with previous version
added 3 commits
devbe4fb0e7- Merge remote-tracking branch 'origin/dev' into feat/show-connected-robotsCompare with previous version
added 7 commits
dev476c5384- build: fixed small merge conflictCompare with previous version
marked the checklist item
npx eslintdoesn't show any formatting/ style errors or warnings. as incompletemarked the checklist item Also make sure that when the CB is not correctly setup yet, the page shows its currently
checking...as incompletemarked the checklist item Then, when reconnecting (using same ports) on RI, it should switch back to connected again. as incomplete
marked the checklist item AFTER, disconnecting the RI (by Cntr+C or other ways) should result in the page showing the robot is disconnected. as incomplete
marked the checklist item First starting the CB, then starting the RI to connect, and finally launching the UI, the
Connected Robotspage shows whether the robot is currently connected (should be true) as incompletemarked the checklist item
npx jestshows that all test suites pass (with 93% line coverage in ConnectedRobots.tsx) as incompletemarked the checklist item
npx jestshows that all test suites pass (with 93% line coverage in ConnectedRobots.tsx) as completedmarked the checklist item First starting the CB, then starting the RI to connect, and finally launching the UI, the
Connected Robotspage shows whether the robot is currently connected (should be true) as completedmarked the checklist item AFTER, disconnecting the RI (by Cntr+C or other ways) should result in the page showing the robot is disconnected. as completed
marked the checklist item Then, when reconnecting (using same ports) on RI, it should switch back to connected again. as completed
marked the checklist item Also make sure that when the CB is not correctly setup yet, the page shows its currently
checking...as completedmarked the checklist item
npx eslintdoesn't show any formatting/ style errors or warnings. as completedapproved this merge request
requested review from @8464960 and removed review request for @0950726
requested review from @0950726 and removed review request for @8464960
requested review from @8464960 and removed review request for @0950726
requested review from @0950726 and removed review request for @8464960
assigned to @8464960
assigned to @0950726 and unassigned @8464960
assigned to @8464960 and unassigned @0950726
requested review from @8464960 and removed review request for @0950726
requested review from @0950726 and removed review request for @8464960
assigned to @9828273 and unassigned @8464960
unassigned @9828273
Write as a comment briefly what this function does
Also write here what the boolean represents, that would make the code easier to understand to someone who is not an expert
Great work!
I had some comments about some lack of comments, but someone will go over the entire work to check them this sprint. I think it would be more efficient to approve this now and then add comments later, so that's why I still approve.
Note: as requested by Job, as a second reviewer I only went over the code.
approved this merge request
mentioned in commit
96bd1c697c