pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Added loading/savior behaviour + buttons #24

Merged
8464960 merged 12 commits from feat/save-load-nodes into dev 2025-12-09 14:46:27 +00:00
Conversation 27 Commits 12 Files Changed 7 +277 -3
8464960 commented 2025-11-26 13:18:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This branche contains loading and saving behaviour and their buttons in the UI.
The program is saved locally.

For review please check:

  • In the UI "Editor", create any program with some random nodes, save them and load them after. Check if it functions as expected.
  • Check if it is in line with the UI refactor
  • Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome)

note: the last check is because Firefox and Safari do not support the File System Access API, so the fallback file-input method is used.

ref: N25B-189

This branche contains loading and saving behaviour and their buttons in the UI. The program is saved locally. For review please check: - [x] In the UI "Editor", create any program with some random nodes, save them and load them after. Check if it functions as expected. - [x] Check if it is in line with the UI refactor - [x] Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome) note: the last check is because Firefox and Safari do not support the File System Access API, so the fallback file-input method is used. ref: N25B-189
8464960 commented 2025-11-26 13:18:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @8464960

assigned to @8464960
0950726 commented 2025-11-27 09:37:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @0950726

requested review from @0950726
0950726 commented 2025-11-27 09:58:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 381fdaca - fix: re-render TextField when input changes from parent

Compare with previous version

added 1 commit <ul><li>381fdaca - fix: re-render TextField when input changes from parent</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/24/diffs?diff_id=134589&start_sha=5287cb3bf31072e3004c088559befcfe9085cc4d)
0950726 commented 2025-11-27 10:02:08 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I made a small commit to fix the TextField component. It didn't update when the input changed from a parent. While your functionality works (it changes the underlying data), it didn't show the updated data.

Thought I'd fixed this before, but that might've been in a demo branch that was not merged.

I made a small commit to fix the TextField component. It didn't update when the input changed from a parent. While your functionality works (it changes the underlying data), it didn't show the updated data. Thought I'd fixed this before, but that might've been in a demo branch that was not merged.
0950726 commented 2025-11-27 10:22:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Avoid these direct DOM manipulations in React. This could be a component instead.

Avoid these direct DOM manipulations in React. This could be a component instead.
2584433 commented 2025-12-02 11:57:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

npx Eslint has not been done yet

npx Eslint has not been done yet
2584433 commented 2025-12-02 11:58:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
2584433 commented 2025-12-02 11:58:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • 381fdaca...0ec6f556 - 2 commits from branch dev
  • 3bcc865d - build: merge dev

Compare with previous version

added 3 commits <ul><li>381fdaca...0ec6f556 - 2 commits from branch <code>dev</code></li><li>3bcc865d - build: merge dev</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/24/diffs?diff_id=135024&start_sha=381fdaca1ac91cfb39e6c7fd4a49f93cbf7ca8f8)
2584433 commented 2025-12-02 13:02:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

If this is completed I accept the merge, saving and loading works splendidly

If this is completed I accept the merge, saving and loading works splendidly
8464960 commented 2025-12-04 08:14:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/24/diffs?diff_id=135198&start_sha=3bcc865dd8b0834d3ad223cb52058152cde97df7#2e07aa47cf5087b48a2070c729622f0a5487fd51_64_42)
8464960 commented 2025-12-04 08:14:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 413fb05c - chore: applied feedback from merge request

Compare with previous version

added 1 commit <ul><li>413fb05c - chore: applied feedback from merge request</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/24/diffs?diff_id=135198&start_sha=3bcc865dd8b0834d3ad223cb52058152cde97df7)
8464960 commented 2025-12-04 08:14:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
8464960 commented 2025-12-04 10:05:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 11 commits

  • 413fb05c...608bd546 - 10 commits from branch dev
  • e9ea0fb3 - Merge remote-tracking branch 'origin/dev' into feat/save-load-nodes

Compare with previous version

added 11 commits <ul><li>413fb05c...608bd546 - 10 commits from branch <code>dev</code></li><li>e9ea0fb3 - Merge remote-tracking branch &#39;origin/dev&#39; into feat/save-load-nodes</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/24/diffs?diff_id=135205&start_sha=413fb05cd8f69b5782ebfcc130355c42863f90cb)
0950726 commented 2025-12-04 12:04:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Your changes use React as it's meant to be used, nice!

We can simplify it a bit, getting rid of the complicated resolverRef by using a clickable label around the input element instead of the separate button.

I've implemented that in branch feat/save-load-nodes-direct, could you check it out and merge it into this branch if you agree?

Your changes use React as it's meant to be used, nice! We can simplify it a bit, getting rid of the complicated `resolverRef` by using a clickable `label` around the `input` element instead of the separate `button`. I've implemented that in branch `feat/save-load-nodes-direct`, could you check it out and merge it into this branch if you agree?
0950726 commented 2025-12-04 12:04:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
8464960 commented 2025-12-04 12:41:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 1bfcfc04 - feat: use input element directly

Compare with previous version

added 1 commit <ul><li>1bfcfc04 - feat: use input element directly</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/24/diffs?diff_id=135223&start_sha=e9ea0fb37e62795ab995c147a0a2e7ccb0e27254)
0950726 commented 2025-12-09 12:47:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2025-12-09 13:23:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 5 commits

  • 1bfcfc04...80aa1fca - 4 commits from branch dev
  • 501f56e0 - chore: solve merge conflicts with dev

Compare with previous version

added 5 commits <ul><li>1bfcfc04...80aa1fca - 4 commits from branch <code>dev</code></li><li>501f56e0 - chore: solve merge conflicts with dev</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/24/diffs?diff_id=135596&start_sha=1bfcfc04587b262931c7e4080d0a92760f341a72)
2584433 commented 2025-12-09 14:43:28 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item In the UI "Editor", create any program with some random nodes, save them and load them after. Check if it functions as expected. as completed

marked the checklist item **In the UI "Editor", create any program with some random nodes, save them and load them after. Check if it functions as expected.** as completed
2584433 commented 2025-12-09 14:43:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Check if it is in line with the UI refactor as completed

marked the checklist item **Check if it is in line with the UI refactor** as completed
2584433 commented 2025-12-09 14:43:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome) as completed

marked the checklist item **Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome)** as completed
2584433 commented 2025-12-09 14:43:57 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome) as incomplete

marked the checklist item **Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome)** as incomplete
2584433 commented 2025-12-09 14:46:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome) as completed

marked the checklist item **Preferably check on multiple browswer (firefox or safari) + any other browser (e.g. Chrome)** as completed
2584433 commented 2025-12-09 14:46:23 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
2584433 commented 2025-12-09 14:46:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 647ea1979a

mentioned in commit 647ea1979a48727f4e817e490a8ab2f171365caf
2584433 (Migrated from git.science.uu.nl) merged commit 647ea1979a into dev 2025-12-09 14:46:27 +00:00
0950726 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:16 +00:00
2584433 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
0950726
2584433
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#24
Delete Branch "feat/save-load-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?