pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix deep cloning bug where phases don't have their own children but store references #27

Merged
9828273 merged 12 commits from fix/deep-clone-data into dev 2025-12-09 14:55:47 +00:00
Conversation 28 Commits 12 Files Changed 3 +102 -2
9828273 commented 2025-12-02 13:17:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

We should fix the bug where phases reference the same children array rather than have their own.

To merge this check the following:

  • This branch is up to date with dev
  • npx jest shows that all tests pass (with a 92% code coverage)
  • The new lines follow the correct style (note that older lines still need to be fixed, which should also be done with other merge requests)
  • The bug no longer appears, check this by adding a few phases (other than the one you start with) and assigning norms or goals to them. They should have their own norms or goals when running the program, rather than reference the same.
  • Go over the code lines and check for any weird things that should be different.

ref: N25B-371

We should fix the bug where phases reference the same children array rather than have their own. To merge this check the following: - [x] This branch is up to date with dev - [x] `npx jest` shows that all tests pass (with a 92% code coverage) - [x] The new lines follow the correct style (note that older lines still need to be fixed, which should also be done with other merge requests) - [x] The bug no longer appears, check this by adding a few phases (other than the one you start with) and assigning norms or goals to them. They should have their own norms or goals when running the program, rather than reference the same. - [x] Go over the code lines and check for any weird things that should be different. ref: N25B-371
9828273 commented 2025-12-02 13:17:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @9828273

assigned to @9828273
9828273 commented 2025-12-02 14:06:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • fe13017f...0ec6f556 - 2 commits from branch dev
  • 518045ed - Merge branch 'dev' into fix/deep-clone-data

Compare with previous version

added 3 commits <ul><li>fe13017f...0ec6f556 - 2 commits from branch <code>dev</code></li><li>518045ed - Merge branch &#39;dev&#39; into fix/deep-clone-data</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/27/diffs?diff_id=135041&start_sha=fe13017f2de094cca6b22fc8387ebcde06623e9f)
9828273 commented 2025-12-03 10:28:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • d9faeafe - test: create test for phase node to account for the previous bug.

Compare with previous version

added 1 commit <ul><li>d9faeafe - test: create test for phase node to account for the previous bug.</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/27/diffs?diff_id=135082&start_sha=518045ed1c5a074b793f6ee3b9e6376fd7f38da1)
9828273 commented 2025-12-03 10:29:58 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 5 commits

  • d9faeafe...df255a83 - 4 commits from branch dev
  • f0c25062 - Merge branch 'dev' into fix/deep-clone-data

Compare with previous version

added 5 commits <ul><li>d9faeafe...df255a83 - 4 commits from branch <code>dev</code></li><li>f0c25062 - Merge branch &#39;dev&#39; into fix/deep-clone-data</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/27/diffs?diff_id=135083&start_sha=d9faeafe320800278beedfc2fe4ac288100fc290)
9828273 commented 2025-12-03 10:41:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • c167144b - fix: fix eslint issues, adjust norm test for dev merge

Compare with previous version

added 1 commit <ul><li>c167144b - fix: fix eslint issues, adjust norm test for dev merge</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/27/diffs?diff_id=135088&start_sha=f0c250626f0999af1a0cb3faed83dcdc6797b809)
2584433 commented 2025-12-03 14:52:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

critical bug, nmp run dev ui page shows nothing

critical bug, nmp run dev ui page shows nothing
2584433 commented 2025-12-03 14:52:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
9828273 commented 2025-12-04 11:33:31 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 95397cec - fix: fix the tests by simulating user actions rather than the function, and...

Compare with previous version

added 1 commit <ul><li>95397cec - fix: fix the tests by simulating user actions rather than the function, and...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/27/diffs?diff_id=135215&start_sha=c167144b4d0ae8dcb962b9eb353bc6a254624c0c)
9828273 commented 2025-12-04 11:34:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
2584433 commented 2025-12-07 15:44:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

please make up to date with dev

please make up to date with dev
2584433 commented 2025-12-07 15:44:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
2584433 commented 2025-12-07 15:46:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item npx jest shows that all tests pass (with a 92% code coverage) as completed

marked the checklist item **`npx jest` shows that all tests pass (with a 92% code coverage)** as completed
2584433 commented 2025-12-07 15:46:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The bug no longer appears, check this by adding a few phases (other than the one you start with) and assigning norms or goals to them. They should have their own norms or goals when running the program, rather than reference the same. as completed

marked the checklist item **The bug no longer appears, check this by adding a few phases (other than the one you start with) and assigning norms or goals to them. They should have their own norms or goals when running the program, rather than reference the same.** as completed
2584433 commented 2025-12-07 15:46:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Go over the code lines and check for any weird things that should be different. as completed

marked the checklist item **Go over the code lines and check for any weird things that should be different.** as completed
2584433 commented 2025-12-07 15:47:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The new lines follow the correct style (note that older lines still need to be fixed, which should also be done with other merge requests) as completed

marked the checklist item **The new lines follow the correct style (note that older lines still need to be fixed, which should also be done with other merge requests)** as completed
2584433 commented 2025-12-07 15:47:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This gives a lot of conflicts due to ui-cov tests not being in dev yet. Probs wait for that.
Besides that I approve.

This gives a lot of conflicts due to ui-cov tests not being in dev yet. Probs wait for that. Besides that I approve.
2584433 commented 2025-12-07 15:47:39 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
2584433 commented 2025-12-07 16:07:28 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 11 commits

  • 95397cec...80aa1fca - 10 commits from branch dev
  • ed116807 - Merge branch 'dev' of ssh://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-ui...

Compare with previous version

added 11 commits <ul><li>95397cec...80aa1fca - 10 commits from branch <code>dev</code></li><li>ed116807 - Merge branch &#39;dev&#39; of ssh://git.science.uu.nl/ics/sp/2025/n25b/pepperplus-ui...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/27/diffs?diff_id=135422&start_sha=95397ceccce111af897c0bef6d9ba075fc20d839)
2584433 commented 2025-12-07 16:07:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
2584433 commented 2025-12-07 16:08:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

my bad it's my fault cuz i updated the tests before they were merged with dev

my bad it's my fault cuz i updated the tests before they were merged with dev
2584433 commented 2025-12-07 16:10:02 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item This branch is up to date with dev as completed

marked the checklist item **This branch is up to date with dev** as completed
2584433 commented 2025-12-07 16:10:08 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @2584433

requested review from @2584433
2584433 commented 2025-12-09 13:15:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
8464960 commented 2025-12-09 14:54:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
8464960 commented 2025-12-09 14:54:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2025-12-09 14:55:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 8149d67491

mentioned in commit 8149d67491634611322477a3d492e23e4b328a32
8464960 (Migrated from git.science.uu.nl) merged commit 8149d67491 into dev 2025-12-09 14:55:47 +00:00
2584433 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:16 +00:00
8464960 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
2584433
8464960
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#27
Delete Branch "fix/deep-clone-data"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?