pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: add critical checkbox to the norm node, send it with the program, add test. #29

Merged
9828273 merged 3 commits from feat/norm-critical-checkbox into demo 2025-12-16 13:13:01 +00:00
Conversation 25 Commits 3 Files Changed 4 +67 -1
9828273 commented 2025-12-10 14:41:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

ref: N25B-390

This is a merge to add the checkbox to the norm and send it as part of its data to the CB.
Checklist:

  • Added code makes sense.
  • Checking and unchecking works
  • The run program outputs the correct program, including the new critical boolean.
  • Tests pass (one test added for this behaviour)
  • Eslint passes

Note that this also means adding this part to the CB, which currently doesn't happen. Meaning the program can't be validated untill this change is also reflected on CB. (I will do this on a branch.)

You should probably check this by adding critical: bool to line 16 in program.py in the CB.

ref: N25B-390 This is a merge to add the checkbox to the norm and send it as part of its data to the CB. Checklist: - [x] Added code makes sense. - [x] Checking and unchecking works - [x] The run program outputs the correct program, including the new critical boolean. - [x] Tests pass (one test added for this behaviour) - [x] Eslint passes Note that this also means adding this part to the CB, which currently doesn't happen. Meaning the program can't be validated untill this change is also reflected on CB. (I will do this on a branch.) You should probably check this by adding ` critical: bool` to line 16 in `program.py` in the CB.
9828273 commented 2025-12-10 14:41:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @9828273

assigned to @9828273
9828273 commented 2025-12-10 14:46:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
j.gerla commented 2025-12-11 08:59:38 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @j.gerla

requested review from @j.gerla
j.gerla commented 2025-12-11 09:02:55 +00:00 (Migrated from git.science.uu.nl)
Copy Link

removed review request for @j.gerla

removed review request for @j.gerla
0950726 commented 2025-12-11 09:49:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link
  const setCritical = (value: boolean) => {
```suggestion:-0+0 const setCritical = (value: boolean) => { ```
0950726 commented 2025-12-11 09:49:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link
          onChange={(e) => setCritical(e.target.checked)}
```suggestion:-0+0 onChange={(e) => setCritical(e.target.checked)} ```
0950726 commented 2025-12-11 09:51:15 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Checking and unchecking works as completed

marked the checklist item **Checking and unchecking works** as completed
0950726 commented 2025-12-11 09:51:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The run program outputs the correct program, including the new critical boolean. as completed

marked the checklist item **The run program outputs the correct program, including the new critical boolean.** as completed
0950726 commented 2025-12-11 09:51:23 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Tests pass (one test added for this behaviour) as completed

marked the checklist item **Tests pass (one test added for this behaviour)** as completed
0950726 commented 2025-12-11 09:51:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Eslint passes as completed

marked the checklist item **Eslint passes** as completed
9828273 commented 2025-12-11 09:54:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/29/diffs?diff_id=135752&start_sha=062e9e3f38333edc42e0b064804891fe2f1ec169#767b2f4d71f86a0bbba4bf57a195b25d4d43c3fe_45_45)
9828273 commented 2025-12-11 09:54:37 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • d5480f95 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>d5480f95 - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/29/diffs?diff_id=135752&start_sha=062e9e3f38333edc42e0b064804891fe2f1ec169)
9828273 commented 2025-12-11 09:54:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2025-12-11 09:54:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/29/diffs?diff_id=135753&start_sha=d5480f957b21f228ef5384c7fce85edf4d0ca886#767b2f4d71f86a0bbba4bf57a195b25d4d43c3fe_67_67)
9828273 commented 2025-12-11 09:54:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 62c81186 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>62c81186 - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/29/diffs?diff_id=135753&start_sha=d5480f957b21f228ef5384c7fce85edf4d0ca886)
0950726 commented 2025-12-11 09:58:58 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Added code makes sense. as completed

marked the checklist item **Added code makes sense.** as completed
0950726 commented 2025-12-11 09:59:58 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
0950726 commented 2025-12-11 10:01:31 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
2584433 commented 2025-12-13 14:29:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
2584433 commented 2025-12-13 14:29:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
2584433 commented 2025-12-13 14:35:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I think merging this should be awaited until the other branch in cb is added.
If you have a reason for merging right now you can explain and do so, but if not its just a risk that this might break dev for the whole program

I think merging this should be awaited until the other branch in cb is added. If you have a reason for merging right now you can explain and do so, but if not its just a risk that this might break dev for the whole program
2584433 commented 2025-12-13 14:35:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
8464960 (Migrated from git.science.uu.nl) changed target branch from dev to demo 2025-12-16 13:09:37 +00:00
8464960 (Migrated from git.science.uu.nl) merged commit faaf67138d into demo 2025-12-16 13:13:02 +00:00
8464960 commented 2025-12-16 13:14:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit faaf67138d

mentioned in commit faaf67138dbcca8f0cc898cb9a521b4e8f7c1b25
0950726 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:16 +00:00
2584433 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
2584433
0950726
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#29
Delete Branch "feat/norm-critical-checkbox"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?