pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Create a basic belief node that can be used in further stages to create inferred belief and be inputs for other nodes. #32

Merged
9828273 merged 12 commits from feat/basic-belief-nodes into demo 2026-01-06 14:29:15 +00:00
Conversation 48 Commits 12 Files Changed 8 +1000 -19
9828273 commented 2025-12-15 13:56:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

To check this merge, follow the following checklist:

  • Up to date with demo
  • npx eslint --fix shows no linting errors.
  • `npx jest (--maxWorkers 1) shows all tests pass.
  • Running the webpage shows the new belief node and its basic types, defined in the KB.
  • All the types are correctly formatted and show their own respective input.
  • Note that a belief can be attached to a phase but should never be part of a phase reduce itself. To test the reducing property you can currently go to NodeRegistry.ts and change basic_belief: () => false to true at const NodesInPhase.
  • The added code is correctly documented
  • The added code makes sense

Additional notes: Even though it is not completely in scope of this ticket, it could be said that this ticket should also take care of 'not being able to connect to a phase'. Note that implementing this right now means testing would be way harder. (Until we can use these basic, and later inferred beliefs as inputs to other notes.)

ref: N25B-390

To check this merge, follow the following checklist: - [x] Up to date with demo - [x] `npx eslint --fix` shows no linting errors. - [x] \`npx jest (--maxWorkers 1) shows all tests pass. - [x] Running the webpage shows the new belief node and its basic types, defined in the KB. - [x] All the types are correctly formatted and show their own respective input. - [x] Note that a belief can be attached to a phase but _should never_ be part of a phase reduce itself. To test the reducing property you can currently go to NodeRegistry.ts and change `basic_belief: () => false` to true at `const NodesInPhase`. - [x] The added code is correctly documented - [x] The added code makes sense Additional notes: Even though it is not completely in scope of this ticket, it could be said that this ticket should also take care of 'not being able to connect to a phase'. Note that implementing this right now means testing would be way harder. (Until we can use these basic, and later inferred beliefs as inputs to other notes.) ref: N25B-390
9828273 commented 2025-12-15 13:56:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @9828273

assigned to @9828273
j.gerla commented 2025-12-16 10:04:15 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @j.gerla

requested review from @j.gerla
j.gerla commented 2025-12-16 10:14:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Up to date with dev as completed

marked the checklist item **Up to date with dev** as completed
j.gerla commented 2025-12-16 10:14:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item npx eslint --fix shows no linting errors. as completed

marked the checklist item **`npx eslint --fix` shows no linting errors.** as completed
j.gerla commented 2025-12-16 10:16:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item `npx jest (--maxWorkers 1) shows all tests pass. as completed

marked the checklist item **`npx jest (--maxWorkers 1) shows all tests pass.** as completed
j.gerla commented 2025-12-16 10:17:50 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Running the webpage shows the new belief node and its basic types, defined in the KB. as completed

marked the checklist item **Running the webpage shows the new belief node and its basic types, defined in the KB.** as completed
j.gerla commented 2025-12-16 10:17:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item All the types are correctly formatted and show their own respective input. as completed

marked the checklist item **All the types are correctly formatted and show their own respective input.** as completed
j.gerla commented 2025-12-16 10:20:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Note that a belief can be attached to a phase but should never be part of a phase reduce itself. To test the reducing property you can currently go to NodeRegistry.ts and change basic_belief: () => false to true at const NodesInPhase. as completed

marked the checklist item **Note that a belief can be attached to a phase but _should never_ be part of a phase reduce itself. To test the reducing property you can currently go to NodeRegistry.ts and change `basic_belief: () => false` to true at `const NodesInPhase`.** as completed
j.gerla commented 2025-12-16 10:20:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The added code is correctly documented as completed

marked the checklist item **The added code is correctly documented** as completed
j.gerla commented 2025-12-16 10:20:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The added code makes sense as completed

marked the checklist item **The added code makes sense** as completed
j.gerla commented 2025-12-16 10:25:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

"Object" is a default JavaScript/TypeScript data type. Change the name of the type to something like "DetectedObject" to prevent future issues

"Object" is a default JavaScript/TypeScript data type. Change the name of the type to something like "DetectedObject" to prevent future issues
j.gerla commented 2025-12-16 10:30:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

When you change from a text-input style belief to an emotion (dropdown selection), the reduced belief doesn't show the selected emotion if it is not changed from the initially shown value in the dropdown

When you change from a text-input style belief to an emotion (dropdown selection), the reduced belief doesn't show the selected emotion if it is not changed from the initially shown value in the dropdown
j.gerla commented 2025-12-16 10:31:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

this is not needed, we have a function for every type of connection event

this is not needed, we have a function for every type of connection event
j.gerla commented 2025-12-16 10:33:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request
j.gerla commented 2025-12-16 10:33:28 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request
j.gerla commented 2025-12-16 10:33:37 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request
j.gerla commented 2025-12-16 10:33:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request
j.gerla commented 2025-12-16 10:33:57 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request
j.gerla commented 2025-12-16 10:34:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request
j.gerla commented 2025-12-16 10:36:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request

The critical checkbox is part of a different merge request that isn't merged yet, and shouldn't be added through this request
j.gerla commented 2025-12-16 10:38:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Once comments are resolved and code from a different unmerged merge request is removed from this merge request, it can be considered approved

Once comments are resolved and code from a different unmerged merge request is removed from this merge request, it can be considered approved
j.gerla commented 2025-12-16 10:47:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Up to date with dev as incomplete

marked the checklist item **Up to date with dev** as incomplete
j.gerla commented 2025-12-16 10:47:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

see threads

see threads
j.gerla commented 2025-12-16 10:47:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested changes

requested changes
9828273 commented 2026-01-05 09:20:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in version 4 of the diff
9828273 commented 2026-01-05 09:20:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in version 4 of the diff
9828273 commented 2026-01-05 09:20:19 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in version 4 of the diff
9828273 commented 2026-01-05 09:20:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in version 4 of the diff
9828273 commented 2026-01-05 09:20:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in version 4 of the diff
9828273 commented 2026-01-05 09:20:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in version 4 of the diff
9828273 commented 2026-01-05 09:20:21 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 4 of the diff

changed this line in version 4 of the diff
9828273 commented 2026-01-05 09:20:21 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 6 commits

  • 7925023f...faaf6713 - 5 commits from branch demo
  • b4df868e - Merge branch 'demo' into feat/basic-belief-nodes

Compare with previous version

added 6 commits <ul><li>7925023f...faaf6713 - 5 commits from branch <code>demo</code></li><li>b4df868e - Merge branch &#39;demo&#39; into feat/basic-belief-nodes</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/32/diffs?diff_id=136289&start_sha=7925023f25984f79390a9548340143b600863759)
9828273 commented 2026-01-05 09:23:43 +00:00 (Migrated from git.science.uu.nl)
Copy Link

All of the checkbox threads should be resolved after I re-merged demo into this branch.

All of the checkbox threads should be resolved after I re-merged demo into this branch.
9828273 commented 2026-01-05 09:24:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • bd2ffe62 - chore: remove old connect function from basic belief

Compare with previous version

added 1 commit <ul><li>bd2ffe62 - chore: remove old connect function from basic belief</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/32/diffs?diff_id=136291&start_sha=b4df868e26a72136ad361b7702bf76473dc19094)
9828273 commented 2026-01-05 09:30:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 8f1367ed - chore: emotion dropdown doesnt automatically assign new value

Compare with previous version

added 1 commit <ul><li>8f1367ed - chore: emotion dropdown doesnt automatically assign new value</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/32/diffs?diff_id=136293&start_sha=bd2ffe622f6ed79f6e29042930b85833920d7825)
9828273 commented 2026-01-05 09:34:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/32/diffs?diff_id=136295&start_sha=8f1367ed83ad7983e3561750a82e611aa99ad4ec#ff9ff7665e67e9f3cd259936bdb3120c08fd3d41_35_35)
9828273 commented 2026-01-05 09:34:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 9f26edb6 - chore: dont use object, use detected object.

Compare with previous version

added 1 commit <ul><li>9f26edb6 - chore: dont use object, use detected object.</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/32/diffs?diff_id=136295&start_sha=8f1367ed83ad7983e3561750a82e611aa99ad4ec)
9828273 commented 2026-01-05 09:38:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>01d73b77 - chore: fix one test</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/32/diffs?diff_id=136297&start_sha=9f26edb6ec9ae685f6a0817051f3815c74b60397)
9828273 commented 2026-01-06 09:54:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2026-01-06 10:18:15 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
j.gerla commented 2026-01-06 12:20:39 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Up to date with demo as completed

marked the checklist item **Up to date with demo** as completed
j.gerla commented 2026-01-06 12:20:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
j.gerla commented 2026-01-06 12:20:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2026-01-06 14:27:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
8464960 commented 2026-01-06 14:27:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2026-01-06 14:29:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 9c80391fea

mentioned in commit 9c80391feab3f5b8603a6f7d2feae992edf4cc25
8464960 (Migrated from git.science.uu.nl) merged commit 9c80391fea into demo 2026-01-06 14:29:16 +00:00
j.gerla (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
8464960 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
j.gerla
8464960
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#32
Delete Branch "feat/basic-belief-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?