pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test: added SimpleProgram #37

Closed
2584433 wants to merge 9 commits from feat/simple-program-page into demo
pull from: feat/simple-program-page
merge into: pepperplus:demo
Conversation 22 Commits 9 Files Changed 4 +559 -2
2584433 commented 2026-01-02 20:11:21 +00:00 (Migrated from git.science.uu.nl)
Copy Link

ref: N25B-428

To verify:

  • Style checks pass

  • Pipeline (tests) pass

  • Documentation is up to date

  • Tests are up to date (new code is covered)

  • When you go to editor, make a proper program (with multiple phases) and run program simple program shows up.

  • You see all your nodes and phases with their respective norms and triggers.

  • Go back works and your progress isn't lost

Note: First Justin's global program must be merged/accepted since I build upon that.

ref: N25B-428 To verify: * [x] Style checks pass * [x] Pipeline (tests) pass * [x] Documentation is up to date * [x] Tests are up to date (new code is covered) * [x] When you go to editor, make a proper program (with multiple phases) and run program simple program shows up. * [x] You see all your nodes and phases with their respective norms and triggers. * [x] Go back works and your progress isn't lost Note: First Justin's global program must be merged/accepted since I build upon that.
2584433 commented 2026-01-02 20:11:21 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @2584433

assigned to @2584433
9828273 commented 2026-01-06 10:23:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Style checks pass as completed

marked the checklist item **Style checks pass** as completed
9828273 commented 2026-01-06 10:23:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @9828273

requested review from @9828273
9828273 commented 2026-01-06 10:23:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as completed

marked the checklist item **Pipeline (tests) pass** as completed
9828273 commented 2026-01-06 10:24:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

New tests are not up to date:

'src/pages/SimpleProgram | 22.22 | 0 | 0 | 25.64 |\ SimpleProgram.tsx | 22.22 | 0 | 0 | 25.64 | 14,25-38,59-71,86-98,118,143-174'

shows that only 22% of the new code in SimpleProgram is covered.

New tests are not up to date: `'src/pages/SimpleProgram | 22.22 | 0 | 0 | 25.64 |\ SimpleProgram.tsx | 22.22 | 0 | 0 | 25.64 | 14,25-38,59-71,86-98,118,143-174'` shows that only 22% of the new code in SimpleProgram is covered.
9828273 commented 2026-01-06 10:55:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Please avoid using 'runProgram' followed by a 'runProgramm' (double m) for different functionalities. Please use distinguishing names, corresponding to their functionality.

Please avoid using 'runProgram' followed by a 'runProgramm' (double m) for different functionalities. Please use distinguishing names, corresponding to their functionality.
9828273 commented 2026-01-06 11:00:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Documentation is up to date as completed

marked the checklist item **Documentation is up to date** as completed
9828273 commented 2026-01-06 11:01:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item When you go to editor, make a proper program (with multiple phases) and run program simple program shows up. as completed

marked the checklist item **When you go to editor, make a proper program (with multiple phases) and run program simple program shows up.** as completed
9828273 commented 2026-01-06 11:01:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Go back works and your progress isn't lost as completed

marked the checklist item **Go back works and your progress isn't lost** as completed
9828273 commented 2026-01-06 11:02:08 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item You see all your nodes and phases with their respective norms and triggers. as completed

marked the checklist item **You see all your nodes and phases with their respective norms and triggers.** as completed
9828273 commented 2026-01-06 11:03:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This will need additional work after the conditional norms have been merged. (I can also help with this.)

This will need additional work after the conditional norms have been merged. (I can also help with this.)
j.gerla commented 2026-01-06 13:37:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • 7b05c734...9dae45e3 - 2 commits from branch demo
  • 15c9fc6f - Merge branch 'demo' into 'feat/simple-program-page'

Compare with previous version

added 3 commits <ul><li>7b05c734...9dae45e3 - 2 commits from branch <code>demo</code></li><li>15c9fc6f - Merge branch &#39;demo&#39; into &#39;feat/simple-program-page&#39;</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/37/diffs?diff_id=136339&start_sha=7b05c7344c23f8b0c71b7e6f8811422e969beac4)
j.gerla commented 2026-01-06 13:39:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

so far this would be approved as long as Bjorn's threads are resolved

so far this would be approved as long as Bjorn's threads are resolved
2584433 commented 2026-01-06 14:11:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
2584433 commented 2026-01-06 14:11:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

job code be like

job code be like
2584433 commented 2026-01-06 14:20:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/37/diffs?diff_id=136358&start_sha=15c9fc6f4d0377e647a39ae0d9385eec484bd5c2#f9a16de64e681892ee0aa751c23f0004b0d32c06_186_186)
2584433 commented 2026-01-06 14:20:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 2ecb33dc - chore: now actually runs tests

Compare with previous version

added 1 commit <ul><li>2ecb33dc - chore: now actually runs tests</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/37/diffs?diff_id=136358&start_sha=15c9fc6f4d0377e647a39ae0d9385eec484bd5c2)
9828273 commented 2026-01-07 11:56:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Tests are up to date (new code is covered) as completed

marked the checklist item **Tests are up to date (new code is covered)** as completed
9828273 commented 2026-01-07 11:56:57 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2026-01-07 11:56:57 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
9828273 commented 2026-01-14 18:57:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

unapproved this merge request

unapproved this merge request
9828273 commented 2026-01-14 18:58:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

There's currently some merge conflicts (since this branch is 45 commits behind.) Please fix them or decide to drop this merge request - implementing it through the monitoring-page merge request.

There's currently some merge conflicts (since this branch is 45 commits behind.) Please fix them or decide to drop this merge request - implementing it through the monitoring-page merge request.
2584433 (Migrated from git.science.uu.nl) closed this pull request 2026-01-19 13:42:53 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#37
Delete Branch "feat/simple-program-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?