pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Refactor of visual programming page to fully match the CB's program schema. Includes overhaul of UI elements for plan creation. #38

Merged
9828273 merged 23 commits from refactor/nodes-match-functionality into demo 2026-01-07 15:19:47 +00:00
Conversation 65 Commits 23 Files Changed 33 +2228 -391
9828273 commented 2026-01-05 09:07:58 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This merge revolves around the need to match the updated CB's definition of a program, also granting more functionality and access to the creation of programs.

In order to check this merge, first do the following:

  • On RI, use the branch dev. Make sure it's up to date with the requirements.
  • On CB, use the branch feat/semantic-beliefs. This branch contains the most up-to-date definition of a program, to my knowledge. Make sure to have the UV correctly synced.
  • On UI, use this branch, make sure to npm i.

Check the following list:

  • This branch is up to date with demo.
  • The pipeline succeeds.
  • npx jest (--maxWorkers 1) shows all tests pass. The newly added pages and added functionality should have a coverage of around 87% (all green).
  • npx eslint --fix shows no linting errors.

Now for the functionality. This involves also testing edge cases and any weird interactions:
Open the visual programming page and use the new conditional norm, by adding a belief to a norm. This should:

  • Show whether there is a condition attached in the UI.
  • Correctly show an unique UUID in the ID field when the program is run, in the console.
  • Correctly give only ONE condition whenever the program is run, when attached, in the console.
  • Correctly give the unique ID and either keyword/description/object/emotion as field alongside, in the console.
  • The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the Object found and Emotion recognized beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably).

Open the visual programming page and use the Plan Editing, which is used in both the Goal Node, as well as the Trigger Node.
(Note that steps aren't automatically added whenever a plan is saved, so make sure to press add step before saving the plan.)

  • Creating/ Editing a plan is logical; having a plan shows edit plan everywhere, and without a plan, it shows create plan everywhere.
  • The dialog (the square html element used to create a plan) is clear, it makes sense how it would work without great insight.
  • Selecting the different action types show the correct placeholder and value editor. The speech and llm actions are both strings, whereas the gesture value editor is a different element containing both a searchable single path, and scroll-able/ select-able tag.
  • Pressing 'Add Step' with a value selected/ typed shows this new step on the right hand side. It should mention the type of action and its value.
  • Hovering over the steps on the right shows strikethrough text. Clicking deletes the step from the current plan. This makes sense in this context.
  • Pressing cancel closes the editing of the plan without editing any plan/values.
  • Pressing confirm closes the editing of the plan and saves the edited plan as current plan.
  • Pressing reset closes the editing of the plan and completely resets the current plan- meaning there's no set plan.
  • All the buttons and functionalities make sense.
  • All the buttons, text, and elements both support light and dark mode (please i spent too much time on this).
  • The gesture value editor page is an extra element; make sure it makes sense and doesn't feel iffy.

Open the visual programming page and use the Goal node.

  • In case the name of the goal is defined (e.g. "greet the user"), creating a plan should automatically suggest adding a LLM Action with the title as step when creating a new plan.
  • The goal node should say Will follow plan '<planname>' until goal is met if a goal is set.
  • There should be a line saying Try this plan once with a checkbox, this checkbox should ONLY be changeable whenever there is a LLM Action in the current plan. This change should also be reflected in the output of the program.

Open the visual programming page and use the Trigger node.

  • The trigger node should say whether the condition is set or not.
  • The trigger node should say if/ what plan is currently set.

Finally, check the readability, documentation and structure of the code itself:

  • The added code makes sense.
  • The added code is in the correct file (structure), meaning that there shouldn't be smaller files containing sub-parts of components.
  • The added code is correctly documented and commented.
  • The added code is readable (this is an important one, since I struggled making it as readable as possible in large HTML elements.)

Additional comments:
This is a large merge, please use more people to be certain.
This does not include the functionality of creating a Goal within a Plan. This require more thinking and discussing about its recursive implementation.
This does not include inferred beliefs.

ref: N25B-408

This merge revolves around the need to match the updated CB's definition of a program, also granting more functionality and access to the creation of programs. In order to check this merge, first do the following: - On RI, use the branch `dev`. Make sure it's up to date with the requirements. - On CB, use the branch `feat/semantic-beliefs`. This branch contains the most up-to-date definition of a program, to my knowledge. Make sure to have the UV correctly synced. - On UI, use this branch, make sure to `npm i`. Check the following list: - [x] This branch is up to date with `demo`. - [x] The pipeline succeeds. - [x] `npx jest (--maxWorkers 1)` shows all tests pass. The newly added pages and added functionality should have a coverage of around 87% (all green). - [x] `npx eslint --fix` shows no linting errors. Now for the functionality. This involves also testing edge cases and any weird interactions: Open the visual programming page and use the new `conditional norm`, by adding a belief to a norm. This should: - [x] Show whether there is a condition attached in the UI. - [x] Correctly show an unique UUID in the ID field when the program is run, in the console. - [x] Correctly give only ONE condition whenever the program is run, when attached, in the console. - [x] Correctly give the unique ID and either keyword/description/object/emotion as field alongside, in the console. - [x] The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the `Object found` and `Emotion recognized` beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably). Open the visual programming page and use the `Plan Editing`, which is used in both the `Goal` Node, as well as the `Trigger` Node. (Note that steps aren't automatically added whenever a plan is saved, so make sure to press `add step` before saving the plan.) - [x] Creating/ Editing a plan is logical; having a plan shows `edit plan` everywhere, and without a plan, it shows `create plan` everywhere. - [x] The dialog (the square html element used to create a plan) is clear, it makes sense how it would work without great insight. - [x] Selecting the different action types show the correct placeholder and value editor. The speech and llm actions are both strings, whereas the gesture value editor is a different element containing both a searchable single path, and scroll-able/ select-able tag. - [x] Pressing 'Add Step' with a value selected/ typed shows this new step on the right hand side. It should mention the type of action and its value. - [x] Hovering over the steps on the right shows ~~`strikethrough`~~ text. Clicking deletes the step from the current plan. This makes sense in this context. - [x] Pressing cancel closes the editing of the plan **without** editing any plan/values. - [x] Pressing confirm closes the editing of the plan and saves the edited plan as current plan. - [x] Pressing reset closes the editing of the plan and completely resets the current plan- meaning there's no set plan. - [x] All the buttons and functionalities make sense. - [x] All the buttons, text, and elements both support light and dark mode (please i spent too much time on this). - [x] The gesture value editor page is an extra element; make sure it makes sense and doesn't feel iffy. Open the visual programming page and use the `Goal` node. - [x] In case the name of the goal is defined (e.g. "greet the user"), creating a plan should automatically suggest adding a `LLM Action` with the title as step when creating a new plan. - [x] The goal node should say `Will follow plan '<planname>' until goal is met` if a goal is set. - [x] There should be a line saying `Try this plan once` with a checkbox, this checkbox should ONLY be changeable whenever there is a `LLM Action` in the current plan. This change should also be reflected in the output of the program. Open the visual programming page and use the `Trigger` node. - [x] The trigger node should say whether the condition is set or not. - [x] The trigger node should say if/ what plan is currently set. Finally, check the readability, documentation and structure of the code itself: - [x] The added code makes sense. - [x] The added code is in the correct file (structure), meaning that there shouldn't be smaller files containing sub-parts of components. - [x] The added code is correctly documented and commented. - [x] The added code is readable (this is an important one, since I struggled making it as readable as possible in large HTML elements.) Additional comments: This is a large merge, please use more people to be certain. This does not include the functionality of creating a `Goal` within a `Plan`. This require more thinking and discussing about its recursive implementation. This does not include inferred beliefs. ref: N25B-408
9828273 commented 2026-01-05 09:08:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
9828273 commented 2026-01-05 09:10:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @9828273

assigned to @9828273
9828273 commented 2026-01-05 09:12:48 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
9828273 commented 2026-01-05 09:12:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
k.marinus commented 2026-01-05 09:57:09 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Show whether there is a condition attached in the UI. as completed

marked the checklist item **Show whether there is a condition attached in the UI.** as completed
k.marinus commented 2026-01-05 09:57:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Correctly show an unique UUID in the ID field when the program is run, in the console. as completed

marked the checklist item **Correctly show an unique UUID in the ID field when the program is run, in the console.** as completed
k.marinus commented 2026-01-05 09:57:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Correctly give only ONE condition whenever the program is run, when attached, in the console. as completed

marked the checklist item **Correctly give only ONE condition whenever the program is run, when attached, in the console.** as completed
k.marinus commented 2026-01-05 09:57:24 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Correctly give the unique ID and either keyword/description/object/emotion as field alongside, in the console. as completed

marked the checklist item **Correctly give the unique ID and either keyword/description/object/emotion as field alongside, in the console.** as completed
k.marinus commented 2026-01-05 09:57:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the Object found and Emotion recognized beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably). as completed

marked the checklist item **The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the `Object found` and `Emotion recognized` beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably).** as completed
k.marinus commented 2026-01-05 10:24:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Creating/ Editing a plan is logical; having a plan shows edit plan everywhere, and without a plan, it shows create plan everywhere. as completed

marked the checklist item **Creating/ Editing a plan is logical; having a plan shows `edit plan` everywhere, and without a plan, it shows `create plan` everywhere.** as completed
k.marinus commented 2026-01-05 10:25:39 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The dialog (the square html element used to create a plan) is clear, it makes sense how it would work without great insight. as completed

marked the checklist item **The dialog (the square html element used to create a plan) is clear, it makes sense how it would work without great insight.** as completed
k.marinus commented 2026-01-05 10:27:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the Object found and Emotion recognized beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably). as incomplete

marked the checklist item **The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the `Object found` and `Emotion recognized` beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably).** as incomplete
k.marinus commented 2026-01-05 10:27:57 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Selecting the different action types show the correct placeholder and value editor. The speech and llm actions are both strings, whereas the gesture value editor is a different element containing both a searchable single path, and scroll-able/ select-able tag. as completed

marked the checklist item **Selecting the different action types show the correct placeholder and value editor. The speech and llm actions are both strings, whereas the gesture value editor is a different element containing both a searchable single path, and scroll-able/ select-able tag.** as completed
k.marinus commented 2026-01-05 10:28:02 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pressing 'Add Step' with a value selected/ typed shows this new step on the right hand side. It should mention the type of action and its value. as completed

marked the checklist item **Pressing 'Add Step' with a value selected/ typed shows this new step on the right hand side. It should mention the type of action and its value.** as completed
k.marinus commented 2026-01-05 10:28:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Hovering over the steps on the right shows strikethrough text. Clicking deletes the step from the current plan. This makes sense in this context. as completed

marked the checklist item **Hovering over the steps on the right shows ~~`strikethrough`~~ text. Clicking deletes the step from the current plan. This makes sense in this context.** as completed
k.marinus commented 2026-01-05 10:29:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pressing cancel closes the editing of the plan without editing any plan/values. as completed

marked the checklist item **Pressing cancel closes the editing of the plan **without** editing any plan/values.** as completed
k.marinus commented 2026-01-05 10:30:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pressing confirm closes the editing of the plan and saves the edited plan as current plan. as completed

marked the checklist item **Pressing confirm closes the editing of the plan and saves the edited plan as current plan.** as completed
k.marinus commented 2026-01-05 10:30:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pressing reset closes the editing of the plan and completely resets the current plan- meaning there's no set plan. as completed

marked the checklist item **Pressing reset closes the editing of the plan and completely resets the current plan- meaning there's no set plan.** as completed
k.marinus commented 2026-01-05 10:30:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item All the buttons and functionalities make sense. as completed

marked the checklist item **All the buttons and functionalities make sense.** as completed
k.marinus commented 2026-01-05 10:38:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item All the buttons, text, and elements both support light and dark mode (please i spent too much time on this). as completed

marked the checklist item **All the buttons, text, and elements both support light and dark mode (please i spent too much time on this).** as completed
k.marinus commented 2026-01-05 10:39:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The gesture value editor page is an extra element; make sure it makes sense and doesn't feel iffy. as completed

marked the checklist item **The gesture value editor page is an extra element; make sure it makes sense and doesn't feel iffy.** as completed
k.marinus commented 2026-01-05 10:39:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item In case the name of the goal is defined (e.g. "greet the user"), creating a plan should automatically suggest adding a LLM Action with the title as step when creating a new plan. as completed

marked the checklist item **In case the name of the goal is defined (e.g. "greet the user"), creating a plan should automatically suggest adding a `LLM Action` with the title as step when creating a new plan.** as completed
k.marinus commented 2026-01-05 10:39:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The goal node should say Will follow plan '<planname>' until goal is met if a goal is set. as completed

marked the checklist item **The goal node should say `Will follow plan '<planname>' until goal is met` if a goal is set.** as completed
k.marinus commented 2026-01-05 10:39:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item There should be a line saying Try this plan once with a checkbox, this checkbox should ONLY be changeable whenever there is a LLM Action in the current plan. This change should also be reflected in the output of the program. as completed

marked the checklist item **There should be a line saying `Try this plan once` with a checkbox, this checkbox should ONLY be changeable whenever there is a `LLM Action` in the current plan. This change should also be reflected in the output of the program.** as completed
k.marinus commented 2026-01-05 10:44:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The trigger node should say whether the condition is set or not. as completed

marked the checklist item **The trigger node should say whether the condition is set or not.** as completed
k.marinus commented 2026-01-05 10:44:28 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The trigger node should say if/ what plan is currently set. as completed

marked the checklist item **The trigger node should say if/ what plan is currently set.** as completed
k.marinus commented 2026-01-05 10:45:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Scrolling in de suggested gesture box does not work when using the mouse scroll wheel. Instead, it zooms the visprog page itself in the background.

In a similar vein, dragging my mouse over any part of the plan creation dialog moves the visprog in the background. I came across this when attempting to reorder the steps in a plan, which might be useful to be able to do.

Scrolling in de suggested gesture box does not work when using the mouse scroll wheel. Instead, it zooms the visprog page itself in the background. In a similar vein, dragging my mouse over any part of the plan creation dialog moves the visprog in the background. I came across this when attempting to reorder the steps in a plan, which might be useful to be able to do.
k.marinus commented 2026-01-05 10:45:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Gestures expect a different format in the backend, with a field type and a field name (see CB code).

Gestures expect a different format in the backend, with a field `type` and a field `name` (see CB code).
k.marinus commented 2026-01-05 10:45:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Not for this ticket, but good to note: subgoals are not implemented in this merge request, even though backend supports it. Might be for a future ticket, if time permits, as this would greatly enhance conversational flow (not having to run through entire plans for a single point of failure).

Not for this ticket, but good to note: subgoals are not implemented in this merge request, even though backend supports it. Might be for a future ticket, if time permits, as this would greatly enhance conversational flow (not having to run through entire plans for a single point of failure).
k.marinus commented 2026-01-05 10:45:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
j.gerla commented 2026-01-05 14:53:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 111400bd - fix: fixed scrolling behavior inside editor when plan editor window is opened

Compare with previous version

added 1 commit <ul><li>111400bd - fix: fixed scrolling behavior inside editor when plan editor window is opened</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136308&start_sha=149b82cb66630e3589960a7bad87513f9f04dbbb)
j.gerla commented 2026-01-05 14:59:24 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @j.gerla

requested review from @j.gerla
j.gerla commented 2026-01-05 14:59:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @k.marinus and removed review request for @j.gerla

requested review from @k.marinus and removed review request for @j.gerla
9828273 commented 2026-01-05 15:38:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 216b136a - chore: change goal text, correct output for gestures, allow step specific...

Compare with previous version

added 1 commit <ul><li>216b136a - chore: change goal text, correct output for gestures, allow step specific...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136310&start_sha=111400bd82c5bac56e1015ca7cda4b24f0162ef4)
9828273 commented 2026-01-05 15:39:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
j.gerla commented 2026-01-06 13:09:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The added code makes sense. as completed

marked the checklist item **The added code makes sense.** as completed
j.gerla commented 2026-01-06 13:10:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The added code is in the correct file (structure), meaning that there shouldn't be smaller files containing sub-parts of components. as completed

marked the checklist item **The added code is in the correct file (structure), meaning that there shouldn't be smaller files containing sub-parts of components.** as completed
j.gerla commented 2026-01-06 13:10:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The added code is correctly documented and commented. as completed

marked the checklist item **The added code is correctly documented and commented.** as completed
j.gerla commented 2026-01-06 13:10:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The added code is readable (this is an important one, since I struggled making it as readable as possible in large HTML elements.) as completed

marked the checklist item **The added code is readable (this is an important one, since I struggled making it as readable as possible in large HTML elements.)** as completed
j.gerla commented 2026-01-06 13:11:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The pipeline succeeds. as completed

marked the checklist item **The pipeline succeeds.** as completed
j.gerla commented 2026-01-06 13:14:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item npx jest (--maxWorkers 1) shows all tests pass. The newly added pages and added functionality should have a coverage of around 87% (all green). as completed

marked the checklist item **`npx jest (--maxWorkers 1)` shows all tests pass. The newly added pages and added functionality should have a coverage of around 87% (all green).** as completed
k.marinus commented 2026-01-06 13:14:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Goal names are not sent correctly. I would expect them to use the text field, but instead, their name is something like "Goal Node".

Goal names are not sent correctly. I would expect them to use the text field, but instead, their name is something like "Goal Node".
j.gerla commented 2026-01-06 13:14:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item npx eslint --fix shows no linting errors. as completed

marked the checklist item **`npx eslint --fix` shows no linting errors.** as completed
j.gerla commented 2026-01-06 13:16:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
j.gerla commented 2026-01-06 13:17:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

is approved as long as cb and ri integration is confirmed to be ok, as my install has some minor issues so I don't trust it for verifying correct integration with cb and ri

is approved as long as cb and ri integration is confirmed to be ok, as my install has some minor issues so I don't trust it for verifying correct integration with cb and ri
k.marinus commented 2026-01-06 13:31:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

It is not yet, working with Bjorn to fix it currently

It is not yet, working with Bjorn to fix it currently
9828273 commented 2026-01-06 13:48:02 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 508fa48b - fix: fix the goal node's "can_fail" to have the correct property.

Compare with previous version

added 1 commit <ul><li>508fa48b - fix: fix the goal node&#39;s &quot;can_fail&quot; to have the correct property.</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136345&start_sha=216b136a759e2b1252ce260835c84bde2eb5d2f4)
9828273 commented 2026-01-06 14:29:15 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • f4745c73 - refactor: update the goal node to have a description for plans that need to be...

Compare with previous version

added 1 commit <ul><li>f4745c73 - refactor: update the goal node to have a description for plans that need to be...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136361&start_sha=508fa48be67c4256f79409f7753d0e0ee6cdf923)
9828273 commented 2026-01-06 14:35:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 46c2e0ed - chore: remove belief default text

Compare with previous version

added 1 commit <ul><li>46c2e0ed - chore: remove belief default text</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136366&start_sha=f4745c736f33e75bbda57fcb13649907dad9c5b0)
9828273 commented 2026-01-06 14:37:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 08374ac2 - chore: fix the tests with 2 lines

Compare with previous version

added 1 commit <ul><li>08374ac2 - chore: fix the tests with 2 lines</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136369&start_sha=46c2e0ede633c4c37ba1cdc9d5256b0478b5d83a)
9828273 commented 2026-01-06 14:40:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 0b74763e - chore: diffewrent semantic placeholder

Compare with previous version

added 1 commit <ul><li>0b74763e - chore: diffewrent semantic placeholder</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136371&start_sha=08374ac2c2481463b90b9beade5caeacf62773bd)
9828273 commented 2026-01-06 14:51:37 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 9 commits

  • 0b74763e...9c80391f - 8 commits from branch demo
  • 381cb0c8 - Merge branch 'demo' into refactor/nodes-match-functionality

Compare with previous version

added 9 commits <ul><li>0b74763e...9c80391f - 8 commits from branch <code>demo</code></li><li>381cb0c8 - Merge branch &#39;demo&#39; into refactor/nodes-match-functionality</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136375&start_sha=0b74763e2405a9d647c168224d59bdce115660a9)
9828273 commented 2026-01-06 15:28:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • c13fb7d3 - refactor: change the belief nodes to include a description part

Compare with previous version

added 1 commit <ul><li>c13fb7d3 - refactor: change the belief nodes to include a description part</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136381&start_sha=381cb0c82292add6cdffe249a4288e5308b538e0)
9828273 commented 2026-01-06 15:30:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2026-01-07 12:16:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 6 commits

  • c13fb7d3...6d1c17e7 - 4 commits from branch demo
  • e6b0d756 - Merge branch 'demo' into refactor/nodes-match-functionality
  • d2d4dc12 - fix: small fixes for merge

Compare with previous version

added 6 commits <ul><li>c13fb7d3...6d1c17e7 - 4 commits from branch <code>demo</code></li><li>e6b0d756 - Merge branch &#39;demo&#39; into refactor/nodes-match-functionality</li><li>d2d4dc12 - fix: small fixes for merge</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136408&start_sha=c13fb7d33deed08592c1f8193a187853daedd3ab)
9828273 commented 2026-01-07 14:15:23 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • d2d4dc12...bd079a41 - 2 commits from branch demo
  • 442df423 - Merge branch 'demo' into refactor/nodes-match-functionality

Compare with previous version

added 3 commits <ul><li>d2d4dc12...bd079a41 - 2 commits from branch <code>demo</code></li><li>442df423 - Merge branch &#39;demo&#39; into refactor/nodes-match-functionality</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136424&start_sha=d2d4dc124249ab0ce65d8aa05ee06ea30d64a986)
9828273 commented 2026-01-07 14:27:21 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 4e07b957 - chore: fix specific (new) handles

Compare with previous version

added 1 commit <ul><li>4e07b957 - chore: fix specific (new) handles</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136426&start_sha=442df423d1abd909457acb0a382f3fb98b1489e7)
j.gerla commented 2026-01-07 14:43:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item This branch is up to date with demo. as completed

marked the checklist item **This branch is up to date with `demo`.** as completed
9828273 commented 2026-01-07 14:50:50 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>35ab95bd - chore: correct reducing</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/38/diffs?diff_id=136428&start_sha=4e07b9572286641f48735a90450915d41ad2032e)
k.marinus commented 2026-01-07 15:19:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the Object found and Emotion recognized beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably). as completed

marked the checklist item **The outputted program is correctly parsed into the CB (VERY IMPORTANT). Note that the `Object found` and `Emotion recognized` beliefs are NOT part of the current CB schema. We still test whether it works in the UI, but will disable them for the demo (probably).** as completed
k.marinus commented 2026-01-07 15:19:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
k.marinus commented 2026-01-07 15:19:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
k.marinus commented 2026-01-07 15:19:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 5385bd72b1

mentioned in commit 5385bd72b1cc3620407f52109d9d8925451e20cb
k.marinus (Migrated from git.science.uu.nl) merged commit 5385bd72b1 into demo 2026-01-07 15:19:47 +00:00
j.gerla (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
k.marinus (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
k.marinus
j.gerla
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#38
Delete Branch "refactor/nodes-match-functionality"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?