pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Adding goal nodes automatically adds them to the plan, and correctly reduces them #40

Merged
9828273 merged 9 commits from feat/recursive-goal-making into demo 2026-01-19 14:00:06 +00:00
Conversation 37 Commits 9 Files Changed 14 +544 -95
9828273 commented 2026-01-08 10:41:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Adding goal nodes automatically adds them to the plan, and correctly reduces them

Check the following:

  • npx eslint --fix shows no errors.
  • npx jest (--maxWorkers 1) shows all tests pass.

When starting the program and going to the website:

  • Having a goal node connect to another goal or trigger node that IS EMPTY will automatically create a new plan with the goal inside.
  • Having a goal node connect to another goal or trigger node with an EXISTING plan will automatically add this plan to the bottom
  • The name of the plan is referenced dynamically inside the plan. (Editing the name of the other goal node will change it in the plan)
  • When reducing the program using Run program, the console shows the correct format, and will be parsed correctly on CB (latest version of program schema).
  • Goal nodes still function as expected
  • Trigger nodes have both a handle for beliefs, which can only accept ONE belief, and a handle for MULTIPLE goals, which can only accept goal, and multiple.
Adding goal nodes automatically adds them to the plan, and correctly reduces them Check the following: - [x] `npx eslint --fix` shows no errors. - [x] `npx jest (--maxWorkers 1)` shows all tests pass. When starting the program and going to the website: - [x] Having a goal node connect to another goal or trigger node that IS EMPTY will automatically create a new plan with the goal inside. - [x] Having a goal node connect to another goal or trigger node with an EXISTING plan will automatically add this plan to the bottom - [x] The name of the plan is referenced dynamically inside the plan. (Editing the name of the other goal node will change it in the plan) - [x] When reducing the program using `Run program`, the console shows the correct format, and will be parsed correctly on CB (latest version of program schema). - [x] Goal nodes still function as expected - [x] Trigger nodes have both a handle for beliefs, which can only accept ONE belief, and a handle for MULTIPLE goals, which can only accept goal, and multiple.
9828273 commented 2026-01-08 10:41:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @9828273

assigned to @9828273
k.marinus commented 2026-01-08 10:53:03 +00:00 (Migrated from git.science.uu.nl)
Copy Link

When creating a goal and adding the suggested step, if I then remove that step, the text "added as a suggestion..." appears again, without an actual suggestion appearing.

When creating a goal and adding the suggested step, if I then remove that step, the text "added as a suggestion..." appears again, without an actual suggestion appearing.
9828273 commented 2026-01-08 11:16:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2026-01-08 11:31:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • c7ed3c8e - feat: added correct showing of goals with the description and can_fail

Compare with previous version

added 1 commit <ul><li>c7ed3c8e - feat: added correct showing of goals with the description and can_fail</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/40/diffs?diff_id=136464&start_sha=e6f29a0f6bffae571b02947f042939b547c31000)
9828273 commented 2026-01-08 13:11:57 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 96afba2a - chore: add name field to trigger nodes

Compare with previous version

added 1 commit <ul><li>96afba2a - chore: add name field to trigger nodes</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/40/diffs?diff_id=136475&start_sha=c7ed3c8ef2043fd7e2a6b9f7534514f6c88dcfee)
9828273 commented 2026-01-08 13:38:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • a5a345b9 - test: add tests for goal and triggers

Compare with previous version

added 1 commit <ul><li>a5a345b9 - test: add tests for goal and triggers</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/40/diffs?diff_id=136477&start_sha=96afba2a1de7ce345d56c117b78d30fcf0d4b639)
j.gerla commented 2026-01-09 15:28:53 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @j.gerla

requested review from @j.gerla
j.gerla commented 2026-01-09 15:29:39 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item npx eslint --fix shows no errors. as completed

marked the checklist item **npx eslint \-\-fix shows no errors\.** as completed
j.gerla commented 2026-01-09 15:31:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item npx jest (--maxWorkers 1) shows all tests pass. as completed

marked the checklist item **npx jest \(\-\-maxWorkers 1\) shows all tests pass\.** as completed
j.gerla commented 2026-01-09 15:32:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Having a goal node connect to another goal or trigger node that IS EMPTY will automatically create a new plan with the goal inside. as completed

marked the checklist item **Having a goal node connect to another goal or trigger node that IS EMPTY will automatically create a new plan with the goal inside\.** as completed
j.gerla commented 2026-01-09 15:35:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

If I disconnect the goal node when only that goal was connected the plan in the parent goal node is not reset and the goal node indicates that there is a plan set, whilst the plan in the editor is empty, don't know if this is intentional or expected behavior, but if not please fix it

If I disconnect the goal node when only that goal was connected the plan in the parent goal node is not reset and the goal node indicates that there is a plan set, whilst the plan in the editor is empty, don't know if this is intentional or expected behavior, but if not please fix it
j.gerla commented 2026-01-09 15:37:35 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Having a goal node connect to another goal or trigger node with an EXISTING plan will automatically add this plan to the bottom as completed

marked the checklist item **Having a goal node connect to another goal or trigger node with an EXISTING plan will automatically add this plan to the bottom** as completed
j.gerla commented 2026-01-09 15:38:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The name of the plan is referenced dynamically inside the plan. (Editing the name of the other goal node will change it in the plan) as completed

marked the checklist item **The name of the plan is referenced dynamically inside the plan\. \(Editing the name of the other goal node will change it in the plan\)** as completed
j.gerla commented 2026-01-09 15:38:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item When reducing the program using Run program, the console shows the correct format, and will be parsed correctly on CB (latest version of program schema). as completed

marked the checklist item **When reducing the program using Run program, the console shows the correct format, and will be parsed correctly on CB \(latest version of program schema\)\.** as completed
j.gerla commented 2026-01-09 15:38:50 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Goal nodes still function as expected as completed

marked the checklist item **Goal nodes still function as expected** as completed
j.gerla commented 2026-01-09 15:44:24 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I can connect a belief node to the goal handle of a trigger node, by dragging a connection from the goal handle to the belief, this should be easy to fix by changing this to make use of the allowOnlyConnectionsFromHandle rule, to make sure it only allows connections to specific handles if any of its potential targets have multiple target handles

I can connect a belief node to the goal handle of a trigger node, by dragging a connection from the goal handle to the belief, this should be easy to fix by changing this to make use of the allowOnlyConnectionsFromHandle rule, to make sure it only allows connections to specific handles if any of its potential targets have multiple target handles
j.gerla commented 2026-01-09 15:46:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

make sure third party imports are on top to adhere to code standards

make sure third party imports are on top to adhere to code standards
j.gerla commented 2026-01-09 15:49:10 +00:00 (Migrated from git.science.uu.nl)
Copy Link

please do fix before merging if not fixed yet

please do fix before merging if not fixed yet
j.gerla commented 2026-01-09 15:50:37 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Once the open threads are resolved I will approve this for merging

Once the open threads are resolved I will approve this for merging
9828273 commented 2026-01-10 10:17:15 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Thanks for spotting that:)

Thanks for spotting that:)
9828273 commented 2026-01-10 10:24:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Thanks for pointing that out, I've made it so that deleting a final step through disconnecting a goal will now show there is no plan set.

Note that if researcher would like, though, they currently can create a plan without any steps- Though we could also reconsider that behavior in the future.

Thanks for pointing that out, I've made it so that deleting a final step through disconnecting a goal will now show there is no plan set. Note that if researcher would like, though, they currently _can_ create a plan without any steps- Though we could also reconsider that behavior in the future.
9828273 commented 2026-01-10 10:26:31 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/40/diffs?diff_id=136538&start_sha=a5a345b9a94c241ae712f8c20aa2970832e86131#ff9ff7665e67e9f3cd259936bdb3120c08fd3d41_188_188)
9828273 commented 2026-01-10 10:26:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/40/diffs?diff_id=136538&start_sha=a5a345b9a94c241ae712f8c20aa2970832e86131#c287a13007535b0f2753eef97de4530ab031bde7_500_496)
9828273 commented 2026-01-10 10:26:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 8ffc919e - fix: added a missing test, corrected the imports, added behavior for...

Compare with previous version

added 1 commit <ul><li>8ffc919e - fix: added a missing test, corrected the imports, added behavior for...</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/40/diffs?diff_id=136538&start_sha=a5a345b9a94c241ae712f8c20aa2970832e86131)
9828273 commented 2026-01-12 10:47:39 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2026-01-13 11:34:05 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 4 commits

  • 8ffc919e...3f7e196b - 3 commits from branch demo
  • e1257bdf - Merge branch 'demo' into feat/recursive-goal-making

Compare with previous version

added 4 commits <ul><li>8ffc919e...3f7e196b - 3 commits from branch <code>demo</code></li><li>e1257bdf - Merge branch &#39;demo&#39; into feat/recursive-goal-making</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/40/diffs?diff_id=136681&start_sha=8ffc919e7ee60cd9bdf63b20318368355cbf32b8)
j.gerla commented 2026-01-14 10:14:38 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Trigger nodes have both a handle for beliefs, which can only accept ONE belief, and a handle for MULTIPLE goals, which can only accept goal, and multiple. as completed

marked the checklist item **Trigger nodes have both a handle for beliefs, which can only accept ONE belief, and a handle for MULTIPLE goals, which can only accept goal, and multiple\.** as completed
k.marinus commented 2026-01-14 18:40:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
k.marinus commented 2026-01-14 18:40:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
j.gerla commented 2026-01-19 13:55:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
j.gerla commented 2026-01-19 13:55:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2026-01-19 13:59:53 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
8464960 commented 2026-01-19 14:00:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2026-01-19 14:00:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 8c28dd6c1c

mentioned in commit 8c28dd6c1c112a0de963d75b3f6218580d31fd44
8464960 (Migrated from git.science.uu.nl) merged commit 8c28dd6c1c into demo 2026-01-19 14:00:06 +00:00
k.marinus (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
j.gerla (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
8464960 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
k.marinus
j.gerla
8464960
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#40
Delete Branch "feat/recursive-goal-making"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?