pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Monitoring page #41

Closed
8464960 wants to merge 59 commits from feat/monitoringpage into demo
pull from: feat/monitoringpage
merge into: pepperplus:demo
Conversation 31 Commits 59 Files Changed 31 +3159 -68
8464960 commented 2026-01-13 10:09:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

To test, use for cb: feat/reset-experiment-and-phase

!You can access the monitoring page by creating a valid program and run the program.

These are the functionalities included, test them out as much as you can:

  • Forced speech (preset sentences and user input)
  • Forced gestures
  • overrides of triggers/conditional norms/goals
  • Pause functionality
  • Phase transition (happens after goal is completed in a phase)
  • End screen (transitiong past the final phase)
  • Reset experiment/skip phase

Notes to keep in mind while testing:

  • Skip phase is currently not implemented

For review, please:

  • Run 'npx jest' to verify tests and coverage
  • Run 'npx eslint --fix'
  • Test all new features
To test, use for cb: feat/reset-experiment-and-phase !You can access the monitoring page by creating a valid program and run the program. These are the functionalities included, test them out as much as you can: * Forced speech (preset sentences and user input) * Forced gestures * overrides of triggers/conditional norms/goals * Pause functionality * Phase transition (happens after goal is completed in a phase) * End screen (transitiong past the final phase) * Reset experiment/skip phase Notes to keep in mind while testing: * Skip phase is currently not implemented For review, please: * [ ] Run 'npx jest' to verify tests and coverage * [ ] Run 'npx eslint --fix' * [ ] Test all new features
8464960 commented 2026-01-13 10:09:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @8464960

assigned to @8464960
9828273 commented 2026-01-13 10:13:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Don't forget to check the npx eslint (--fix).

Currently there are 8 errors, and 7 warnings. Of course, assuring functionality is more important than the style problems; but I will include some suggested changes to fix some.

Don't forget to check the `npx eslint (--fix)`. Currently there are 8 errors, and 7 warnings. Of course, assuring functionality is more important than the style problems; but I will include some suggested changes to fix some.
9828273 commented 2026-01-13 10:25:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Fixing the import errors:

  • Wrong import in components.ts
  • Wrong imports in MonitoringPage.tsx

Should help fix all tests except one.
You changed the definition and exporting of the Counter component in src/components/components.tsx , so make sure the test is also updated accordingly

Fixing the import errors: - Wrong import in components.ts - Wrong imports in MonitoringPage.tsx Should help fix all tests except one. You changed the definition and exporting of the `Counter` component in `src/components/components.tsx` , so make sure the test is also updated accordingly
9828273 commented 2026-01-13 10:35:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link
import React from 'react';
```suggestion:-0+0 import React from 'react'; ```
9828273 commented 2026-01-13 10:35:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link
```suggestion:-1+0 ```
9828273 commented 2026-01-13 10:35:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This is fine for now, however this is now hardcoded, as well as defined in the function itself. Consider changing this when merging in dev, later.

This is fine for now, however this is now hardcoded, as well as defined in the function itself. Consider changing this when merging in dev, later.
9828273 commented 2026-01-13 10:35:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

This is fine for now, however this is now hardcoded, as well as defined in the function itself. Consider changing this when merging in dev, later.

This is fine for now, however this is now hardcoded, as well as defined in the function itself. Consider changing this when merging in dev, later.
9828273 commented 2026-01-13 10:35:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

left review comments

left review comments
9828273 commented 2026-01-13 10:42:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136668&start_sha=f95b1148d9e930144b8c211f45bd5f5046850a29#b3f9eaf7db84cf3811e45b1f2b36c254930b9f20_1_1)
9828273 commented 2026-01-13 10:42:01 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136668&start_sha=f95b1148d9e930144b8c211f45bd5f5046850a29#b3f9eaf7db84cf3811e45b1f2b36c254930b9f20_8_7)
9828273 commented 2026-01-13 10:42:02 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>bac94d5f - chore: remove unused imports</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136668&start_sha=f95b1148d9e930144b8c211f45bd5f5046850a29)
9828273 commented 2026-01-13 10:43:27 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 79d889c1 - chore: revert components page, fixing the test

Compare with previous version

added 1 commit <ul><li>79d889c1 - chore: revert components page, fixing the test</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136672&start_sha=bac94d5f8c385bd4fb04709e76688b5777018ae9)
9828273 commented 2026-01-13 11:08:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 108fdeee - chore: gptd data typing and tests fixing

Compare with previous version

added 1 commit <ul><li>108fdeee - chore: gptd data typing and tests fixing</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136674&start_sha=79d889c10ebfa80353c45296d529fae1d0d5a4b5)
s.o.h.luijkx commented 2026-01-13 11:39:56 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 5 commits

  • 108fdeee...3f7e196b - 3 commits from branch demo
  • 1e951968 - Merge remote-tracking branch 'origin/demo' into feat/monitoringpage
  • 5e245a00 - chore: remove useState import

Compare with previous version

added 5 commits <ul><li>108fdeee...3f7e196b - 3 commits from branch <code>demo</code></li><li>1e951968 - Merge remote-tracking branch &#39;origin/demo&#39; into feat/monitoringpage</li><li>5e245a00 - chore: remove useState import</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136684&start_sha=108fdeeedcd15fb09b6e9c0b964b3e88d07406ba)
8464960 commented 2026-01-15 08:05:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 7d00f359 - feat: made unachieve norm possible

Compare with previous version

added 1 commit <ul><li>7d00f359 - feat: made unachieve norm possible</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136810&start_sha=5e245a00daed41d576f83cd29f12dfa5ee48464a)
8464960 commented 2026-01-15 08:25:37 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 714ee34b - refactor: move all ZMQ to API

Compare with previous version

added 1 commit <ul><li>714ee34b - refactor: move all ZMQ to API</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136811&start_sha=7d00f35990bcbc617edb467b1a8d48a96d9147ab)
8464960 commented 2026-01-15 08:27:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136812&start_sha=714ee34bbe05c9d7f7d9f0717edc5b58a0ebee70#e90cc8a25b2cb69afed65e5550c75e3bcfebfeff_14_0)
8464960 commented 2026-01-15 08:27:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136812&start_sha=714ee34bbe05c9d7f7d9f0717edc5b58a0ebee70#e90cc8a25b2cb69afed65e5550c75e3bcfebfeff_40_0)
8464960 commented 2026-01-15 08:27:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • a98a87f8 - refactor: renamed Components.tsx

Compare with previous version

added 1 commit <ul><li>a98a87f8 - refactor: renamed Components.tsx</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136812&start_sha=714ee34bbe05c9d7f7d9f0717edc5b58a0ebee70)
8464960 commented 2026-01-16 11:58:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • c4e3ab27 - chore: among other things, fixed connection issue

Compare with previous version

added 1 commit <ul><li>c4e3ab27 - chore: among other things, fixed connection issue</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136871&start_sha=a98a87f8cea23afa91378802df3f2cd8e8637a8c)
8464960 commented 2026-01-16 13:25:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • d8cae9f8 - feat: added reset experiment (in UI)

Compare with previous version

added 1 commit <ul><li>d8cae9f8 - feat: added reset experiment (in UI)</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136879&start_sha=c4e3ab27b28a8ae9bdf20f04cd8e5dd0efe86278)
8464960 commented 2026-01-16 14:39:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 11 commits

  • 0a4940bd - 1 earlier commit
  • b869f7c0 - feat: added reduce and connection logic
  • f8acdda0 - feat: added rule to prevent cyclical connections between inferred belief nodes
  • 2d9f430a - style: cleaned up code for InferredBeliefNode.tsx
  • f8f0f121 - style: added documentation to the InferredBelief Node
  • 3d6e065d - feat: added rule to prevent one belief being connected to both inferredBelief inputs
  • 1f0237ba - refactor: moved the nobeliefCyclerule into BeliefGlobals, and fixed function and filenaming
  • 1bec74a0 - test: wrote tests for inferred Belief node
  • 33f520d3 - Merge branch 'demo' into feat/add-inferred-belief-node
  • f99ad7ad - feat: added tooltip and patched potential breaking point in mode toggle for the new node
  • 45ef5a35 - Merge remote-tracking branch 'origin/feat/add-inferred-belief-node' into feat/monitoringpage

Compare with previous version

added 11 commits <ul><li>0a4940bd - 1 earlier commit</li><li>b869f7c0 - feat: added reduce and connection logic</li><li>f8acdda0 - feat: added rule to prevent cyclical connections between inferred belief nodes</li><li>2d9f430a - style: cleaned up code for InferredBeliefNode.tsx</li><li>f8f0f121 - style: added documentation to the InferredBelief Node</li><li>3d6e065d - feat: added rule to prevent one belief being connected to both inferredBelief inputs</li><li>1f0237ba - refactor: moved the nobeliefCyclerule into BeliefGlobals, and fixed function and filenaming</li><li>1bec74a0 - test: wrote tests for inferred Belief node</li><li>33f520d3 - Merge branch &#39;demo&#39; into feat/add-inferred-belief-node</li><li>f99ad7ad - feat: added tooltip and patched potential breaking point in mode toggle for the new node</li><li>45ef5a35 - Merge remote-tracking branch &#39;origin/feat/add-inferred-belief-node&#39; into feat/monitoringpage</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136891&start_sha=d8cae9f838ead68440f2560ad25dc85e806e98a7)
8464960 commented 2026-01-17 15:12:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ab383d77 - chore: fixed some tests</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136972&start_sha=45ef5a353c2e34049c5bde6e06eaf1123e821108)
2584433 commented 2026-01-17 15:13:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>2aede38e - feat: 10 basic gestures</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=136973&start_sha=ab383d77c483fc95dbd23bac99ec6eb422dc504c)
8464960 commented 2026-01-18 11:40:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 2 commits

  • cada85e2 - chore: added tests for monitoringpage
  • 0a243851 - Merge branch 'feat/monitoringpage-pim' into feat/monitoringpage

Compare with previous version

added 2 commits <ul><li>cada85e2 - chore: added tests for monitoringpage</li><li>0a243851 - Merge branch &#39;feat/monitoringpage-pim&#39; into feat/monitoringpage</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=137006&start_sha=2aede38e4d1c12fc7cca88a1bd24bd22fe999e9d)
8464960 commented 2026-01-18 11:49:30 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>2c4f24fb - chore: gesture test updated</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=137007&start_sha=0a243851b1ce6fb632503a09615fe3910919cb5c)
8464960 commented 2026-01-18 11:53:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Yes, good point, should be changed once Job's gestures are merged!

Yes, good point, should be changed once Job's gestures are merged!
8464960 commented 2026-01-18 11:55:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

For this one I think it's not bad to have it hardcoded as we just want to present the researcher with a few common sentences, but maybe I misunderstood the idea here.

For this one I think it's not bad to have it hardcoded as we just want to present the researcher with a few common sentences, but maybe I misunderstood the idea here.
8464960 commented 2026-01-18 12:00:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
8464960 commented 2026-01-18 12:00:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Run 'npx eslint --fix' as incomplete

marked the checklist item **Run 'npx eslint \-\-fix'** as incomplete
8464960 commented 2026-01-19 14:03:38 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 3 commits

  • 2c4f24fb...8c28dd6c - 2 commits from branch demo
  • 470140eb - Merge branch 'demo' into feat/monitoringpage

Compare with previous version

added 3 commits <ul><li>2c4f24fb...8c28dd6c - 2 commits from branch <code>demo</code></li><li>470140eb - Merge branch &#39;demo&#39; into feat/monitoringpage</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/41/diffs?diff_id=137090&start_sha=2c4f24fbb6aa35bcf279bec4544ce93fe500ebab)
8464960 (Migrated from git.science.uu.nl) closed this pull request 2026-01-22 10:07:13 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#41
Delete Branch "feat/monitoringpage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?