pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: added an inferred belief node to the editor #42

Merged
j.gerla merged 13 commits from feat/add-inferred-belief-node into dev 2026-01-23 12:57:36 +00:00
Conversation 24 Commits 13 Files Changed 17 +847 -30
j.gerla commented 2026-01-14 13:03:51 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Added an inferred belief node to the editor,

It has an AND and an OR mode for inference.

to test:

  • Run 'npx jest' to verify tests and coverage
  • Run 'npx eslint --fix'
  • Run 'npx vite' and verify that the node behaves as expected in the editor:
    • Only beliefs and other inferred beliefs can connect to the inputs of an inferred belief node
    • Inferred beliefs cannot be connected in a way that causes a loop to be created
    • You cannot connect the same belief to both inputs of an inferred belief
    • You can toggle the node between and and or mode
  • It is properly reduced, sent to, and then parsed by the CB

ref: N25B-433

Added an inferred belief node to the editor, It has an AND and an OR mode for inference. to test: * [x] Run 'npx jest' to verify tests and coverage * [x] Run 'npx eslint --fix' * [x] Run 'npx vite' and verify that the node behaves as expected in the editor: * [x] Only beliefs and other inferred beliefs can connect to the inputs of an inferred belief node * [x] Inferred beliefs cannot be connected in a way that causes a loop to be created * [x] You cannot connect the same belief to both inputs of an inferred belief * [x] You can toggle the node between and and or mode * [x] It is properly reduced, sent to, and then parsed by the CB ref: N25B-433
j.gerla commented 2026-01-14 13:06:00 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @j.gerla

assigned to @j.gerla
9828273 commented 2026-01-14 18:40:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested review from @9828273

requested review from @9828273
9828273 commented 2026-01-14 18:45:59 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Run 'npx jest' to verify tests and coverage as completed

marked the checklist item **Run 'npx jest' to verify tests and coverage** as completed
9828273 commented 2026-01-14 18:46:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Run 'npx eslint --fix' as completed

marked the checklist item **Run 'npx eslint \-\-fix'** as completed
9828273 commented 2026-01-14 18:48:34 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Run 'npx vite' and verify that the node behaves as expected in the editor: as completed

marked the checklist item **Run 'npx vite' and verify that the node behaves as expected in the editor:** as completed
9828273 commented 2026-01-14 18:48:35 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Only beliefs and other inferred beliefs can connect to the inputs of an inferred belief node as completed

marked the checklist item **Only beliefs and other inferred beliefs can connect to the inputs of an inferred belief node** as completed
9828273 commented 2026-01-14 18:50:22 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item You can toggle the node between and and or mode as completed

marked the checklist item **You can toggle the node between and and or mode** as completed
9828273 commented 2026-01-14 18:53:12 +00:00 (Migrated from git.science.uu.nl)
Copy Link

There's currently a bug that sometimes allows both the creation of a loop, and the connection of the same belief to both inputs-

After the (inferred) belief has a valid connection, you can drag the end of this connection to whatever end you'd like.

Note that this is most likely a bug that has made it into the UI prior to this merge request.
However, it might be a good idea to fix it. (In a different branch, if needed.)

There's currently a bug that sometimes allows both the creation of a loop, and the connection of the same belief to both inputs- After the (inferred) belief has a valid connection, you can drag the end of this connection to whatever end you'd like. Note that this is most likely a bug that has made it into the UI prior to this merge request. However, it might be a good idea to fix it. (In a different branch, if needed.)
9828273 commented 2026-01-14 18:54:38 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item It is properly reduced, sent to, and then parsed by the CB as completed

marked the checklist item **It is properly reduced, sent to, and then parsed by the CB** as completed
j.gerla commented 2026-01-19 16:13:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 0ba02609 - fix: fixed reconnect being able to circumvent connection rules

Compare with previous version

added 1 commit <ul><li>0ba02609 - fix: fixed reconnect being able to circumvent connection rules</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/42/diffs?diff_id=137109&start_sha=f99ad7ad2e5c304f58fd3416885431d9cba16bb7)
j.gerla commented 2026-01-19 16:20:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 11 commits

  • 0ba02609...8c28dd6c - 10 commits from branch demo
  • 7c9c0e15 - Merge branch 'demo' into feat/add-inferred-belief-node

Compare with previous version

added 11 commits <ul><li>0ba02609...8c28dd6c - 10 commits from branch <code>demo</code></li><li>7c9c0e15 - Merge branch &#39;demo&#39; into feat/add-inferred-belief-node</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/42/diffs?diff_id=137110&start_sha=0ba026092d83e3979de59b282565e120ca64578a)
j.gerla commented 2026-01-19 16:20:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

The bug is now fixed

The bug is now fixed
j.gerla commented 2026-01-19 16:20:47 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
j.gerla (Migrated from git.science.uu.nl) changed target branch from demo to dev 2026-01-20 11:12:24 +00:00
j.gerla commented 2026-01-22 11:19:38 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • d83791f0 - feat: changed drag drop name of inferredBelief

Compare with previous version

added 1 commit <ul><li>d83791f0 - feat: changed drag drop name of inferredBelief</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/42/diffs?diff_id=137415&start_sha=7c9c0e1581993bc7eefde99111746cca8538d88d)
j.gerla commented 2026-01-22 16:15:23 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Inferred beliefs cannot be connected in a way that causes a loop to be created as completed

marked the checklist item **Inferred beliefs cannot be connected in a way that causes a loop to be created** as completed
j.gerla commented 2026-01-22 16:15:24 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item You cannot connect the same belief to both inputs of an inferred belief as completed

marked the checklist item **You cannot connect the same belief to both inputs of an inferred belief** as completed
9828273 commented 2026-01-23 10:04:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Currently, the Tooltip just makes use of the type (not the label), so the belief ends up showing "basic_belief" and the updated AND/OR node still shows "inferred_belief". Not really that big of a deal, and not a high priority. You can opt to quickly correct this, but I will still approve of the rest. Well done!

Currently, the Tooltip just makes use of the type (not the label), so the belief ends up showing "basic_belief" and the updated AND/OR node still shows "inferred_belief". Not really that big of a deal, and not a high priority. You can opt to quickly correct this, but I will still approve of the rest. Well done!
9828273 commented 2026-01-23 10:05:41 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
9828273 commented 2026-01-23 10:05:42 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
0950726 commented 2026-01-23 12:57:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
0950726 commented 2026-01-23 12:57:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
0950726 commented 2026-01-23 12:57:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit f9e0eb95f8

mentioned in commit f9e0eb95f878a627565f6d1fd0d114af1cfd1914
0950726 (Migrated from git.science.uu.nl) merged commit f9e0eb95f8 into dev 2026-01-23 12:57:36 +00:00
9828273 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
0950726 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:31:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
9828273
0950726
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#42
Delete Branch "feat/add-inferred-belief-node"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?