pepperplus/pepperplus-ui
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

WIP: Draft: feat: added editor warning system and more user feedback #45

Closed
j.gerla wants to merge 43 commits from feat/editor-user-feedback into dev
pull from: feat/editor-user-feedback
merge into: pepperplus:dev
Conversation 27 Commits 43 Files Changed 27 +2013 -114
j.gerla commented 2026-01-22 19:37:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

to test:

  • run 'npx jest' to ensure all tests pass
  • run 'npx eslint --fix' and ensure there are no errors
  • There is proper documentation for the code
  • hovering over a nodehandle shows a tooltip describing possible connections
  • There is a warning sidebar that shows all registered editor warnings
  • The sidebar can be filtered by error severity
  • There are warnings (of any type) for all situations that could result in an invalid program
  • Other warnings also exist, although not all situations that could be covered by a warning have warnings
  • If the cause for a warning is resolved, the related warning is removed from the sidebar
  • If you click on any warning that isn't a global warning, the editor moves to the node it is about

ref: N25B-450

to test: * [x] run 'npx jest' to ensure all tests pass * [x] run 'npx eslint --fix' and ensure there are no errors * [x] There is proper documentation for the code * [x] hovering over a nodehandle shows a tooltip describing possible connections * [x] There is a warning sidebar that shows all registered editor warnings * [x] The sidebar can be filtered by error severity * [x] There are warnings (of any type) for all situations that could result in an invalid program * [x] Other warnings also exist, although not all situations that could be covered by a warning have warnings * [x] If the cause for a warning is resolved, the related warning is removed from the sidebar * [x] If you click on any warning that isn't a global warning, the editor moves to the node it is about ref: N25B-450
j.gerla commented 2026-01-22 19:37:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

assigned to @j.gerla

assigned to @j.gerla
9828273 commented 2026-01-23 10:06:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item run 'npx jest' to ensure all tests pass as completed

marked the checklist item **run 'npx jest' to ensure all tests pass** as completed
9828273 commented 2026-01-23 10:07:31 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item run 'npx eslint --fix' and ensure there are no errors as completed

marked the checklist item **run 'npx eslint \-\-fix' and ensure there are no errors** as completed
9828273 commented 2026-01-23 10:08:45 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item hovering over a nodehandle shows a tooltip describing possible connections as completed

marked the checklist item **hovering over a nodehandle shows a tooltip describing possible connections** as completed
9828273 commented 2026-01-23 10:08:49 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item There is a warning sidebar that shows all registered editor warnings as completed

marked the checklist item **There is a warning sidebar that shows all registered editor warnings** as completed
9828273 commented 2026-01-23 10:09:04 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item The sidebar can be filtered by error severity as completed

marked the checklist item **The sidebar can be filtered by error severity** as completed
9828273 commented 2026-01-23 10:12:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

I have checked the 6th checkbox, but realize that you probably can't ensure that there are warnings (of any type) for all situation[s] that could break a program, even though you did cover the needed scope.

I have checked the 6th checkbox, but realize that you probably can't ensure that there `are warnings (of any type) for all situation[s] that could break a program`, even though you did cover the needed scope.
9828273 commented 2026-01-23 10:12:28 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item there are warnings (of any type) for all situation that could break a program as completed

marked the checklist item **there are warnings \(of any type\) for all situation that could break a program** as completed
9828273 commented 2026-01-23 10:12:40 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item other warnings also exist, although not all situations that could be covered by a warning have warnings as completed

marked the checklist item **other warnings also exist, although not all situations that could be covered by a warning have warnings** as completed
9828273 commented 2026-01-23 10:12:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item if the cause for a warning is resolved the related warning is removed from the sidebar as completed

marked the checklist item **if the cause for a warning is resolved the related warning is removed from the sidebar** as completed
9828273 commented 2026-01-23 10:16:18 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item if you click on any warning that isn't a global warning, the editor moves to the node it is about as completed

marked the checklist item **if you click on any warning that isn't a global warning, the editor moves to the node it is about** as completed
9828273 commented 2026-01-23 10:19:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Make sure that the warnings are also compatible with dark mode. Currently, the container is always light-yellow, resulting in poor readability on dark mode, where the text is white.

Make sure that the warnings are also compatible with dark mode. Currently, the container is always light-yellow, resulting in poor readability on dark mode, where the text is white.
9828273 commented 2026-01-23 10:19:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Having the error window close when all errors is resolved is a specific thing you could (have) integrate(d), however it is probably not the current priority.

Having the error window close when all errors is resolved is a specific thing you could (have) integrate(d), however it is probably not the current priority.
9828273 commented 2026-01-23 10:19:25 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Please add docstring to all the functions in WarningSidebar.tsx and the functions that still lack dosctrings inside EditorWarnings.tsx. Don't forget that having complete documentation should also be part of the checklist for a merge into dev.

Please add docstring to all the functions in `WarningSidebar.tsx` and the functions that still lack dosctrings inside `EditorWarnings.tsx`. Don't forget that having complete documentation should also be part of the checklist for a merge into dev.
9828273 commented 2026-01-23 10:19:26 +00:00 (Migrated from git.science.uu.nl)
Copy Link

requested changes

requested changes
j.gerla commented 2026-01-23 10:42:13 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 641d794c - fix: updated styles to work with darkMode

Compare with previous version

added 1 commit <ul><li>641d794c - fix: updated styles to work with darkMode</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/45/diffs?diff_id=137568&start_sha=7757a046948e33ca6a14835815c5a61fa623b477)
j.gerla commented 2026-01-23 10:45:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 820884f8 - fix: updated styles to work with darkMode

Compare with previous version

added 1 commit <ul><li>820884f8 - fix: updated styles to work with darkMode</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/45/diffs?diff_id=137569&start_sha=641d794cf09f8f1e95c5abd18b5f8628dbd3afca)
j.gerla commented 2026-01-23 10:47:16 +00:00 (Migrated from git.science.uu.nl)
Copy Link

changed the description

changed the description
j.gerla commented 2026-01-23 10:48:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

agree, I have changed the checkbox to be about causing invalid programs, as that is what I intended.

agree, I have changed the checkbox to be about causing invalid programs, as that is what I intended.
j.gerla commented 2026-01-23 16:10:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 85b84c22 - feat: added visibility toggle with autoHide option

Compare with previous version

added 1 commit <ul><li>85b84c22 - feat: added visibility toggle with autoHide option</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/45/diffs?diff_id=137630&start_sha=820884f8aaf52530f2a6f635f7e24ddd60b1b64c)
j.gerla commented 2026-01-23 17:18:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • ee796602 - feat: added documentation comments

Compare with previous version

added 1 commit <ul><li>ee796602 - feat: added documentation comments</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/45/diffs?diff_id=137643&start_sha=85b84c2281a7d4f74d06605a73ab1a320313f538)
j.gerla commented 2026-01-23 17:24:54 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 5 commits

  • ee796602...f9e0eb95 - 4 commits from branch dev
  • 58bd5781 - Merge branch 'dev' into feat/editor-user-feedback

Compare with previous version

added 5 commits <ul><li>ee796602...f9e0eb95 - 4 commits from branch <code>dev</code></li><li>58bd5781 - Merge branch &#39;dev&#39; into feat/editor-user-feedback</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/45/diffs?diff_id=137645&start_sha=ee7966027689e16b86616b39b7162b34d36da322)
j.gerla commented 2026-01-23 17:30:32 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • 53568476 - feat: added warnings to inferredBeliefNodes

Compare with previous version

added 1 commit <ul><li>53568476 - feat: added warnings to inferredBeliefNodes</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/45/diffs?diff_id=137649&start_sha=58bd57818e7d9876132bc1b319ddc8c16038bcf2)
j.gerla commented 2026-01-23 17:30:53 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
j.gerla commented 2026-01-26 15:12:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item There is proper documentation for the code as completed

marked the checklist item **There is proper documentation for the code** as completed
j.gerla commented 2026-01-27 09:47:11 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • a85dbeac - refactor: adapted to fit the split made in monitoringPage

Compare with previous version

added 1 commit <ul><li>a85dbeac - refactor: adapted to fit the split made in monitoringPage</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-ui/-/merge_requests/45/diffs?diff_id=137900&start_sha=53568476d54048559319d1de43f5fa4e2de9991b)
j.gerla commented 2026-01-27 15:41:33 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked this merge request as draft

marked this merge request as **draft**
9828273 (Migrated from git.science.uu.nl) closed this pull request 2026-01-28 10:16:19 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-ui#45
Delete Branch "feat/editor-user-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?