pepperplus/pepperplus-cb
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Allow subgoals in triggers and empty plan #50

Merged
k.marinus merged 3 commits from fix/trigger-subgoal-error into main 2026-01-30 19:53:52 +00:00
Conversation 13 Commits 3 Files Changed 2 +23 -7
k.marinus commented 2026-01-29 14:26:06 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Copies the goal and changes can_fail to false. Also add a warning for empty plans in goals.

ref: N25B-460

To verify:

  • Style checks pass
  • Pipeline (tests) pass
  • Documentation is up to date
  • Tests are up to date (new code is covered)
  • Ensure that the problematic program (in the YouTrack issue page for N25B-460) now correctly parses and runs (but change the goal names from numbers to actual names, as numbers don't and shouldn't work)
Copies the goal and changes can_fail to false. Also add a warning for empty plans in goals. ref: N25B-460 To verify: - [x] Style checks pass - [x] Pipeline (tests) pass - [x] Documentation is up to date - [ ] Tests are up to date (new code is covered) - [x] Ensure that the problematic program (in the YouTrack issue page for N25B-460) now correctly parses and runs (but change the goal names from numbers to actual names, as numbers don't and shouldn't work)
8464960 commented 2026-01-30 17:12:14 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Ensure that the problematic program (in the YouTrack issue page for N25B-460) now correctly parses and runs (but change the goal names from numbers to actual names, as numbers don't and shouldn't work) as completed

marked the checklist item **Ensure that the problematic program \(in the YouTrack issue page for N25B\-460\) now correctly parses and runs \(but change the goal names from numbers to actual names, as numbers don't and shouldn't work\)** as completed
8464960 commented 2026-01-30 17:12:17 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Tests are up to date (new code is covered) as completed

marked the checklist item **Tests are up to date \(new code is covered\)** as completed
8464960 commented 2026-01-30 17:12:20 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Tests are up to date (new code is covered) as incomplete

marked the checklist item **Tests are up to date \(new code is covered\)** as incomplete
8464960 commented 2026-01-30 17:12:29 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Style checks pass as completed

marked the checklist item **Style checks pass** as completed
8464960 commented 2026-01-30 17:14:53 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Pipeline (tests) pass as completed

marked the checklist item **Pipeline \(tests\) pass** as completed
8464960 commented 2026-01-30 17:14:55 +00:00 (Migrated from git.science.uu.nl)
Copy Link

marked the checklist item Documentation is up to date as completed

marked the checklist item **Documentation is up to date** as completed
8464960 commented 2026-01-30 17:16:07 +00:00 (Migrated from git.science.uu.nl)
Copy Link

Björn's program now runs (the problematic program (in the YouTrack issue page for N25B-460)).

I also tried overriding triggers that have goals in their plan and it seems to work.

Style is same as other agentspeak generator code, looks good!

I approve!

Björn's program now runs (the problematic program (in the YouTrack issue page for N25B-460)). I also tried overriding triggers that have goals in their plan and it seems to work. Style is same as other agentspeak generator code, looks good! I approve!
8464960 commented 2026-01-30 17:16:08 +00:00 (Migrated from git.science.uu.nl)
Copy Link

approved this merge request

approved this merge request
8464960 commented 2026-01-30 17:16:37 +00:00 (Migrated from git.science.uu.nl)
Copy Link

resolved all threads

resolved all threads
k.marinus commented 2026-01-30 17:19:36 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 10 commits

  • f79b65a6...51015dbb - 9 commits from branch main
  • 1337b1f0 - Merge branch 'main' into fix/trigger-subgoal-error

Compare with previous version

added 10 commits <ul><li>f79b65a6...51015dbb - 9 commits from branch <code>main</code></li><li>1337b1f0 - Merge branch &#39;main&#39; into fix/trigger-subgoal-error</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/50/diffs?diff_id=138137&start_sha=f79b65a6fae1f6fee08e17a33c66944370aa4da6)
k.marinus commented 2026-01-30 18:30:44 +00:00 (Migrated from git.science.uu.nl)
Copy Link

added 1 commit

  • b53bf872 - chore: better name checks for ProgramElement

Compare with previous version

added 1 commit <ul><li>b53bf872 - chore: better name checks for ProgramElement</li></ul> [Compare with previous version](/ics/sp/2025/n25b/pepperplus-cb/-/merge_requests/50/diffs?diff_id=138139&start_sha=1337b1f06b3a89455b7b20eebfac47ed0fdd4399)
k.marinus commented 2026-01-30 19:53:52 +00:00 (Migrated from git.science.uu.nl)
Copy Link

mentioned in commit 2e717ec277

mentioned in commit 2e717ec2770a376b13bcd1bca5c14134b292545f
k.marinus (Migrated from git.science.uu.nl) merged commit 2e717ec277 into main 2026-01-30 19:53:52 +00:00
8464960 (Migrated from git.science.uu.nl) approved these changes 2026-02-02 13:29:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
8464960
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kasper twirre pepperplus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pepperplus/pepperplus-cb#50
Delete Branch "fix/trigger-subgoal-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?